Uh oh!
There was an error while loading. Please reload this page.
Add Bound::cloned() - #61376
Conversation
rust-highfive
commented
May 30, 2019
(rust_highfive has picked a reviewer for you, use r? to override) |
Open question: should |
rust-highfive
commented
May 30, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Centril
commented
May 30, 2019
r? @sfackler |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rust-highfive
commented
May 31, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
czipperz
commented
May 31, 2019
Some bozo has to write tests for this lol |
cuviper
commented
May 31, 2019
IMO the doc test is sufficient, but it needs to be a |
rust-highfive
commented
May 31, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jun 1, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
sfackler
commented
Jun 1, 2019
LGTM but the build is still failing. Looks like you just need to enable the feature in core's lib.rs |
rust-highfive
commented
Jun 1, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
czipperz
commented
Jun 1, 2019
Is there a precedent for testing unstable features in external test directories? |
sfackler
commented
Jun 1, 2019
You just need to add the feature gate here: https://github.com/rust-lang/rust/blob/master/src/libcore/tests/lib.rs#L1 |
czipperz
commented
Jun 1, 2019
I probably need to feature gate the doctest as well |
bors
commented
Jun 6, 2019
⌛ Testing commit c1bc8f1 with merge ca556899aaebe5ce776b65173b0bcb5103a9418b... |
bors
commented
Jun 6, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Jun 6, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
emilyalbini
commented
Jun 6, 2019
The rand crate broke. |
bors
commented
Jun 6, 2019
⌛ Testing commit c1bc8f1 with merge 58cd42efe1f628678e4700e852cae54e9d39ab77... |
Add Bound::cloned() Suggested by rust-lang#61356
Centril
commented
Jun 6, 2019
@bors retry |
bors
commented
Jun 6, 2019
⌛ Testing commit c1bc8f1 with merge d4943ea7d0e3102ae46319a21757036fa8d59eb4... |
bors
commented
Jun 6, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Jun 6, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Centril
commented
Jun 6, 2019
@bors retry |
Add Bound::cloned() Suggested by rust-lang#61356
Suggested by #61356