Skip to content

Add an unusual-conversion example to to_uppercase - #61419

Merged
bors merged 1 commit into
rust-lang:masterfrom
scottmcm:casing-is-on-strings
Jun 4, 2019
Merged

Add an unusual-conversion example to to_uppercase#61419
bors merged 1 commit into
rust-lang:masterfrom
scottmcm:casing-is-on-strings

Conversation

@scottmcm

Copy link
Copy Markdown
Member

Like how to_lowercase has ὈΔΥΣΣΕΎΣ.

Like how to_lowercase has ὈΔΥΣΣΕΎΣ.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2019
Comment threadsrc/liballoc/str.rs
///
/// One character can become multiple:
/// ```
/// let s = "tschüß";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: uper-case ßis a thing nowadays. Not sure if Unicode will ever want to use that for 'ß'.to_uppwercase() though. ;)

@cramertj

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 3, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit dfd9d04 has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 4, 2019
…amertj
Add an unusual-conversion example to to_uppercase
Like how to_lowercase has ὈΔΥΣΣΕΎΣ.
@CentrilCentril mentioned this pull request Jun 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 4, 2019
…amertj
Add an unusual-conversion example to to_uppercase
Like how to_lowercase has ὈΔΥΣΣΕΎΣ.
@CentrilCentril mentioned this pull request Jun 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 4, 2019
…amertj
Add an unusual-conversion example to to_uppercase
Like how to_lowercase has ὈΔΥΣΣΕΎΣ.
@CentrilCentril mentioned this pull request Jun 4, 2019
bors added a commit that referenced this pull request Jun 4, 2019
Rollup of 13 pull requests
Successful merges:
- #61135 (Fix documentation of `Rc::make_mut` regarding `rc::Weak`.)
- #61404 (miri unsizing: fix projecting into a field of an operand)
- #61409 (Fix an ICE with a const argument in a trait)
- #61413 (Re-implement async fn drop order lowering )
- #61419 (Add an unusual-conversion example to to_uppercase)
- #61420 (Succinctify splice docs)
- #61444 (Suggest using `as_ref` on `*const T`)
- #61446 (On TerminatorKind::DropAndReplace still handle unused_mut correctly)
- #61485 (azure: retry s3 upload if it fails)
- #61489 (ci: Reenable step timings on AppVeyor)
- #61496 (Do not panic in tidy on unbalanced parentheses in cfg's)
- #61497 (Treat 0 as special value for codegen-units-std)
- #61499 (Add regression test for existential type ICE #53457)
Failed merges:
r? @ghost
@bors
bors merged commit dfd9d04 into rust-lang:masterJun 4, 2019
@scottmcm
scottmcm deleted the casing-is-on-strings branch June 7, 2019 15:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@scottmcm@rust-highfive@cramertj@bors@RalfJung