Skip to content

std::time fix typo on now() comments - #61433

Closed
bekicot wants to merge 1 commit into
rust-lang:masterfrom
bekicot:patch-1
Closed

std::time fix typo on now() comments#61433
bekicot wants to merge 1 commit into
rust-lang:masterfrom
bekicot:patch-1

Conversation

@bekicot

@bekicotbekicot commented Jun 1, 2019

Copy link
Copy Markdown

Fix typo, update words, and remove some redundant word.

@bekicot
std::time fix typo on now() comments
cc467cd
Fix typo, update words, and remove some redundant word.
@rust-highfive

rust-highfive commented Jun 1, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2019
czipperz
czipperz reviewed Jun 1, 2019
View reviewed changes
Comment threadsrc/libstd/time.rs
//
// It simply seems that this it just happens so that a lot in the wild
// we're seeing panics across various platforms where consecutive calls
// It seems that this is just happens a lot in the wild.

@czipperzczipperzJun 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This grammar is still messed up. Try removing the word is.

@tesuji

This comment has been minimized.

Sign in to view
@rustbotrustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jun 1, 2019
@kennytm

kennytm commented Jun 1, 2019

Copy link
Copy Markdown
Member

r=me after czipperz's comment is fixed.

@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2019
@Centril

Centril commented Jun 10, 2019

Copy link
Copy Markdown
Contributor

Ping from triage @bekicot ^---

@bekicot

bekicot commented Jun 13, 2019

Copy link
Copy Markdown
Author

@Centril Sorry for the delay. Currently having a very slow internet connection (on vacation). Cant clone the repository to do the required amend. Be back tomorrow and will resolve.

@jonas-schievink

jonas-schievink commented Jun 22, 2019

Copy link
Copy Markdown
Contributor

Triage ping @bekicot, this still needs the tiny change above

@joelpalmer

joelpalmer commented Jul 22, 2019

Copy link
Copy Markdown

@rustbot modify labels to +S-inactive-closed and -S-waiting-on-author

From Triage: @bekicot Closing due to inactivity. Please re-open before pushing changes. Thank you for the PR.

@rustbotrustbot added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2019
@ghostghost mentioned this pull request Oct 5, 2019
Merged
tmandry added a commit to tmandry/rust that referenced this pull request Oct 5, 2019
@tmandry
Rollup merge ofrust-lang#65126- BO41:time_typo, r=kennytm
07ee1e2
Fix typo on `now()` comments
Fix typo, update words, and remove some redundant word.
Also rustfmt on the rest of the file (hope this is okay :)
revival of rust-lang#61433
r? @kennytm
tmandry added a commit to tmandry/rust that referenced this pull request Oct 6, 2019
@tmandry
Rollup merge ofrust-lang#65126- BO41:time_typo, r=kennytm
d54082e
Fix typo on `now()` comments
Fix typo, update words, and remove some redundant word.
Also rustfmt on the rest of the file (hope this is okay :)
revival of rust-lang#61433
r? @kennytm
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@czipperzczipperzczipperz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@kennytmkennytm

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-inactiveStatus: Inactive and waiting on the author. This is often applied to closed PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@bekicot@rust-highfive@tesuji@kennytm@Centril@jonas-schievink@joelpalmer@czipperz@Dylan-DPC-zz@rustbot