Skip to content

Remove unneeded feature attr from atomic integers doctests - #61453

Merged
bors merged 1 commit into
rust-lang:masterfrom
tesuji:nouse-featuregate-integer_atomics
Jun 5, 2019
Merged

Remove unneeded feature attr from atomic integers doctests#61453
bors merged 1 commit into
rust-lang:masterfrom
tesuji:nouse-featuregate-integer_atomics

Conversation

@tesuji

@tesujitesuji commented Jun 2, 2019

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2019
@tesuji

This comment has been minimized.

Sign in to view
@rustbotrustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jun 2, 2019
@tesuji

This comment has been minimized.

Sign in to view
@bors

bors commented Jun 2, 2019

Copy link
Copy Markdown
Collaborator

@lzutao: 🔑 Insufficient privileges: not in try users

@Centril

Centril commented Jun 2, 2019

Copy link
Copy Markdown
Contributor

r? @sfackler

@rust-highfiverust-highfive assigned sfackler and unassigned CentrilJun 2, 2019
@sfackler

sfackler commented Jun 2, 2019

Copy link
Copy Markdown
Member

Where else is $extra_feature used? It seems like it can be removed entirely from the macro, right?

@tesuji

tesuji commented Jun 2, 2019

Copy link
Copy Markdown
ContributorAuthor

I was thinking that #![feature(integer_atomics)] still be used in unstable
Atomic integers (for example: https://doc.rust-lang.org/nightly/std/sync/atomic/struct.AtomicU8.html#method.fetch_min). Looks like I am wrong:
https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=6da6afeaf1fe1a4f018682886a0c39d4

@tesuji
tesujiforce-pushed the nouse-featuregate-integer_atomics branch 2 times, most recently from f256ebd to 90d8781CompareJune 2, 2019 15:10
@tesuji

tesuji commented Jun 2, 2019

Copy link
Copy Markdown
ContributorAuthor

AtomicU128 and AtomicI128 are unstable and need $extra_feature in doctest.
Should I keep it? @sfackler

tesuji
tesuji commented Jun 2, 2019
View reviewed changes
Comment threadsrc/test/run-pass/atomic-alignment.rs Outdated
@sfackler

sfackler commented Jun 2, 2019

Copy link
Copy Markdown
Member

Oh, okay.

@tesuji
tesujiforce-pushed the nouse-featuregate-integer_atomics branch from 90d8781 to f60b5f1CompareJune 4, 2019 13:25
@tesuji

tesuji commented Jun 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Ping @sfackler , this PR is ready to review again.

@sfackler

sfackler commented Jun 4, 2019

Copy link
Copy Markdown
Member

@bors r+ rollup

Thanks!

@bors

bors commented Jun 4, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f60b5f1 has been approved by sfackler

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2019
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Jun 4, 2019
@emilyalbini
Rollup merge ofrust-lang#61453- lzutao:nouse-featuregate-integer_at…
98176fc
…omics, r=sfackler
Remove unneeded feature attr from atomic integers doctests
Closesrust-lang#61448
r? @Centril
@emilyalbiniemilyalbini mentioned this pull request Jun 4, 2019
Merged
bors added a commit that referenced this pull request Jun 4, 2019
@bors
Auto merge of#61527- pietroalbini:rollup-vhxyqlk, r=pietroalbini
81eb152
Rollup of 5 pull requests
Successful merges:
- #61069 (Make MIR drop terminators borrow the dropped location)
- #61453 (Remove unneeded feature attr from atomic integers doctests)
- #61488 (Fix NLL typeck ICEs)
- #61500 (Fix regression 61475)
- #61523 (Hide gen_future API from documentation)
Failed merges:
r? @ghost
@bors
bors merged commit f60b5f1 into rust-lang:masterJun 5, 2019
@tesuji
tesuji deleted the nouse-featuregate-integer_atomics branch June 5, 2019 02:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sfacklersfackler

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature attribute can be removed from atomic integers doctests.

6 participants

@tesuji@bors@Centril@sfackler@rust-highfive@rustbot