Remove promoted intrinsics caller type checking from const context

[vertexclique]

Removes promoting intrinsics that checks the caller type in const context. PR linked to issue defined in #61399 (comment)

[rust-highfive]

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

[vertexclique]

r? @oli-obk

[RalfJung]

So this does not fix the bug that we allow calling intrinsics in const fn, right?

[vertexclique]

So this does not fix the bug that we allow calling intrinsics in const fn, right?

Removed part will be added to

rust/src/librustc_mir/transform/qualify_consts.rs

Lines 1228 to 1230 in 7096ff0

	// no need to check feature gates, intrinsics are only callable
	// from the libstd or with forever unstable feature gates

under visit_terminator_kind. That will fix the bug seems like.

[eddyb]

@oli-obk We still need a PR that fixes this code and adds a test.

[Dylan-DPC-zz]

ping from triage @eddyb@vertexclique@oli-obk any updates?

[vertexclique]

This can be closed, we are not going to use this. We have different PR to solve this one.

[RalfJung]

@vertexclique which PR is that? Is it #61835 ?

[vertexclique]

Yes, it's that. It will be here: #61835