Uh oh!
There was an error while loading. Please reload this page.
Utilize cfg(bootstrap) over cfg(stage0) - #61494
Merged
Merged
Conversation
alexcrichton
commented
Jun 3, 2019
Member
@bors: r+ |
bors
commented
Jun 3, 2019
Collaborator
📌 Commit d04d56d has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 4, 2019
…ap, r=alexcrichton Utilize cfg(bootstrap) over cfg(stage0) Also removes stage1, stage2 cfgs being passed to rustc to ensure that stage1 and stage2 are only differentiated as a group (i.e., only through not bootstrap). Fixesrust-lang#53582 r? @alexcrichton
Centril
commented
Jun 4, 2019
Contributor
Failed in #61509 (comment), @bors r- |
Also removes stage1, stage2 cfgs being passed to rustc to ensure that stage1 and stage2 are only differentiated as a group (i.e., only through not bootstrap).
Mark-Simulacrumforce-pushed
the
move-to-cfg-bootstrap
branch
from
June 5, 2019 23:58
d04d56d to
bea2e55CompareMark-Simulacrum
commented
Jun 5, 2019
MemberAuthor
This PR probably shouldn't be rolled up as anything that adds @bors r=alexcrichton |
bors
commented
Jun 5, 2019
Collaborator
📌 Commit bea2e55 has been approved by |
Centril
commented
Jun 6, 2019
Contributor
@Mark-Simulacrum Please use @bors rollup=never |
bors
commented
Jun 6, 2019
Collaborator
bors added a commit
that referenced
this pull request
Jun 6, 2019
…richton Utilize cfg(bootstrap) over cfg(stage0) Also removes stage1, stage2 cfgs being passed to rustc to ensure that stage1 and stage2 are only differentiated as a group (i.e., only through not bootstrap). Fixes#53582 r? @alexcrichton
bors
commented
Jun 6, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes stage1, stage2 cfgs being passed to rustc to ensure that
stage1 and stage2 are only differentiated as a group (i.e., only through
not bootstrap).
Fixes#53582
r? @alexcrichton