Skip to content

libcore/pin: Minor grammar corrections for module documentation - #61599

Merged
bors merged 1 commit into
rust-lang:masterfrom
laumann:pin-docs-minor-edits
Jun 7, 2019
Merged

libcore/pin: Minor grammar corrections for module documentation#61599
bors merged 1 commit into
rust-lang:masterfrom
laumann:pin-docs-minor-edits

Conversation

@laumann

Copy link
Copy Markdown

This is by no means exhaustive, but I noticed a few grammatical errors
when reading the documentation, and decided just to push these.

Some standard rules/guidelines I followed:

  • Do not split infinitives, ie "not to move" instead of "to not move"

  • Do not use "since" when you want to say "because" or "as" - the word
    "since" has a temporal meaning

In addition:

  • Fix a small typo: "Similarily" should be "Similarly"

  • Delete double-spaces after full stop

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2019
@Mark-Simulacrum

Copy link
Copy Markdown
Member

I don't feel comfortable reviewing this one way or another... randomly reassigning to r? @Centril

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me rollup with changes below.

Comment threadsrc/libcore/pin.rs Outdated
Comment threadsrc/libcore/pin.rs Outdated
Comment threadsrc/libcore/pin.rs Outdated
@laumann

Copy link
Copy Markdown
Author

@Centril My Github foo is not that strong, I have never used suggestions, if I use the UI to accept them, does that mean four individual commits? Would it then be better just to push you suggestions as one commit?

@Centril

Copy link
Copy Markdown
Contributor

@laumann GitHub has a "Add suggestion to batch" functionality if you want to do a single commit; otherwise doing it manually is fine also. Up to you. :)

@laumann

Copy link
Copy Markdown
Author

OK, will do, thanks!

This is by no means exhaustive, but I noticed a few grammatical errors
when reading the documentation, and decided just to push these.
Some standard rules/guidelines I followed:
* Do not split infinitives, ie "not to move" instead of "to not move"
* Do not use "since" when you want to say "because" or "as" - the word
"since" has a temporal meaning
In addition:
* Fix a small typo: "Similarily" should be "Similarly"
* Delete double-spaces after full stop
@Centril

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jun 7, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit fb61b85 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 7, 2019
…tril
libcore/pin: Minor grammar corrections for module documentation
This is by no means exhaustive, but I noticed a few grammatical errors
when reading the documentation, and decided just to push these.
Some standard rules/guidelines I followed:
* Do not split infinitives, ie "not to move" instead of "to not move"
* Do not use "since" when you want to say "because" or "as" - the word
"since" has a temporal meaning
In addition:
* Fix a small typo: "Similarily" should be "Similarly"
* Delete double-spaces after full stop
@CentrilCentril mentioned this pull request Jun 7, 2019
bors added a commit that referenced this pull request Jun 7, 2019
Rollup of 4 pull requests
Successful merges:
- #61332 (Remove asterisk suggestion for move errors in borrowck)
- #61532 ([const-prop] Support Rvalue::{Ref,Len} and Deref)
- #61586 (ci: Disable LLVM/debug assertions for asmjs builder)
- #61599 (libcore/pin: Minor grammar corrections for module documentation)
Failed merges:
r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jun 7, 2019
…tril
libcore/pin: Minor grammar corrections for module documentation
This is by no means exhaustive, but I noticed a few grammatical errors
when reading the documentation, and decided just to push these.
Some standard rules/guidelines I followed:
* Do not split infinitives, ie "not to move" instead of "to not move"
* Do not use "since" when you want to say "because" or "as" - the word
"since" has a temporal meaning
In addition:
* Fix a small typo: "Similarily" should be "Similarly"
* Delete double-spaces after full stop
@CentrilCentril mentioned this pull request Jun 7, 2019
bors added a commit that referenced this pull request Jun 7, 2019
Rollup of 7 pull requests
Successful merges:
- #61332 (Remove asterisk suggestion for move errors in borrowck)
- #61532 ([const-prop] Support Rvalue::{Ref,Len} and Deref)
- #61586 (ci: Disable LLVM/debug assertions for asmjs builder)
- #61599 (libcore/pin: Minor grammar corrections for module documentation)
- #61603 (Increases heap size available during testing for SGX)
- #61605 (Fix slice const generic length display)
- #61618 (make the backtrace field of EvalError private)
Failed merges:
r? @ghost
@bors
bors merged commit fb61b85 into rust-lang:masterJun 7, 2019
@laumann
laumann deleted the pin-docs-minor-edits branch June 11, 2019 18:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@laumann@rust-highfive@Mark-Simulacrum@Centril@bors