Uh oh!
There was an error while loading. Please reload this page.
libcore/pin: Minor grammar corrections for module documentation - #61599
Conversation
rust-highfive
commented
Jun 6, 2019
(rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Jun 6, 2019
I don't feel comfortable reviewing this one way or another... randomly reassigning to r? @Centril |
Centril
left a comment
There was a problem hiding this comment.
Thanks! r=me rollup with changes below.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
laumann
commented
Jun 7, 2019
@Centril My Github foo is not that strong, I have never used suggestions, if I use the UI to accept them, does that mean four individual commits? Would it then be better just to push you suggestions as one commit? |
Centril
commented
Jun 7, 2019
@laumann GitHub has a "Add suggestion to batch" functionality if you want to do a single commit; otherwise doing it manually is fine also. Up to you. :) |
laumann
commented
Jun 7, 2019
OK, will do, thanks! |
This is by no means exhaustive, but I noticed a few grammatical errors when reading the documentation, and decided just to push these. Some standard rules/guidelines I followed: * Do not split infinitives, ie "not to move" instead of "to not move" * Do not use "since" when you want to say "because" or "as" - the word "since" has a temporal meaning In addition: * Fix a small typo: "Similarily" should be "Similarly" * Delete double-spaces after full stop
Centril
commented
Jun 7, 2019
@bors r+ rollup |
bors
commented
Jun 7, 2019
📌 Commit fb61b85 has been approved by |
…tril libcore/pin: Minor grammar corrections for module documentation This is by no means exhaustive, but I noticed a few grammatical errors when reading the documentation, and decided just to push these. Some standard rules/guidelines I followed: * Do not split infinitives, ie "not to move" instead of "to not move" * Do not use "since" when you want to say "because" or "as" - the word "since" has a temporal meaning In addition: * Fix a small typo: "Similarily" should be "Similarly" * Delete double-spaces after full stop
Rollup of 4 pull requests Successful merges: - #61332 (Remove asterisk suggestion for move errors in borrowck) - #61532 ([const-prop] Support Rvalue::{Ref,Len} and Deref) - #61586 (ci: Disable LLVM/debug assertions for asmjs builder) - #61599 (libcore/pin: Minor grammar corrections for module documentation) Failed merges: r? @ghost
…tril libcore/pin: Minor grammar corrections for module documentation This is by no means exhaustive, but I noticed a few grammatical errors when reading the documentation, and decided just to push these. Some standard rules/guidelines I followed: * Do not split infinitives, ie "not to move" instead of "to not move" * Do not use "since" when you want to say "because" or "as" - the word "since" has a temporal meaning In addition: * Fix a small typo: "Similarily" should be "Similarly" * Delete double-spaces after full stop
Rollup of 7 pull requests Successful merges: - #61332 (Remove asterisk suggestion for move errors in borrowck) - #61532 ([const-prop] Support Rvalue::{Ref,Len} and Deref) - #61586 (ci: Disable LLVM/debug assertions for asmjs builder) - #61599 (libcore/pin: Minor grammar corrections for module documentation) - #61603 (Increases heap size available during testing for SGX) - #61605 (Fix slice const generic length display) - #61618 (make the backtrace field of EvalError private) Failed merges: r? @ghost
This is by no means exhaustive, but I noticed a few grammatical errors
when reading the documentation, and decided just to push these.
Some standard rules/guidelines I followed:
Do not split infinitives, ie "not to move" instead of "to not move"
Do not use "since" when you want to say "because" or "as" - the word
"since" has a temporal meaning
In addition:
Fix a small typo: "Similarily" should be "Similarly"
Delete double-spaces after full stop