Skip to content

Rename remaining "Eval" to "Interp" - #61625

Merged
bors merged 3 commits into
rust-lang:masterfrom
RalfJung:eval-interp
Jun 8, 2019
Merged

Rename remaining "Eval" to "Interp"#61625
bors merged 3 commits into
rust-lang:masterfrom
RalfJung:eval-interp

Conversation

@RalfJung

Copy link
Copy Markdown
Member

Renaming done by sed.

r? @oli-obk

Fixes#54395.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2019
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 7, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 3aca71f has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 7, 2019
Rename remaining "Eval" to "Interp"
Renaming done by sed.
r? @oli-obkFixesrust-lang#54395.
@CentrilCentril mentioned this pull request Jun 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 7, 2019
Rename remaining "Eval" to "Interp"
Renaming done by sed.
r? @oli-obkFixesrust-lang#54395.
@CentrilCentril mentioned this pull request Jun 7, 2019
@Centril

Copy link
Copy Markdown
Contributor

Failed in #61637 (comment), @bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2019
@RalfJung

Copy link
Copy Markdown
MemberAuthor

This was caused by a conflict. I rebased.

@bors r=oli-obk

@bors

bors commented Jun 8, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit b86c050 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 8, 2019
@bors

bors commented Jun 8, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b86c050 with merge 5c45343...

bors added a commit that referenced this pull request Jun 8, 2019
Rename remaining "Eval" to "Interp"
Renaming done by sed.
r? @oli-obkFixes#54395.
@bors

bors commented Jun 8, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 5c45343 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 8, 2019
@bors
bors merged commit b86c050 into rust-lang:masterJun 8, 2019
@rust-highfive

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #61625!

Tested on commit 5c45343.
Direct link to PR: #61625

💔 miri on windows: test-pass → build-fail (cc @oli-obk@RalfJung@eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → build-fail (cc @oli-obk@RalfJung@eddyb, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 8, 2019
Tested on commit rust-lang/rust@5c45343.
Direct link to PR: <rust-lang/rust#61625>
💔 miri on windows: test-pass → build-fail (cc @oli-obk@RalfJung@eddyb, @rust-lang/infra).
💔 miri on linux: test-pass → build-fail (cc @oli-obk@RalfJung@eddyb, @rust-lang/infra).
@RalfJung
RalfJung deleted the eval-interp branch June 9, 2019 10:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get the eval out of miri engine

5 participants

@RalfJung@oli-obk@bors@Centril@rust-highfive