Skip to content

Minimize use of #![feature(custom_attribute)] - #61660

Merged
bors merged 6 commits into
rust-lang:masterfrom
petrochenkov:nocusta
Jun 9, 2019
Merged

Minimize use of #![feature(custom_attribute)]#61660
bors merged 6 commits into
rust-lang:masterfrom
petrochenkov:nocusta

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

Some preparations before resurrecting #57921.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2019

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? @Centril

r=me with or without changes for the notes below.

Comment threadsrc/test/ui/lint/lint-obsolete-attr.rs Outdated
Comment threadsrc/test/ui/lint/lint-unknown-attr.rs Outdated
@CentrilCentril assigned Centril and unassigned eddybJun 8, 2019
@petrochenkov

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril

@bors

bors commented Jun 8, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit ee189ae has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 8, 2019
Minimize use of `#![feature(custom_attribute)]`
Some preparations before resurrecting rust-lang#57921.
@CentrilCentril mentioned this pull request Jun 8, 2019
bors added a commit that referenced this pull request Jun 8, 2019
Rollup of 6 pull requests
Successful merges:
- #61646 (Remove useless allocations in macro_rules follow logic.)
- #61658 (remove useless ident() functions in const tests)
- #61660 (Minimize use of `#![feature(custom_attribute)]`)
- #61666 (Add test for trait ICE)
- #61669 ( syntax: Remove `Deref` impl from `Token`)
- #61670 (Update RLS)
Failed merges:
r? @ghost
@bors
bors merged commit ee189ae into rust-lang:masterJun 9, 2019
@petrochenkov
petrochenkov deleted the nocusta branch June 9, 2019 07:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@rust-highfive@bors@Centril@eddyb