Uh oh!
There was an error while loading. Please reload this page.
[DO NOT MERGE] see what breaks when we remove this recursive-enum-discriminants hack - #61723
[DO NOT MERGE] see what breaks when we remove this recursive-enum-discriminants hack#61723RalfJung wants to merge 1 commit into
Conversation
rust-highfive
commented
Jun 10, 2019
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
RalfJung
commented
Jun 10, 2019
@bors try |
bors
commented
Jun 10, 2019
[DO NOT MERGE] see what breaks when we remove this recursive-enum-discriminants check
rust-highfive
commented
Jun 10, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Jun 10, 2019
☀️ Try build successful - checks-travis |
RalfJung
commented
Jun 10, 2019
@rust-lang/infra could we get a check-only crater run for this? |
estebank
commented
Jun 10, 2019
@craterbot run mode=check-only |
craterbot
commented
Jun 10, 2019
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
oli-obk
commented
Jun 11, 2019
There's no point in cratering this. Certain old winapi versions that are in use will fail, but they won't be tested on crater. see #49765 and linked issues/PRs |
RalfJung
commented
Jun 11, 2019
Seriously, winapi? 😢 Do you think there is any point in issuing a deprecation warning such that, maybe in a year or two we can remove this accidental feature? (I am still assuming this is an accident -- the feature is incredibly niche, can be easily worked around by factoring the common code into a |
emilyalbini
commented
Jun 11, 2019
@craterbot abort |
craterbot
commented
Jun 11, 2019
🗑️ Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
No description provided.