Updated Binary Search docs to show insert into an already sorted list

[ptallo]

Resolves: #61684

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[jonas-schievink]

Looks good to me, but let's wait for someone on the docs/libs team to look over it. Thanks for the PR :)

[ptallo]

No problem! Thanks for the review help, grammar isn't my strong suit!

[rust-highfive]

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:05867abf:start=1560273737566163403,finish=1560273826258058461,duration=88691895058
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout
Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:04:02] tidy error: /checkout/src/libcore/slice/mod.rs:1379: trailing whitespace
[00:04:07] some tidy checks failed
[00:04:07] [00:04:07] [00:04:07] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:07] [00:04:07] [00:04:07] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:07] Build completed unsuccessfully in 0:01:12
---
travis_time:end:0f142a37:start=1560274084637241665,finish=1560274084641809418,duration=4567753
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c6102ae
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:071f3811
travis_time:start:071f3811
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:150a6366
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[ondj]

Why something like this?

ifletErr(pos) = s.binary_search(&num){
s.insert(pos, num);}

[ptallo]

was squashing cleanup commits into one commit, and @ondj I believe that would work as well, this way just seemed like it would allow more modification (editing of the OK() or Err() blocks)

[czipperz]

Ping @ptallo

[Mark-Simulacrum]

Hm, I think we should be inserting regardless of finding the item here, so filling out this Ok branch with an insert as well would be good, perhaps even illustrating that by doing something like Ok(idx) | Err(idx) => s.insert(idx, num) in an if let.

[ptallo]

I believe my new commit is more what you were looking for. Do I need to squash the commits or will the merge do that for me?

[Mark-Simulacrum]

You'll need to squash the commits; it also looks like you have a build failure here -- I suspect the ; after the if let.

[Mark-Simulacrum]

r? @Mark-Simulacrum

I'll take over review here for now, left a comment.

[czipperz]

I believe this is invalid syntax and should be if let Ok(idx) | Err(idx) = idx {

[czipperz]

See error:

error: expected one of `=` or `|`, found `{`
--> slice/mod.rs:1361:27
|
8 | if let Ok(idx) | Err(idx) {
| ^ expected one of `=` or `|` here

[NOVA-ME]

There have been losed a semicolon
s.insert(idx,num);

[totsteps]

ping from triage, @ptallo any updates on this?

[fmckeogh]

Hello! Second ping from triage, @ptallo please feel free to reopen when you have the time (Also note that pushing to the PR while it is closed prevents it from being reopened).

@rustbot modify labels to +S-inactive-closed, -S-waiting-on-author

[tesuji]

I rework in #63442.