Skip to content

ci: Enable toolstate tracking on Azure - #61772

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:pr-and-master-builds
Jun 13, 2019
Merged

ci: Enable toolstate tracking on Azure#61772
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:pr-and-master-builds

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented Jun 12, 2019•
edited by emilyalbini
Loading

Copy link
Copy Markdown
Member

Currently just run it through its paces but don't actually push to
official locations. Instead let's just push to a separate fork (mine) as
well as open issues in a separate fork (mine). Make sure that people
aren't pinged for these issues as well!

This should hopefully ensure that everything is working on Azure and
give us a chance to work through any issues that come up.

Fixes#61790
Fixes#61371

@rust-highfive

rust-highfive commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2019
@alexcrichton

alexcrichton commented Jun 12, 2019

Copy link
Copy Markdown
MemberAuthor

r? @pietroalbini

So I think I've got everything hooked up right, but I've surely forgotten something. Hopefully it won't cause too many issues!

cc @kennytm as well

@alexcrichton
alexcrichtonforce-pushed the pr-and-master-builds branch 2 times, most recently from 7809ed4 to 48e37b3CompareJune 12, 2019 18:39
emilyalbini
emilyalbini requested changes Jun 12, 2019
View reviewed changes

@emilyalbiniemilyalbini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally prefer to configure the issues URL and the delinking with environment variables instead of ifs in the code: this way we can do the Travis -> Azure switch without having to land PRs on the repo. Feel free to bikeshed the variable names.

Comment thread.azure-pipelines/pr.yml Outdated
Comment threadsrc/tools/publish_toolstate.py Outdated
Comment threadsrc/tools/publish_toolstate.py Outdated
@emilyalbini

emilyalbini commented Jun 13, 2019

Copy link
Copy Markdown
Member

Oh, variables are also missing on the master pipeline:

variables:
- group: prod-credentials

@emilyalbiniemilyalbini added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2019
@emilyalbiniemilyalbini mentioned this pull request Jun 13, 2019
Closed
@alexcrichton

alexcrichton commented Jun 13, 2019

Copy link
Copy Markdown
MemberAuthor

I continue to not really understand how those variable groups work. I clicked "link" in the web UI but I don't think that was done for the auto branch, and I don't know what effect this yml configuration has over that...

In any case everything else should be addressed!

re-r? @pietroalbini

I'll open an issue after this lands.

@alexcrichton
ci: Enable toolstate tracking on Azure
521edee
Currently just run it through its paces but don't actually push to
official locations. Instead let's just push to a separate fork (mine) as
well as open issues in a separate fork (mine). Make sure that people
aren't pinged for these issues as well!
This should hopefully ensure that everything is working on Azure and
give us a chance to work through any issues that come up.
emilyalbini
emilyalbini approved these changes Jun 13, 2019
View reviewed changes

@emilyalbiniemilyalbini left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

I continue to not really understand how those variable groups work. I clicked "link" in the web UI but I don't think that was done for the auto branch, and I don't know what effect this yml configuration has over that...

The way I understand it is that to use a variable group in a pipeline you have to declare it in the YAML. If the variable group is marked as "available to all pipelines" in the UI then that's all, otherwise you also have to authorize it from the UI as a security measure.

@emilyalbini

emilyalbini commented Jun 13, 2019

Copy link
Copy Markdown
Member

@bors r+ p=1 rollup=never

@bors

bors commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 521edee has been approved by pietroalbini

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2019
@bors

bors commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 521edee with merge 0e4a56b...

bors added a commit that referenced this pull request Jun 13, 2019
@bors
Auto merge of#61772- alexcrichton:pr-and-master-builds, r=pietroalbini
0e4a56b
ci: Enable toolstate tracking on Azure
Currently just run it through its paces but don't actually push to
official locations. Instead let's just push to a separate fork (mine) as
well as open issues in a separate fork (mine). Make sure that people
aren't pinged for these issues as well!
This should hopefully ensure that everything is working on Azure and
give us a chance to work through any issues that come up.
Fixes#61790Fixes#61371
@bors

bors commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing 0e4a56b to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 13, 2019
@bors
bors merged commit 521edee into rust-lang:masterJun 13, 2019
@borsbors mentioned this pull request Jun 13, 2019
Closed
@alexcrichton
alexcrichton deleted the pr-and-master-builds branch June 14, 2019 14:16
@alexcrichton

alexcrichton commented Jun 14, 2019

Copy link
Copy Markdown
MemberAuthor

Looks like https://github.com/alexcrichton/rust-toolstate is receiving commits, but comments are failing on the master branch (https://dev.azure.com/rust-lang/rust/_build/results?buildId=716), will look into those now.

@alexcrichton

alexcrichton commented Jun 14, 2019

Copy link
Copy Markdown
MemberAuthor

Oh actually I think that that's an expected error. It's trying to create a comment on a PR in my repository, but that PR doesn't exist because it only exists in this repository.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilyalbiniemilyalbiniemilyalbini approved these changes

Assignees

@emilyalbiniemilyalbini

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

azure: sccache not found azure: setup master and pr builds

5 participants

@alexcrichton@rust-highfive@emilyalbini@bors@nikomatsakis