Uh oh!
There was an error while loading. Please reload this page.
Update rustfmt and rls - #61861
Conversation
rust-highfive
commented
Jun 15, 2019
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Jun 15, 2019
|
alexcrichton
commented
Jun 17, 2019
@bors: r+ p=1 delegate+ |
bors
commented
Jun 17, 2019
✌️ @topecongiro can now approve this pull request |
bors
commented
Jun 17, 2019
📌 Commit 112cf7c6d7d2eca43ea54ff6e6cba4e787f3e61e has been approved by |
bors
commented
Jun 17, 2019
⌛ Testing commit 112cf7c6d7d2eca43ea54ff6e6cba4e787f3e61e with merge b665e7b5343a66252557c6a2a94991e9e858b760... |
bors
commented
Jun 17, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Jun 17, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
topecongiro
commented
Jun 18, 2019
No idea where the error comes from or how to fix it... 🙄 |
bors
commented
Jun 18, 2019
☔ The latest upstream changes (presumably #61771) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-highfive
commented
Jun 18, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jun 18, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexcrichton
commented
Jun 18, 2019
I think the rebase is probably good enough for now to fix the original error, but it looks like new errors are showing up? |
Ok, rls has been in test-failing state since 673cf7d (https://rust-lang-nursery.github.io/rust-toolstate/). AFAICT from the log, if a PR is updating one of the submodule that is in test-failing state, then the PR needs to fix that to test-passing. cc @Xanewok EDIT: Now the test on linux is passing but is failing on Windows since 04a3dd8. |
topecongiro
commented
Jun 18, 2019
Is there any way to work around this for now? I just want to update |
topecongiro
commented
Jun 19, 2019
Looks like the test state of rls is fixed since 605ea9d so trying again. |
Xanewok
commented
Jun 19, 2019
@topecongiro please also update RLS to rust-lang/rls@4b13b10 - this ignores a Racer test that started causing spurious failures. |
Update rustfmt to 1.3.0.
topecongiro
commented
Jun 19, 2019
bors
commented
Jun 19, 2019
📌 Commit 5a411a6 has been approved by |
…ngiro Update rustfmt and rls This PR bumps the version of rustfmt to 1.3.0.
Centril
commented
Jun 19, 2019
Added to rollup in #61962. |
bors
commented
Jun 19, 2019
⌛ Testing commit 5a411a6 with merge 52a9c4a0741753e11656df6bfb4383dee4df84f0... |
Centril
commented
Jun 19, 2019
@bors retry |
bors
commented
Jun 19, 2019
Xanewok
commented
Jun 19, 2019
Now let's hope that the highfive spam about changed RLS toolstate will finally be over 😄 |
This PR bumps the version of rustfmt to 1.3.0.