Skip to content

improve pinning projection docs - #61878

Merged
bors merged 7 commits into
rust-lang:masterfrom
RalfJung:pin
Jun 28, 2019
Merged

improve pinning projection docs#61878
bors merged 7 commits into
rust-lang:masterfrom
RalfJung:pin

Conversation

@RalfJung

@RalfJungRalfJung commented Jun 15, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This tries to improve the explanation of structural pinning and pinning projections based on this URLO thread.

Fixes#61272.

@rust-highfive

rust-highfive commented Jun 15, 2019

Copy link
Copy Markdown
Contributor

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@RalfJung

RalfJung commented Jun 18, 2019

Copy link
Copy Markdown
MemberAuthor

Cc @Centril you usually have a bunch of feedback on these ;)

Centril
Centril reviewed Jun 18, 2019
View reviewed changes
Comment threadsrc/libcore/pin.rs Outdated
Comment threadsrc/libcore/pin.rs Outdated
Comment threadsrc/libcore/pin.rs Outdated
Comment threadsrc/libcore/pin.rs Outdated
Comment threadsrc/libcore/pin.rs Outdated
Comment threadsrc/libcore/pin.rs Outdated
@Centril

Centril commented Jun 18, 2019

Copy link
Copy Markdown
Contributor

@RalfJung Looks good aside from a few nits ^---

RalfJungand others added 2 commits June 19, 2019 15:02
@RalfJung@Centril
Apply suggestions from code review
f250951
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@RalfJung
nits
bf03a3c
@RalfJung

RalfJung commented Jun 22, 2019

Copy link
Copy Markdown
MemberAuthor

@rust-lang/libs this still awaits review.

@RalfJungRalfJung added T-libs-api [DEPRECATED; DO NOT USE] A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Jun 25, 2019
@RalfJung

RalfJung commented Jun 26, 2019

Copy link
Copy Markdown
MemberAuthor

@withoutboats could you maybe help review this?

@Dylan-DPC-zz

Dylan-DPC-zz commented Jun 26, 2019

Copy link
Copy Markdown

@bors: r=me

@Dylan-DPC-zz

Dylan-DPC-zz commented Jun 26, 2019

Copy link
Copy Markdown

@bors r+

@bors

bors commented Jun 26, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit bf03a3c has been approved by Dylan-DPC

@bors

bors commented Jun 26, 2019

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 999, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2019
@Centril

Centril commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
@Centril
Rollup merge ofrust-lang#61878- RalfJung:pin, r=Dylan-DPC
d5f36b8
improve pinning projection docs
This tries to improve the explanation of structural pinning and pinning projections based on [this URLO thread](https://users.rust-lang.org/t/when-is-it-safe-to-move-a-member-value-out-of-a-pinned-future/28182).
Fixesrust-lang#61272.
@CentrilCentril mentioned this pull request Jun 27, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
@Centril
Rollup merge ofrust-lang#61878- RalfJung:pin, r=Dylan-DPC
ed8cba1
improve pinning projection docs
This tries to improve the explanation of structural pinning and pinning projections based on [this URLO thread](https://users.rust-lang.org/t/when-is-it-safe-to-move-a-member-value-out-of-a-pinned-future/28182).
Fixesrust-lang#61272.
@CentrilCentril mentioned this pull request Jun 27, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
@Centril
Rollup merge ofrust-lang#61878- RalfJung:pin, r=Dylan-DPC
7ddfae7
improve pinning projection docs
This tries to improve the explanation of structural pinning and pinning projections based on [this URLO thread](https://users.rust-lang.org/t/when-is-it-safe-to-move-a-member-value-out-of-a-pinned-future/28182).
Fixesrust-lang#61272.
@CentrilCentril mentioned this pull request Jun 27, 2019
Merged
bors added a commit that referenced this pull request Jun 28, 2019
@bors
Auto merge of#62192- Centril:rollup-kssnlta, r=Centril
433a467
Rollup of 16 pull requests
Successful merges:
- #61878 (improve pinning projection docs)
- #62043 (Remove `FnBox`)
- #62067 (Add suggestion for missing `.await` keyword)
- #62076 (Updated RELEASES.md for 1.36.0)
- #62102 (call out explicitly that general read needs to be called with an initialized buffer)
- #62106 (Add more tests for async/await)
- #62124 (refactor lexer to use idiomatic borrowing)
- #62131 (libsyntax: Fix some Clippy warnings)
- #62152 (Don't ICE on item in `.await` expression)
- #62154 (Remove old fixme)
- #62155 (Add regression test for MIR drop generation in async loops)
- #62156 (Update books)
- #62160 (Remove outdated question_mark_macro_sep lint)
- #62164 (save-analysis: use buffered writes)
- #62171 (rustc: Retry SIGILL linker invocations)
- #62176 (Update RLS)
Failed merges:
r? @ghost
@bors
bors merged commit bf03a3c into rust-lang:masterJun 28, 2019
@RalfJung
RalfJung deleted the pin branch August 9, 2019 16:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@CentrilCentrilCentril left review comments
@Dylan-DPC-zzDylan-DPC-zzDylan-DPC-zz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TimNNTimNN

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve pin projection documentation

6 participants

@RalfJung@rust-highfive@Centril@Dylan-DPC-zz@bors@TimNN