Fix some sanity checks by golddranks · Pull Request #61890 · rust-lang/rust

golddranks · 2019-06-16T11:40:41Z

Update: Changes that made it not to work dropped.

Fix building_llvm in sanity check
- This was subtly broken: we build LLVM if any of the hosts builds LLVM, and not setting the config meant that LLVM is built for that target. Because of filtering away the targets not configured and the semantics of Iterator::any, it currently didn't set the building_llvm flag even if we indeed build it.
Add swig sanity check
- This checks whether there is a swig executable needed for LLDB.

rust-highfive · 2019-06-16T11:40:51Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Dylan-DPC-zz · 2019-07-08T12:21:57Z

ping from triage @nikomatsakis waiting for you to review this

nikomatsakis · 2019-07-12T11:07:45Z

This is really out of my wheel house. Reassigning to @Mark-Simulacrum, who may be a better choice, or perhaps knows who would be =)

r? @Mark-Simulacrum

Mark-Simulacrum · 2019-07-12T11:32:16Z

I think unfortunately I don't really have the time to help out with fixing the logic here, however, I think we may be able to move forward a little bit at least.

I think we can land the sanity checks (Swig, building_llvm) relatively easily --maybe either split that out into a new PR or drop the lldb_done_stamp changes from this one? I think since you can't get the lldb stamp working it's probably reasonable to just hold off on that for the time being.

golddranks · 2019-07-12T11:35:51Z

All right, I'll split this up.

golddranks · 2019-07-23T00:43:08Z

@Mark-Simulacrum I dropped the lldb_done_stamp changes, so it now only does the sanity checks.

Meanwhile, an update to LLVM 9.0 trunk was done: #62592
This means that the fixes that enable SWIG 4.0 ( https://reviews.llvm.org/D63530 ) are also included, so the version sanity check shouldn't decline SWIG 4.0 any more.

Mark-Simulacrum · 2019-07-23T16:36:06Z

r=me with the PR description updated to eliminate the strikeouts (we put it in the merge commit, so it's nice for it to be clean)

Dylan-DPC-zz · 2019-07-23T17:08:05Z

@bors r+

bors · 2019-07-23T17:08:07Z

📌 Commit f78cd4d has been approved by Dylan-DPC

…=Dylan-DPC Fix some sanity checks Update: Changes that made it not to work dropped. * Fix `building_llvm` in sanity check * This was subtly broken: we build LLVM if any of the hosts builds LLVM, and not setting the config meant that LLVM is built for that target. Because of filtering away the targets not configured and the semantics of `Iterator::any`, it currently didn't set the `building_llvm` flag even if we indeed build it. * Add `swig` sanity check * This checks whether there is a `swig` executable needed for LLDB.

@ghost

Rollup of 10 pull requests Successful merges: - rust-lang#60938 (rustdoc: make #[doc(include)] relative to the containing file) - rust-lang#61890 (Fix some sanity checks) - rust-lang#62261 (Take substs into account in `conservative_is_privately_uninhabited`) - rust-lang#62528 (Add joining slices of slices with a slice separator, not just a single item) - rust-lang#62735 (Turn `#[global_allocator]` into a regular attribute macro) - rust-lang#62801 (Remove support for -Zlower-128bit-ops) - rust-lang#62808 (Revert "Disable stack probing for gnux32.") - rust-lang#62819 (Display name of crate requiring rustc_private in error messages.) - rust-lang#62904 (Disable d32 on armv6 hf targets) - rust-lang#62907 (Initialize the MSP430 AsmParser) Failed merges: r? @ghost

…=Dylan-DPC Fix some sanity checks Update: Changes that made it not to work dropped. * Fix `building_llvm` in sanity check * This was subtly broken: we build LLVM if any of the hosts builds LLVM, and not setting the config meant that LLVM is built for that target. Because of filtering away the targets not configured and the semantics of `Iterator::any`, it currently didn't set the `building_llvm` flag even if we indeed build it. * Add `swig` sanity check * This checks whether there is a `swig` executable needed for LLDB.

@ghost

Rollup of 13 pull requests Successful merges: - rust-lang#60938 (rustdoc: make #[doc(include)] relative to the containing file) - rust-lang#61890 (Fix some sanity checks) - rust-lang#62084 (allow clippy::unreadable_literal in unicode tables) - rust-lang#62261 (Take substs into account in `conservative_is_privately_uninhabited`) - rust-lang#62528 (Add joining slices of slices with a slice separator, not just a single item) - rust-lang#62735 (Turn `#[global_allocator]` into a regular attribute macro) - rust-lang#62801 (Remove support for -Zlower-128bit-ops) - rust-lang#62808 (Revert "Disable stack probing for gnux32.") - rust-lang#62822 (Improve some pointer-related documentation) - rust-lang#62904 (Disable d32 on armv6 hf targets) - rust-lang#62907 (Initialize the MSP430 AsmParser) - rust-lang#62921 (Add method disambiguation help for trait implementation) - rust-lang#62942 (Use match ergonomics in Condvar documentation) Failed merges: r? @ghost

…=Dylan-DPC Fix some sanity checks Update: Changes that made it not to work dropped. * Fix `building_llvm` in sanity check * This was subtly broken: we build LLVM if any of the hosts builds LLVM, and not setting the config meant that LLVM is built for that target. Because of filtering away the targets not configured and the semantics of `Iterator::any`, it currently didn't set the `building_llvm` flag even if we indeed build it. * Add `swig` sanity check * This checks whether there is a `swig` executable needed for LLDB.

@ghost

Rollup of 15 pull requests Successful merges: - #60066 (Stabilize the type_name intrinsic in core::any) - #60938 (rustdoc: make #[doc(include)] relative to the containing file) - #61884 (Stablize Euclidean Modulo (feature euclidean_division)) - #61890 (Fix some sanity checks) - #62528 (Add joining slices of slices with a slice separator, not just a single item) - #62707 (Add tests for overlapping explicitly dropped locals in generators) - #62735 (Turn `#[global_allocator]` into a regular attribute macro) - #62822 (Improve some pointer-related documentation) - #62887 (Make the parser TokenStream more resilient after mismatched delimiter recovery) - #62921 (Add method disambiguation help for trait implementation) - #62930 (Add test for #51559) - #62942 (Use match ergonomics in Condvar documentation) - #62977 (Fix inconsistent highlight blocks.) - #62978 (Remove `cfg(bootstrap)` code for array implementations) - #62981 (Add note suggesting to borrow a String argument to find) Failed merges: - #62964 (clarify and unify some type test names) r? @ghost

crlf0710 · 2020-03-29T10:00:31Z

@rustbot modify labels to -S-inactive

Dylan-DPC-zz · 2020-03-29T10:02:41Z

@crlf0710 thanks for helping :)

rust-highfive assigned nikomatsakis Jun 16, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2019

Mark-Simulacrum added S-inactive and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2019

rust-highfive assigned Mark-Simulacrum and unassigned nikomatsakis Jul 12, 2019

golddranks force-pushed the fix_sanity_check_llvm branch from d0e68ef to 9e89f06Compare July 23, 2019 00:37

Fix building_llvm in sanity check, add swig sanity check.
f78cd4d

golddranks force-pushed the fix_sanity_check_llvm branch from 9e89f06 to f78cd4dCompare July 23, 2019 00:38

golddranks changed the title ~~WIP: Improve the build infra around LLDB~~ Fix some sanity checksJul 23, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 23, 2019

Centril mentioned this pull request Jul 23, 2019
Rollup of 13 pull requests #62920
Closed

Centril mentioned this pull request Jul 24, 2019
Rollup of 10 pull requests #62936
Closed

Centril mentioned this pull request Jul 24, 2019
Rollup of 13 pull requests #62960
Closed

Centril mentioned this pull request Jul 25, 2019
Rollup of 9 pull requests #62966
Closed

Centril mentioned this pull request Jul 25, 2019
Rollup of 15 pull requests #62990
Merged

bors merged commit f78cd4d into rust-lang:masterJul 26, 2019

rustbot removed the S-inactive label Mar 29, 2020

Navigation Menu

Uh oh!

Uh oh!

Fix some sanity checks - #61890

Fix some sanity checks#61890
bors merged 1 commit into
rust-lang:masterfrom
golddranks:fix_sanity_check_llvm

golddranks commented Jun 16, 2019•
edited by Dylan-DPC-zz
Loading

Uh oh!

rust-highfive commented Jun 16, 2019

Uh oh!

Dylan-DPC-zz commented Jul 8, 2019

Uh oh!

nikomatsakis commented Jul 12, 2019

Uh oh!

Mark-Simulacrum commented Jul 12, 2019

Uh oh!

golddranks commented Jul 12, 2019

Uh oh!

golddranks commented Jul 23, 2019

Uh oh!

Mark-Simulacrum commented Jul 23, 2019

Uh oh!

Dylan-DPC-zz commented Jul 23, 2019

Uh oh!

bors commented Jul 23, 2019

Uh oh!

crlf0710 commented Mar 29, 2020

Uh oh!

Dylan-DPC-zz commented Mar 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

golddranks commented Jun 16, 2019• edited by Dylan-DPC-zz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 16, 2019

Uh oh!

Dylan-DPC-zz commented Jul 8, 2019

Uh oh!

nikomatsakis commented Jul 12, 2019

Uh oh!

Mark-Simulacrum commented Jul 12, 2019

Uh oh!

golddranks commented Jul 12, 2019

Uh oh!

golddranks commented Jul 23, 2019

Uh oh!

Mark-Simulacrum commented Jul 23, 2019

Uh oh!

Dylan-DPC-zz commented Jul 23, 2019

Uh oh!

bors commented Jul 23, 2019

Uh oh!

crlf0710 commented Mar 29, 2020

Uh oh!

Dylan-DPC-zz commented Mar 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

golddranks commented Jun 16, 2019•
edited by Dylan-DPC-zz
Loading