Skip to content

submodules: Update clippy from 5a11ed7b to c5d1ecd4 - #62052

Closed
tesuji wants to merge 1 commit into
rust-lang:masterfrom
tesuji:clippy-update
Closed

submodules: Update clippy from 5a11ed7b to c5d1ecd4#62052
tesuji wants to merge 1 commit into
rust-lang:masterfrom
tesuji:clippy-update

Conversation

@tesuji

@tesujitesuji commented Jun 22, 2019

Copy link
Copy Markdown
Contributor

Changes:

% git shortlog --no-merges 5a11ed7b92cc4cf40a4568a8fc1ff54b198c333b..Daniele D'Orazio (4): make needless_return work with void functions update tests and fix lints in clippy more idiomatic code cargo fmtJeremy Stucki (1): Remove needless lifetimesLzu Tao (1): Fix fallout cause NodeId pruningMatthias Krüger (1): readme: updateflip1995 (1): Remove another unnecessary lifetime

r? @oli-obk

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2019
@tesuji

Copy link
Copy Markdown
ContributorAuthor

Looks like Oliver is busy, r? @Centril

@rust-highfiverust-highfive assigned Centril and unassigned oli-obkJun 22, 2019
@Centril

Copy link
Copy Markdown
Contributor

r? @Manishearth

@tesuji

Copy link
Copy Markdown
ContributorAuthor

Ping @oli-obk for a rollup.

@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+ p=1

@bors

bors commented Jun 23, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit fb0b43c has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 23, 2019
submodules: Update clippy from 5a11ed7 to c5d1ecd
Changes:
```console
% git shortlog --no-merges 5a11ed7..
Daniele D'Orazio (4):
make needless_return work with void functions
update tests and fix lints in clippy
more idiomatic code
cargo fmt
Jeremy Stucki (1):
Remove needless lifetimes
Lzu Tao (1):
Fix fallout cause NodeId pruning
Matthias Krüger (1):
readme: update
flip1995 (1):
Remove another unnecessary lifetime
```
r? @oli-obk
@CentrilCentril mentioned this pull request Jun 23, 2019
bors added a commit that referenced this pull request Jun 23, 2019
Rollup of 5 pull requests
Successful merges:
- #61778 (compiletest: Introduce `// {check,build,run}-pass` pass modes)
- #62037 (Speed up tidy)
- #62052 (submodules: Update clippy from 5a11ed7 to c5d1ecd)
- #62070 (Run rustfmt on some libsyntax files)
- #62075 (Remove `ast::Guard`)
Failed merges:
r? @ghost
@bors

bors commented Jun 23, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fb0b43c with merge ffd8464c402744e03e39ab30b303027c6a535a19...

@tesuji

Copy link
Copy Markdown
ContributorAuthor

Closing because the build failed after Let chain PR #60861 .

@tesujitesuji closed this Jun 23, 2019
@tesuji
tesuji deleted the clippy-update branch June 23, 2019 17:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tesuji@rust-highfive@Centril@oli-obk@bors@Manishearth