Skip to content

Implement From<Local> for Place and PlaceBase - #62096

Merged
bors merged 1 commit into
rust-lang:masterfrom
spastorino:impl-place-from
Jun 25, 2019
Merged

Implement From<Local> for Place and PlaceBase#62096
bors merged 1 commit into
rust-lang:masterfrom
spastorino:impl-place-from

Conversation

@spastorino

@spastorinospastorino commented Jun 24, 2019

Copy link
Copy Markdown
Member

r? @oli-obk
More tiny bits of Place 2.0 moved into master

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2019
Centril
Centril reviewed Jun 24, 2019
View reviewed changes
Comment threadsrc/librustc/mir/mod.rs Outdated
Comment threadsrc/librustc/mir/mod.rs Outdated
Comment threadsrc/librustc/mir/mod.rs Outdated
Comment threadsrc/librustc/mir/mod.rs Outdated
oli-obk
oli-obk reviewed Jun 24, 2019
View reviewed changes

@oli-obkoli-obk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+

@oli-obk

oli-obk commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 24, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1b8d41222b61cab08cb83c0f85a117b56c256e92 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2019
@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2019
@Centril

Centril commented Jun 25, 2019

Copy link
Copy Markdown
Contributor

@bors r=oli-obk,Centril

@bors

bors commented Jun 25, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 099f9e4 has been approved by oli-obk,Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 25, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 25, 2019
@Centril
Rollup merge ofrust-lang#62096- spastorino:impl-place-from, r=oli-o…
d406d89
…bk,Centril
Implement From<Local> for Place and PlaceBase
r? @oli-obk
More tiny bits of Place 2.0 moved into master
@CentrilCentril mentioned this pull request Jun 25, 2019
Merged
bors added a commit that referenced this pull request Jun 25, 2019
@bors
Auto merge of#62119- Centril:rollup-el20wu0, r=Centril
5f9c044
Rollup of 7 pull requests
Successful merges:
- #61814 (Fix an ICE with uninhabited consts)
- #61987 (rustc: produce AST instead of HIR from `hir::lowering::Resolver` methods.)
- #62055 (Fix error counting)
- #62078 (Remove built-in derive macros `Send` and `Sync`)
- #62085 (Add test for issue-38591)
- #62091 (HirIdification: almost there)
- #62096 (Implement From<Local> for Place and PlaceBase)
Failed merges:
r? @ghost
@bors
bors merged commit 099f9e4 into rust-lang:masterJun 25, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk left review comments
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spastorino@oli-obk@bors@Centril@rust-highfive