Feature gate `rustc` attributes harder by petrochenkov · Pull Request #62133 · rust-lang/rust

petrochenkov · 2019-06-25T22:18:28Z

Fixes#62116

rust-highfive · 2019-06-25T22:18:32Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2019-06-25T22:18:42Z

@craterbot run mode=check-only

craterbot · 2019-06-25T22:18:43Z

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2019-06-25T22:19:07Z

Damn.
@bors try

bors · 2019-06-25T22:19:18Z

⌛ Trying commit 7fbb936 with merge 8ec8125...

Feature gate `rustc` attributes harder cc #62116

bors · 2019-06-26T01:13:36Z

☀️ Try build successful - checks-travis
Build commit: 8ec8125

petrochenkov · 2019-06-26T07:49:09Z

@craterbot run mode=check-only

craterbot · 2019-06-26T07:49:11Z

👌 Experiment pr-62133 created and queued.
🤖 Automatically detected try build 8ec8125
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-06-26T07:49:12Z

🚧 Experiment pr-62133 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-06-29T20:40:07Z

🎉 Experiment pr-62133 is completed!
📊 1 regressed and 0 fixed (66894 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2019-06-29T23:09:12Z

The single regression is #[rustc::attr(...)] in tests in remain, and #[rustc::foo] attributes are certainly something we want to reserve.

Ok, I think I'll apply a0d792c to this PR (requires rustc to register its own attributes instead of using feature(custom_attribute)-style fallback from unresolved), and it's good to go.

…gistered

petrochenkov · 2019-06-30T10:58:44Z

Updated.

petrochenkov · 2019-07-01T12:47:25Z

r? @eddyb

Feature gate `rustc` attributes harder Fixesrust-lang#62116

@ghost

Rollup of 13 pull requests Successful merges: - #61545 (Implement another internal lints) - #62110 (Improve -Ztime-passes) - #62133 (Feature gate `rustc` attributes harder) - #62158 (Add MemoryExtra in InterpretCx constructor params) - #62168 (The (almost) culmination of HirIdification) - #62193 (Create async version of the dynamic-drop test) - #62369 (Remove `compile-pass` from compiletest) - #62380 (rustc_target: avoid negative register counts in the SysV x86_64 ABI.) - #62381 (Fix a typo in Write::write_vectored docs) - #62390 (Update README.md) - #62396 (remove Scalar::is_null_ptr) - #62406 (Lint on invalid values passed to x.py --warnings) - #62414 (Remove last use of mem::uninitialized in SGX) Failed merges: r? @ghost

rust-highfive assigned cramertj Jun 25, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2019

bors added a commit that referenced this pull request Jun 25, 2019
Auto merge of#62133- petrochenkov:norustc, r=<try>
8ec8125
Feature gate `rustc` attributes harder cc #62116

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2019

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 29, 2019

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2019

petrochenkov added 2 commits June 30, 2019 12:47

Make sure #[rustc_doc_only_macro] and other rustc attributes are re…
0ffb643
…gistered

Feature gate rustc attributes harder
e4e7eb2

petrochenkov force-pushed the norustc branch from 7fbb936 to e4e7eb2Compare June 30, 2019 10:58

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2019

petrochenkov mentioned this pull request Jul 1, 2019
Improve documentation for built-in macros #62243
Merged

rust-highfive assigned eddyb and unassigned cramertj Jul 1, 2019

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2019
Rollup merge ofrust-lang#62133- petrochenkov:norustc, r=eddyb
62b38c1
Feature gate `rustc` attributes harder Fixesrust-lang#62116

Manishearth mentioned this pull request Jul 2, 2019
Rollup of 16 pull requests #62294
Closed

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 3, 2019
Rollup merge ofrust-lang#62133- petrochenkov:norustc, r=eddyb
351442b
Feature gate `rustc` attributes harder Fixesrust-lang#62116

Mark-Simulacrum mentioned this pull request Jul 3, 2019
Rollup of 20 pull requests #62333
Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 4, 2019
Rollup merge ofrust-lang#62133- petrochenkov:norustc, r=eddyb
0668f38
Feature gate `rustc` attributes harder Fixesrust-lang#62116

Centril mentioned this pull request Jul 4, 2019
Rollup of 7 pull requests #62363
Closed

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2019
Rollup merge ofrust-lang#62133- petrochenkov:norustc, r=eddyb
b5246fd
Feature gate `rustc` attributes harder Fixesrust-lang#62116

Mark-Simulacrum mentioned this pull request Jul 4, 2019
Rollup of 8 pull requests #62372
Closed

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2019
Rollup merge ofrust-lang#62133- petrochenkov:norustc, r=eddyb
2a374b0
Feature gate `rustc` attributes harder Fixesrust-lang#62116

Mark-Simulacrum mentioned this pull request Jul 4, 2019
Rollup of 10 pull requests #62378
Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
Rollup merge ofrust-lang#62133- petrochenkov:norustc, r=eddyb
de03018
Feature gate `rustc` attributes harder Fixesrust-lang#62116

Centril mentioned this pull request Jul 5, 2019
Rollup of 14 pull requests #62413
Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
Rollup merge ofrust-lang#62133- petrochenkov:norustc, r=eddyb
51454fd
Feature gate `rustc` attributes harder Fixesrust-lang#62116

Centril mentioned this pull request Jul 5, 2019
Rollup of 14 pull requests #62418
Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
Rollup merge ofrust-lang#62133- petrochenkov:norustc, r=eddyb
0224532
Feature gate `rustc` attributes harder Fixesrust-lang#62116

Centril mentioned this pull request Jul 5, 2019
Rollup of 13 pull requests #62419
Merged

bors merged commit e4e7eb2 into rust-lang:masterJul 5, 2019

dtolnay mentioned this pull request Jul 7, 2019
No longer compiles dtolnay/rustversion#6
Closed

petrochenkov mentioned this pull request Jul 8, 2019
Tracking issue for custom inner attributes #54726
Open

petrochenkov deleted the norustc branch July 8, 2019 13:33

This was referenced Aug 24, 2019
Crater runs for Rust 1.38.0 #63628
Closed
[1.38] Regression: attributes starting with rustc are reserved for use by the rustc compiler #63887
Closed

Uh oh!

Uh oh!

Conversation

petrochenkov commented Jun 25, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 25, 2019

Uh oh!

petrochenkov commented Jun 25, 2019

Uh oh!

craterbot commented Jun 25, 2019

Uh oh!

petrochenkov commented Jun 25, 2019

Uh oh!

bors commented Jun 25, 2019

Uh oh!

bors commented Jun 26, 2019

Uh oh!

petrochenkov commented Jun 26, 2019

Uh oh!

craterbot commented Jun 26, 2019

Uh oh!

craterbot commented Jun 26, 2019

Uh oh!

craterbot commented Jun 29, 2019

Uh oh!

petrochenkov commented Jun 29, 2019

Uh oh!

petrochenkov commented Jun 30, 2019

Uh oh!

petrochenkov commented Jul 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

petrochenkov commented Jun 25, 2019•
edited
Loading