Skip to content

ci: Disable assertions in PR builds - #62141

Merged
alexcrichton merged 1 commit into
rust-lang:masterfrom
alexcrichton:less-assertions
Jun 27, 2019
Merged

ci: Disable assertions in PR builds#62141
alexcrichton merged 1 commit into
rust-lang:masterfrom
alexcrichton:less-assertions

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

The PR builder on Azure currently takes 2.5h which is a bit long, so
this commit disables debug assertions and llvm assertions in an attempt
to speed up that builder and have PR builds come back a bit more
quickly. Other builders continue to enable debug assertions and test the
compiler there.

The PR builder on Azure currently takes 2.5h which is a bit long, so
this commit disables debug assertions and llvm assertions in an attempt
to speed up that builder and have PR builds come back a bit more
quickly. Other builders continue to enable debug assertions and test the
compiler there.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2019
@emilyalbini

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 26, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 07efcf2 has been approved by pietroalbini

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 26, 2019
…troalbini
ci: Disable assertions in PR builds
The PR builder on Azure currently takes 2.5h which is a bit long, so
this commit disables debug assertions and llvm assertions in an attempt
to speed up that builder and have PR builds come back a bit more
quickly. Other builders continue to enable debug assertions and test the
compiler there.
bors added a commit that referenced this pull request Jun 26, 2019
[CI] Rollup of 5 pull requests
Successful merges:
- #62140 (ci: Turn off PR builds on Travis)
- #62141 (ci: Disable assertions in PR builds)
- #62142 (ci: Switch official `try` builds to happen on Azure)
- #62143 (ci: Publish toolstate changes from Azure)
- #62145 (ci: Sync AppVeyor/Travis with Azure configuration)
Failed merges:
r? @ghost
bors added a commit that referenced this pull request Jun 27, 2019
[CI] Rollup of 5 pull requests
Successful merges:
- #62140 (ci: Turn off PR builds on Travis)
- #62141 (ci: Disable assertions in PR builds)
- #62142 (ci: Switch official `try` builds to happen on Azure)
- #62143 (ci: Publish toolstate changes from Azure)
- #62145 (ci: Sync AppVeyor/Travis with Azure configuration)
Failed merges:
r? @ghost
@alexcrichton
alexcrichton merged commit 07efcf2 into rust-lang:masterJun 27, 2019
@alexcrichton
alexcrichton deleted the less-assertions branch July 8, 2019 20:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@alexcrichton@rust-highfive@emilyalbini@bors@kennytm