Skip to content

Add Vec::leak - #62196

Merged
bors merged 1 commit into
rust-lang:masterfrom
cramertj:vec-leak
Jul 3, 2019
Merged

Add Vec::leak#62196
bors merged 1 commit into
rust-lang:masterfrom
cramertj:vec-leak

Conversation

@cramertj

@cramertjcramertj commented Jun 27, 2019

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

rust-highfive commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2019
jonas-schievink
jonas-schievink reviewed Jun 27, 2019
View reviewed changes
Comment threadsrc/liballoc/vec.rs Outdated
@jonas-schievinkjonas-schievink added the T-libs-api [DEPRECATED; DO NOT USE] label Jun 27, 2019
@jonas-schievinkjonas-schievink mentioned this pull request Jun 27, 2019
Closed
@withoutboats

withoutboats commented Jun 27, 2019

Copy link
Copy Markdown
Contributor

@bors r+

Seems reasonable at least on nightly, its annoying to write by hand.

@bors

bors commented Jun 27, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 206a384ef058c61f4f9818849fe7a2ed1ef43ff5 has been approved by withoutboats

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2019
@matklad

matklad commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

Am I missing something, or is this just Box::leak(vec.into_boxed_slice())?

@Centril

Centril commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

@bors r-

This can be written without the unsafe as per @matklad's comment (even Box::leak(vec.into()) will suffice) and so we should do that in the implementation to reduce the overall trusted computing base.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 28, 2019
@cramertj

cramertj commented Jun 28, 2019

Copy link
Copy Markdown
MemberAuthor

This can be written without the unsafe

Done, thanks for the suggestion.

@Centril

Centril commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

Thanks!

@bors r=withoutboats,Centril rollup

@bors

bors commented Jun 28, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 86d96e33550f8027f80a4ba299c1e97cbd6e0505 has been approved by withoutboats,Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2019
@cramertj

cramertj commented Jun 28, 2019

Copy link
Copy Markdown
MemberAuthor

@bors r=withoutboats,Centril rollup

@bors

bors commented Jun 28, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit bd10be5 has been approved by withoutboats,Centril

Centril added a commit to Centril/rust that referenced this pull request Jun 28, 2019
@Centril
Rollup merge ofrust-lang#62196- cramertj:vec-leak, r=withoutboats,C…
eb3f7e2
…entril
Add Vec::leak
@CentrilCentril mentioned this pull request Jun 28, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jun 28, 2019
@Centril
Rollup merge ofrust-lang#62196- cramertj:vec-leak, r=withoutboats,C…
a9365c7
…entril
Add Vec::leak
@CentrilCentril mentioned this pull request Jun 28, 2019
Closed
Centril
Centril reviewed Jun 28, 2019
View reviewed changes
Comment threadsrc/liballoc/vec.rs
@Centril

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 28, 2019
czipperz
czipperz reviewed Jun 29, 2019
View reviewed changes
Comment threadsrc/liballoc/vec.rs
@cramertj

cramertj commented Jul 1, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@bors r=centril,withoutboats

@bors

bors commented Jul 1, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9527565 has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2019
@bors

bors commented Jul 1, 2019

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Jul 1, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9527565 has been approved by centril,withoutboats

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2019
@Manishearth
Rollup merge ofrust-lang#62196- cramertj:vec-leak, r=centril,withou…
91376ec
…tboats
Add Vec::leak
@ManishearthManishearth mentioned this pull request Jul 2, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 3, 2019
@Mark-Simulacrum
Rollup merge ofrust-lang#62196- cramertj:vec-leak, r=centril,withou…
c973d65
…tboats
Add Vec::leak
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jul 3, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 3, 2019
@Mark-Simulacrum
Rollup merge ofrust-lang#62196- cramertj:vec-leak, r=centril,withou…
aa7999a
…tboats
Add Vec::leak
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jul 3, 2019
Merged
bors added a commit that referenced this pull request Jul 3, 2019
@bors
Auto merge of#62335- Mark-Simulacrum:rollup-0pcaz5a, r=Mark-Simulacrum
088b987
Rollup of 15 pull requests
Successful merges:
- #62021 (MSVC link output improve)
- #62064 (nth_back for chunks_exact)
- #62128 (Adjust warning of -C extra-filename with -o.)
- #62161 (Add missing links for TryFrom docs)
- #62183 (std: Move a process test out of libstd)
- #62186 (Add missing type urls in Into trait)
- #62196 (Add Vec::leak)
- #62199 (import gdb for explicit access to gdb.current_objfile())
- #62229 (Enable intptrcast for explicit casts)
- #62250 (Improve box clone doctests to ensure the documentation is valid)
- #62255 (Switch tracking issue for `#![feature(slice_patterns)]`)
- #62285 (Fix michaelwoerister's mailmap)
- #62304 (HashMap is UnwindSafe)
- #62319 (Fix mismatching Kleene operators)
- #62327 (Fixed document bug, those replaced each other)
Failed merges:
r? @ghost
@bors
bors merged commit 9527565 into rust-lang:masterJul 3, 2019
@cramertj
cramertj deleted the vec-leak branch July 3, 2019 18:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@CentrilCentrilCentril left review comments
@jonas-schievinkjonas-schievinkjonas-schievink left review comments
@LucretielLucretielLucretiel left review comments
@czipperzczipperzczipperz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@withoutboatswithoutboats

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cramertj@rust-highfive@withoutboats@bors@matklad@Centril@jonas-schievink@Lucretiel@czipperz