Skip to content

Add Symbolic variant to Operand - #62197

Closed
pvdrz wants to merge 1 commit into
rust-lang:masterfrom
pvdrz:symbolic-execution
Closed

Add Symbolic variant to Operand#62197
pvdrz wants to merge 1 commit into
rust-lang:masterfrom
pvdrz:symbolic-execution

Conversation

@pvdrz

@pvdrzpvdrz commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2019
@RalfJung

RalfJung commented Jun 29, 2019

Copy link
Copy Markdown
Member

This seems reasonable but not very useful on its own?

If you add the associated type to the Machine, you at least have a place to also put some docs about the purpose of this. It'll also become a much bigger patch though. Better do it after Tuesday (that's when Miri is allowed to break again), and after #62173 lands.

Still, I am not sure about landing something that is entirely useless on its own.

@Mark-SimulacrumMark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2019
@joelpalmer

joelpalmer commented Jul 22, 2019

Copy link
Copy Markdown

Ping from Triage: @oli-obk are there any updates on this PR?

@Dylan-DPC-zz

Dylan-DPC-zz commented Jul 22, 2019

Copy link
Copy Markdown

r? @RalfJung

@christianpoveda any updates on this ?

@RalfJung

RalfJung commented Jul 22, 2019•
edited
Loading

Copy link
Copy Markdown
Member

I think Oli is the better reviewer for this, they made some plans on Zulip with @christianpoveda, so I am going to assign them again.

r? @oli-obk

@JohnTitor

JohnTitor commented Jul 28, 2019

Copy link
Copy Markdown
Member

Ping from triage: any updates? @christianpoveda @oli-obk

@pvdrz

pvdrz commented Jul 29, 2019

Copy link
Copy Markdown
ContributorAuthor

I believe I am closing this for now. This is not a priority and we can always come back to it later

@pvdrzpvdrz closed this Jul 29, 2019
@pvdrz
pvdrz deleted the symbolic-execution branch July 29, 2019 14:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pvdrz@RalfJung@joelpalmer@Dylan-DPC-zz@JohnTitor@oli-obk@Mark-Simulacrum@rust-highfive