Uh oh!
There was an error while loading. Please reload this page.
Use mem::take instead of mem::replace with default - #62249
Merged
bors merged 5 commits intoJul 4, 2019
Conversation
rust-highfive
commented
Jun 30, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Jun 30, 2019
Member
cc #61129 r? @SimonSapin |
dtolnay
commented
Jun 30, 2019
Member
@bors r+ |
bors
commented
Jun 30, 2019
Collaborator
📌 Commit 9a5241551954c0f12e3d0a7bf62b60909479548a has been approved by |
Centril
commented
Jun 30, 2019
Contributor
@dtolnay Ha! I should have been faster! =) |
czipperz
commented
Jun 30, 2019
Uh oh!
There was an error while loading. Please reload this page.
Centril
commented
Jun 30, 2019
Contributor
@bors r=dtolnay,Centril |
bors
commented
Jun 30, 2019
Collaborator
📌 Commit ac21b601f577074321217a2d064edb22b2843f2b has been approved by |
Centril
commented
Jun 30, 2019
Contributor
@bors r- Seems you have some build failures in rustdoc. |
bors
commented
Jul 1, 2019
Collaborator
☔ The latest upstream changes (presumably #61682) made this pull request unmergeable. Please resolve the merge conflicts. |
czipperzforce-pushed
the
use-mem-take-instead-of-replace-default
branch
from
July 2, 2019 03:30
79e832b to
eddfad3Compareczipperz
commented
Jul 2, 2019
ContributorAuthor
(rebased to fix merge errors) |
Centril
commented
Jul 2, 2019
Contributor
@bors r=dtolnay,Centril |
bors
commented
Jul 2, 2019
Collaborator
📌 Commit eddfad3 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
…place-default, r=dtolnay,Centril Use mem::take instead of mem::replace with default
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
…place-default, r=dtolnay,Centril Use mem::take instead of mem::replace with default
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
…place-default, r=dtolnay,Centril Use mem::take instead of mem::replace with default
bors added a commit
that referenced
this pull request
Jul 3, 2019
Rollup of 17 pull requests Successful merges: - #62039 (Remove needless lifetimes (rustc)) - #62153 (Update the `rust-installer` submodule) - #62173 (rename InterpretCx -> InterpCx) - #62240 (wfcheck: resolve the type-vars in `AdtField` types) - #62249 (Use mem::take instead of mem::replace with default) - #62252 (Update mem::replace example to not be identical to mem::take) - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser) - #62268 (Clean up inherent_impls) - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind) - #62295 (miri realloc: do not require giving old size+align) - #62297 (refactor check_for_substitution) - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.) - #62317 (Migrate `compile-pass` annotations to `build-pass`) - #62337 (Fix bucket in CPU usage script) - #62344 (simplify Option::get_or_insert) - #62346 (enable a few more tests in Miri and update the comment for others) - #62351 (remove bogus example from drop_in_place) Failed merges: r? @ghost
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 3, 2019
…place-default, r=dtolnay,Centril Use mem::take instead of mem::replace with default
bors added a commit
that referenced
this pull request
Jul 3, 2019
Rollup of 16 pull requests Successful merges: - #62039 (Remove needless lifetimes (rustc)) - #62173 (rename InterpretCx -> InterpCx) - #62240 (wfcheck: resolve the type-vars in `AdtField` types) - #62249 (Use mem::take instead of mem::replace with default) - #62252 (Update mem::replace example to not be identical to mem::take) - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser) - #62268 (Clean up inherent_impls) - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind) - #62295 (miri realloc: do not require giving old size+align) - #62297 (refactor check_for_substitution) - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.) - #62317 (Migrate `compile-pass` annotations to `build-pass`) - #62337 (Fix bucket in CPU usage script) - #62344 (simplify Option::get_or_insert) - #62346 (enable a few more tests in Miri and update the comment for others) - #62351 (remove bogus example from drop_in_place) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.