Skip to content

Regression test for HRTB bug (issue 30786). - #62519

Merged
bors merged 1 commit into
rust-lang:masterfrom
pnkfelix:add-test-for-30786
Jul 11, 2019
Merged

Regression test for HRTB bug (issue 30786).#62519
bors merged 1 commit into
rust-lang:masterfrom
pnkfelix:add-test-for-30786

Conversation

@pnkfelix

Copy link
Copy Markdown
Contributor

Close#30786.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2019
@pnkfelix
pnkfelixforce-pushed the add-test-for-30786 branch from 959a2e2 to a08a5ccCompareJuly 9, 2019 09:39
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jul 9, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit a08a5cc has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 9, 2019
…crichton
Regression test for HRTB bug (issue 30786).
Closerust-lang#30786.
@CentrilCentril mentioned this pull request Jul 9, 2019
@Centril

Copy link
Copy Markdown
Contributor

Failed in #62538 (comment), @bors r-

You need to --bless --compare-mode=nll.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2019
@pnkfelix
pnkfelixforce-pushed the add-test-for-30786 branch from a08a5cc to fa0809dCompareJuly 10, 2019 14:43
@pnkfelix

Copy link
Copy Markdown
ContributorAuthor

@bors r+ rollup

@bors

bors commented Jul 10, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit fa0809d has been approved by pnkfelix

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 11, 2019
@CentrilCentril mentioned this pull request Jul 11, 2019
bors added a commit that referenced this pull request Jul 11, 2019
Rollup of 7 pull requests
Successful merges:
- #61665 (core: check for pointer equality when comparing Eq slices)
- #61923 (Prerequisites from dep graph refactoring #2)
- #62270 (Move async-await tests from run-pass to ui)
- #62425 (filedesc: don't use ioctl(FIOCLEX) on Linux)
- #62476 (Continue refactoring macro expansion and resolution)
- #62519 (Regression test for HRTB bug (issue 30786).)
- #62557 (Fix typo in libcore/intrinsics.rs)
Failed merges:
r? @ghost
@bors
bors merged commit fa0809d into rust-lang:masterJul 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HRTB bug in streaming iterator

5 participants

@pnkfelix@rust-highfive@alexcrichton@bors@Centril