Uh oh!
There was an error while loading. Please reload this page.
Improve lifetimes on foldl/foldr and lift the Copy requirement - #6254
Closed
alexcrichton wants to merge 1 commit into
Closed
Improve lifetimes on foldl/foldr and lift the Copy requirement#6254alexcrichton wants to merge 1 commit into
alexcrichton wants to merge 1 commit into
Conversation
alexcrichton
commented
May 7, 2013
MemberAuthor
Hmm... I'm not sure that this is caused by this commit, could this retry going through bors again? Apparently I can't trigger the retry... |
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
10384: Add vscode native onEnterRules r=matklad,lnicola a=HKalbasi This PR copy onEnterRules configurations [from vscode-rust](https://github.com/rust-lang/vscode-rust/blob/master/src/extension.ts#L287) based on discussion in rust-lang#6254 I understand that the ideal way is to use parser data for this, and probably all other things that language-config do. But since it can't be enabled (or at least it isn't enabled) by default in vscode, I think this is needed (until onEnter becomes official LSP and get vscode support). People can still configure shortcut and use the parser based onEnter, so it wouldn't harm anyone. Co-authored-by: hamidreza kalbasi <hamidrezakalbasi@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#5311 and #4490.
This doesn't change
vec.foldlbecause that's still part ofold_iter, although I could change that as well if necessary.