Skip to content

async unsafe fn tests - #62608

Merged
bors merged 7 commits into
rust-lang:masterfrom
delan:async-unsafe-fn-tests
Jul 13, 2019
Merged

async unsafe fn tests#62608
bors merged 7 commits into
rust-lang:masterfrom
delan:async-unsafe-fn-tests

Conversation

@delan

@delandelan commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Centril (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2019
Centril
Centril reviewed Jul 12, 2019
View reviewed changes
Comment threadsrc/test/ui/async-await/async-await.rs Outdated
Comment threadsrc/test/ui/async-await/async-unsafe-fn-call-in-safe.rs
Comment threadsrc/test/ui/async-await/async-unsafe-fn-call-in-safe.rs Outdated
@delan
delanforce-pushed the async-unsafe-fn-tests branch from 66381ef to 5f8d0a1CompareJuly 12, 2019 05:12
@Centril

Centril commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

Thanks! @bors r+ rollup

@bors

bors commented Jul 12, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 5f8d0a1 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 12, 2019
@Centril
Rollup merge ofrust-lang#62608- delan:async-unsafe-fn-tests, r=Centril
b1d6163
`async unsafe fn` tests
- cc rust-lang#62121
r? @Centril
@CentrilCentril mentioned this pull request Jul 12, 2019
Merged
bors added a commit that referenced this pull request Jul 12, 2019
@bors
Auto merge of#62635- Centril:rollup-potvfnk, r=Centril
e13fe7f
Rollup of 12 pull requests
Successful merges:
- #61535 (Coherence test when a generic type param has a default value from an associated type)
- #62274 (rustc_mir: follow FalseUnwind's real_target edge in qualify_consts.)
- #62431 (Add messages to `Option`'s and `Result`'s `must_use` annotation for `is_*`)
- #62453 (in which we suggest anonymizing single-use lifetimes in paths )
- #62568 (Replace unsafe_destructor_blind_to_params with may_dangle)
- #62578 (Add test for #49919)
- #62595 (Document that the crate keyword refers to the project root)
- #62599 (move mem::uninitialized deprecation back by 1 release, to 1.39)
- #62605 (Emit dropped unemitted errors to aid in ICE debugging)
- #62607 (Correctly break out of recovery loop)
- #62608 (`async unsafe fn` tests)
- #62623 (downgrade indirect_structural_match lint to allow)
Failed merges:
r? @ghost
@bors
bors merged commit 5f8d0a1 into rust-lang:masterJul 13, 2019
@delan
delan deleted the async-unsafe-fn-tests branch July 13, 2019 05:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@delan@rust-highfive@Centril@bors