Uh oh!
There was an error while loading. Please reload this page.
[WIP] fix libunwind - #62622
Conversation
rust-highfive
commented
Jul 12, 2019
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
commented
Jul 12, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Uh oh!
There was an error while loading. Please reload this page.
alexcrichton
commented
Jul 12, 2019
Thanks for the PR! This PR is unfortunately pretty light on the details. Neither the PR title nor description really gives any insight into what the compilation error looks like today, what this change is, and why the change fixes it. Could you expand the descriptions and/or give more detail about the issues you're encountering? |
Any breaking changes is not what I want it all.
|
aleksmelnikov
commented
Jul 12, 2019
fix compilation panic=abort for target i686-pc-windows-gnu on linux Update libunwind.rs Update libunwind.rs Update libunwind.rs
retep998
commented
Jul 12, 2019
Rust currently ships |
aleksmelnikov
commented
Jul 14, 2019
|
alexcrichton
commented
Jul 15, 2019
Ok thanks for expanding the description! As you've discovered I don't think this is fixable without rustc changes itself. Even with xargo the compiler needs to configure LLVM and may need to change its codegen for sjlj exceptions. Do you want to leave this open in the meantime or shall we close this? |
aleksmelnikov
commented
Jul 15, 2019
@alexcrichton , I do not throw this PR. I look through some more possible solutions. I would like the solution to be as minimal and simple as possible. |
alexcrichton
commented
Jul 15, 2019
This probably isn't the best place to discuss why architectural design decisions are the way they are in Rust, I'd recommend starting a thread on internals.rust-lang.org for that. I don't think this is an actionable change without more changes to the compiler itself, so I'm inclined to close this while those are settled. |
aleksmelnikov
commented
Jul 17, 2019
Probably adding new targets for compile features is not good path. |
fix compilation panic=abort for target i686-pc-windows-gnu on linux with w64-mingw32-gcc linker