Skip to content

Updated RELEASES.md for 1.37.0 - #62653

Closed
XAMPPRocky wants to merge 9 commits into
rust-lang:masterfrom
XAMPPRocky:master
Closed

Updated RELEASES.md for 1.37.0#62653
XAMPPRocky wants to merge 9 commits into
rust-lang:masterfrom
XAMPPRocky:master

Conversation

@XAMPPRocky

@XAMPPRockyXAMPPRocky commented Jul 13, 2019

Copy link
Copy Markdown
Contributor

Rendered

r? @Mark-Simulacrum

cc @rust-lang/release

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2019
@XAMPPRockyXAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jul 13, 2019
@kennytmkennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 13, 2019
kennytm
kennytm reviewed Jul 13, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
@XAMPPRocky@kennytm
Update RELEASES.md
795a2fe
Co-Authored-By: kennytm <kennytm@gmail.com>
Mark-Simulacrum
Mark-Simulacrum reviewed Jul 13, 2019
View reviewed changes
Comment threadRELEASES.md
Comment threadRELEASES.md Outdated
ghost
ghost suggested changes Jul 13, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
Centril
Centril reviewed Jul 13, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md
- [`#[must_use]` will now warn if the type is in a array and unused.][62235]
- [You can now use the `cfg` and `cfg_attr` attributes on
generic parameters.][61547]
- [You can now use enum variants through type alias.][61682] e.g. You can

@CentrilCentrilJul 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This arguably is the most important language change so I would put it first. Then I would mention consts, then Repr align. Also, I would use an example with Self here since that is likely the most common use.

@XAMPPRockyXAMPPRockyJul 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that arbitrary reordering does not provide much benefit in the RELEASES.md document. This is really the point of the blog post to highlight specific features and guide a user through a new release.

@CentrilCentrilJul 25, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reordering is not arbitrary, it's based on the relative importance of the features by estimating how many users will be affected and benefit from each one.

This is really the point of the blog post to highlight specific features and guide a user through a new release.

If so then we can dispense with examples in the release notes altogether. I think the blog post does a good job of talking in-depth about the most important bits but some users will read the release notes as well and we should use that opportunity wisely.

@XAMPPRockyXAMPPRockyJul 30, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reordering is not arbitrary, it's based on the relative importance of the features by estimating how many users will be affected and benefit from each one.

This would be important if the entire section was longer, but it isn't. It fits entirely on the page on all devices except mobile. Personally I find this to be pointless busy work, and I'm not going to do it. If you think it's that important feel free to make a separate PR.

Comment threadRELEASES.md Outdated
jonas-schievink
jonas-schievink reviewed Jul 14, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
jonas-schievink
jonas-schievink reviewed Jul 14, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
XAMPPRockyand others added 2 commits July 14, 2019 19:41
@XAMPPRocky@jonas-schievink
Apply suggestions from code review
b7a29c0
Co-Authored-By: Jonas Schievink <jonasschievink@gmail.com>
@XAMPPRocky
Update RELEASES.md
9994ca5
@ehuss

ehuss commented Jul 14, 2019

Copy link
Copy Markdown
Contributor

Have you decided how you want to link individual tool release notes?

@XAMPPRocky

XAMPPRocky commented Jul 15, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@ehuss I figured for this release we will we just do the same as previous releases, and I'll write up the format and add more to the relnotes tool for 1.38.0, as that should give everyone plenty of time.

cuviper
cuviper reviewed Jul 15, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
@emilyalbiniemilyalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 16, 2019
@XAMPPRocky@cuviper
Update RELEASES.md
f2f4c0e
Co-Authored-By: Josh Stone <cuviper@gmail.com>
@emilyalbiniemilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 22, 2019
Mark-Simulacrum
Mark-Simulacrum reviewed Jul 26, 2019
View reviewed changes
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
XAMPPRockyand others added 2 commits July 26, 2019 14:55
@XAMPPRocky@Mark-Simulacrum
Update RELEASES.md
6b0f4c6
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
@XAMPPRocky
Update RELEASES.md
f695906
@edmilsonefs

edmilsonefs commented Jul 30, 2019

Copy link
Copy Markdown

Hey! This is a ping from triage, we would like to know if you @Mark-Simulacrum could give us a few more minutes to update us from last changes made by @XAMPPRocky .

@Mark-Simulacrum

Mark-Simulacrum commented Jul 30, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Modulo @Centril's comment (https://github.com/rust-lang/rust/pull/62653/files#r303208440) I think this is good to go.

Edit: would also be good to squash the commits down

@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jul 30, 2019
Merged
@Mark-Simulacrum

Mark-Simulacrum commented Jul 30, 2019

Copy link
Copy Markdown
Member

Merging as #63147 since GH won't let me push to this branch for some reason (maybe because master?)

Centril added a commit to Centril/rust that referenced this pull request Jul 30, 2019
@Centril
Rollup merge ofrust-lang#63147- Mark-Simulacrum:XAMPPRocky-master, …
0924ac7
…r=Mark-Simulacrum
Updated RELEASES.md for 1.37.0
Squashed rust-lang#62653.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuvipercuvipercuviper left review comments
@kennytmkennytmkennytm left review comments
@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
@cramertjcramertjcramertj left review comments
+3 more reviewers
@CentrilCentrilCentril left review comments
@jonas-schievinkjonas-schievinkjonas-schievink left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.C-enhancementCategory: An issue proposing an enhancement or a PR with one.S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@XAMPPRocky@ehuss@edmilsonefs@Mark-Simulacrum@cuviper@kennytm@Centril@jonas-schievink@cramertj@emilyalbini@rust-highfive