Skip to content

Check for lldb existences - #62671

Merged
bors merged 1 commit into
rust-lang:masterfrom
tesuji:tidy-lldb
Jul 18, 2019
Merged

Check for lldb existences#62671
bors merged 1 commit into
rust-lang:masterfrom
tesuji:tidy-lldb

Conversation

@tesuji

@tesujitesuji commented Jul 14, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Jul 14, 2019

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2019
@alexcrichton

alexcrichton commented Jul 15, 2019

Copy link
Copy Markdown
Member

Thanks for the PR! This PR name and description however are unfortunately very light on details (e.g. there's no description at all). Can you expand a bit on what this PR is doing, what the change is fixing, and perhaps the motivation as well?

@tesuji

tesuji commented Jul 15, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I'm sorry. I must have been more clear.
The problem is if we do not detect if lldb exists, then when calling rust-lldb,
we could have something like this:

% rust-lldb/home/lzutao/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rust-lldb: 34: exec: lldb: not found

With this PR, the script will check if lldb exists, and error out if lldb not found.
Also, this PR favors $() subcommand syntax over `command`. Which I think is more
clear to see.

@alexcrichton

alexcrichton commented Jul 15, 2019

Copy link
Copy Markdown
Member

Ok thanks for the explanation, looks good to me!

@bors: r+

@bors

bors commented Jul 15, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit d649ff3 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2019
@tesuji

tesuji commented Jul 17, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors rollup

@bors

bors commented Jul 17, 2019

Copy link
Copy Markdown
Collaborator

@lzutao: 🔑 Insufficient privileges: not in try users

@bors

bors commented Jul 18, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d649ff3 with merge 21d5b8b...

bors added a commit that referenced this pull request Jul 18, 2019
@bors
Auto merge of#62671- lzutao:tidy-lldb, r=alexcrichton
21d5b8b
Check for lldb existences
@borsbors mentioned this pull request Jul 18, 2019
Merged
@bors

bors commented Jul 18, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 21d5b8b to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jul 18, 2019
@bors
bors merged commit d649ff3 into rust-lang:masterJul 18, 2019
@tesuji
tesuji deleted the tidy-lldb branch July 18, 2019 13:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tesuji@rust-highfive@alexcrichton@bors