Deprecate using rustc_plugin without the rustc_driver dylib. by SimonSapin · Pull Request #62727 · rust-lang/rust

SimonSapin · 2019-07-16T17:46:31Z

CC #59800, 7198687

Fix#62717

rust-highfive · 2019-07-16T17:46:35Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2019-07-16T17:48:17Z

r? @Zoxc

Zoxc · 2019-07-16T18:15:27Z

How does this trickery work?

Centril · 2019-07-16T23:59:32Z

At this point I think we should look to remove the plugin support from rustc.

SimonSapin · 2019-07-17T06:46:32Z

@Zoxc Do you mean this PR?

At first I tried adding #![rustc_deprecated] to the rustc_plugin crate so that depending on it directly causes a warning. But that caused every item to be deprecated as well. So instead this PR renames the crate to rustc_plugin_ (note the suffix, I was not inspired for another name) and creates a new crate with the old name that reexports all of its items. Only the new crate is deprecated.

Or do you mean the bug that it fixes? I’m not sure exactly. It looks like on Windows and macOS, failing to depend on the appropriate dylib crate results in there being two copies of a TLS variable or something. You found the same work-around in 7198687.

@Centril On one hand, we’ve arguably already been at that point for a couple years. On the other hand, Servo’s memory safety unfortunately still depends on a custom lint that checks that GC pointers on the stack are properly rooted: https://github.com/servo/servo/tree/cef98d2e5179/components/script_plugins

I would love to find another solution, this plugin is regularly giving us headaches. But until we do, if the plugin API is removed Servo will be unable to upgrade and will be stuck on an old Rust Nightly.

Centril · 2019-07-21T00:14:36Z

@Centril On one hand, we’ve arguably already been at that point for a couple years. On the other hand, Servo’s memory safety unfortunately still depends on a custom lint that checks that GC pointers on the stack are properly rooted: https://github.com/servo/servo/tree/cef98d2e5179/components/script_plugins
I would love to find another solution, this plugin is regularly giving us headaches. But until we do, if the plugin API is removed Servo will be unable to upgrade and will be stuck on an old Rust Nightly.

So there has been no movement since last time we discussed this. That's unfortunate. At some point however, I think it stops being reasonable for rustc to indefinitely maintain the plugin interface solely for the benefit of servo. What would it take to get rid of your reliance on this?

SimonSapin · 2019-07-22T09:05:03Z

What would it take to get rid of your reliance on this?

I’ve opened #62868 to discuss this, as I feel it doesn’t need to block this PR.

SimonSapin · 2019-07-26T16:31:14Z

@Zoxc friendly review ping

bors · 2019-07-27T03:25:10Z

☔ The latest upstream changes (presumably #62086) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2019-07-27T23:12:14Z

☔ The latest upstream changes (presumably #63029) made this pull request unmergeable. Please resolve the merge conflicts.

JohnTitor · 2019-08-04T08:11:34Z

Ping from triage: @Zoxc, waiting on your review. And @SimonSapin, you should resolve merge conflicts.

joelpalmer · 2019-08-12T11:37:53Z

Ping from triage: @Zoxc, any update on the review?

SimonSapin · 2019-08-19T12:13:14Z

@rust-lang/compiler, can anyone else review this?

petrochenkov · 2019-08-19T12:18:55Z

r? @petrochenkov

petrochenkov · 2019-08-19T12:22:40Z

I don't think this compatibility shim is necessary.
rustc_plugin is almost unused at this point, so it should be ok to make people to migrate to rustc_driver::plugin in one step.

That’s fair, but now that the shim is already implemented it’s the same amount of work to remove it now or later.

If this is merged now, I'll have to make a PR removing it myself once this PR lands, I don't want to do that + I'd prefer some pointless back and forth to not exist in git history.

Ah, I see, Cargo uses it, and we cannot land this PR with broken cargo.
Ok, let's land this with the shim.

Breaking extern crate rustc_plugin; in the same PR as we make its replacement available means that Clippy and RLS will be broken for a few Nightlies until we can get the multi-repo coordination dance together. This doesn’t sound great when it’s easily avoided.
If you’d like I can be on the hook for making the follow-up PR that removes the deprecated shim later.

If you’d like I can be on the hook for making the follow-up PR that removes the deprecated shim later.
Yeah, that would be great.

petrochenkov · 2019-08-19T13:20:52Z

@SimonSapin
Could you

rename rustc_plugin_ into rustc_plugin_impl
check whether some docs in this repo (like unstable book or something) still mention rustc_plugin

Otherwise this looks good.

SimonSapin · 2019-08-19T22:23:03Z

@bors r=petrochenkov

bors · 2019-08-19T22:23:04Z

📌 Commit d0bbc60 has been approved by petrochenkov

bors · 2019-08-20T00:31:20Z

⌛ Testing commit d0bbc60 with merge d8d99ba...

Deprecate using rustc_plugin without the rustc_driver dylib. CC #59800, 7198687Fix#62717

bors · 2019-08-20T04:14:39Z

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing d8d99ba to master...

rust-highfive · 2019-08-20T04:15:51Z

📣 Toolstate changed by #62727!

Tested on commit d8d99ba.
Direct link to PR: #62727

💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).

@Xanewok

Tested on commit rust-lang/rust@d8d99ba. Direct link to PR: <rust-lang/rust#62727> 💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).

Import rustc_plugin from its new location Depends on rust-lang/rust#62727 changelog: none

It was accidentally removed in a rebase of rust-lang#62727Fixesrust-lang#63729

Restore the rustc_plugin crate in the sysroot It was accidentally removed in a rebase of rust-lang#62727Fixesrust-lang#63729 (rls build failure)

CC rust-lang/rust#62727

2. Up version.

CC rust-lang/rust#62727

Tests: Import rustc_plugin from its new location CC rust-lang/rust#62727

rustc_plugin: Remove the compatibility shim The compatibility crate was introduced in rust-lang#62727 to migrate Cargo and some other tools, but now it's no longer necessary.

rust-highfive assigned petrochenkov Jul 16, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2019

rust-highfive assigned Zoxc and unassigned petrochenkov Jul 16, 2019

SimonSapin mentioned this pull request Jul 22, 2019
Alternatives to rustc_plugin::registry for (Servo’s) custom lints? #62868
Closed

nikomatsakis mentioned this pull request Jul 25, 2019
ICE "no ImplicitCtxt stored in tls" in Servo on Windows and macOS #62717
Closed

SimonSapin force-pushed the plugins-tls-dylib branch from 9aa111e to 2025965Compare July 27, 2019 07:51

petrochenkov mentioned this pull request Aug 5, 2019
ICE - 'cannot access a scoped thread local variable without calling set first' #63283
Closed

petrochenkov mentioned this pull request Aug 13, 2019
ICE on roman numeral macro example #63536
Closed

SimonSapin force-pushed the plugins-tls-dylib branch from 2025965 to 8ac220bCompare August 19, 2019 12:12

rust-highfive assigned petrochenkov and unassigned Zoxc Aug 19, 2019

petrochenkov reviewed Aug 19, 2019
View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2019

bors added a commit that referenced this pull request Aug 20, 2019
Auto merge of#62727- SimonSapin:plugins-tls-dylib, r=petrochenkov
d8d99ba
Deprecate using rustc_plugin without the rustc_driver dylib. CC #59800, 7198687Fix#62717

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 20, 2019

bors merged commit d0bbc60 into rust-lang:masterAug 20, 2019

rust-highfive mentioned this pull request Aug 20, 2019
rls no longer builds after rust-lang/rust#62727 #63729
Closed

bors added a commit to rust-lang/rust-clippy that referenced this pull request Aug 20, 2019
Auto merge of#4416- SimonSapin:plugin, r=phansch
b1d735d
Import rustc_plugin from its new location Depends on rust-lang/rust#62727 changelog: none

SimonSapin deleted the plugins-tls-dylib branch August 20, 2019 11:03

SimonSapin added a commit to SimonSapin/rust that referenced this pull request Aug 20, 2019
Restore the rustc_plugin crate in the sysroot
c561abe
It was accidentally removed in a rebase of rust-lang#62727Fixesrust-lang#63729

SimonSapin mentioned this pull request Aug 20, 2019
Restore the rustc_plugin crate in the sysroot #63736
Merged

SimonSapin added a commit to SimonSapin/rls that referenced this pull request Aug 22, 2019
Import rustc_plugin from its new location
5d808cd
CC rust-lang/rust#62727

This was referenced Aug 22, 2019
Import rustc_plugin from its new location rust-lang/rls#1544
Merged
Tests: Import rustc_plugin from its new location rust-lang/cargo#7287
Merged

denisandroid added a commit to clucompany/cluCStr that referenced this pull request Aug 22, 2019
1. Fixed "rust-lang/rust#62727"
739f9dc
2. Up version.

SimonSapin added a commit to SimonSapin/cargo that referenced this pull request Aug 24, 2019
Tests: Import rustc_plugin from its new location
3f40330
CC rust-lang/rust#62727

bors added a commit to rust-lang/cargo that referenced this pull request Aug 24, 2019
Auto merge of#7287- SimonSapin:plugin, r=ehuss
475a23e
Tests: Import rustc_plugin from its new location CC rust-lang/rust#62727

petrochenkov mentioned this pull request Nov 16, 2019
rustc_plugin: Remove the compatibility shim #66478
Merged

chrissimpkins mentioned this pull request Mar 11, 2020
ICE with const generics with disabled feature flag #69913
Closed

Uh oh!

Uh oh!

Conversation

SimonSapin commented Jul 16, 2019

Uh oh!

rust-highfive commented Jul 16, 2019

Uh oh!

eddyb commented Jul 16, 2019

Uh oh!

Zoxc commented Jul 16, 2019

Uh oh!

Centril commented Jul 16, 2019

Uh oh!

SimonSapin commented Jul 17, 2019

Uh oh!

Centril commented Jul 21, 2019

Uh oh!

SimonSapin commented Jul 22, 2019

Uh oh!

SimonSapin commented Jul 26, 2019

Uh oh!

bors commented Jul 27, 2019

Uh oh!

bors commented Jul 27, 2019

Uh oh!

JohnTitor commented Aug 4, 2019

Uh oh!

joelpalmer commented Aug 12, 2019

Uh oh!

SimonSapin commented Aug 19, 2019

Uh oh!

petrochenkov commented Aug 19, 2019

Uh oh!

petrochenkovAug 19, 2019

Choose a reason for hiding this comment

Uh oh!

SimonSapinAug 19, 2019

Choose a reason for hiding this comment

Uh oh!

petrochenkovAug 19, 2019

Choose a reason for hiding this comment

Uh oh!

petrochenkovAug 19, 2019

Choose a reason for hiding this comment

Uh oh!

SimonSapinAug 19, 2019

Choose a reason for hiding this comment

Uh oh!

petrochenkovAug 19, 2019

Choose a reason for hiding this comment

Uh oh!

petrochenkov commented Aug 19, 2019

Uh oh!

SimonSapin commented Aug 19, 2019

Uh oh!

bors commented Aug 19, 2019

Uh oh!

bors commented Aug 20, 2019

Uh oh!

bors commented Aug 20, 2019

Uh oh!

rust-highfive commented Aug 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants