Uh oh!
There was an error while loading. Please reload this page.
Handle more cases of typos misinterpreted as type ascription - #62791
Merged
Conversation
rust-highfive
commented
Jul 18, 2019
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
estebank
commented
Jul 19, 2019
ContributorAuthor
This comment has been minimized.
This comment has been minimized.
This was referenced Jul 19, 2019
CryZe
reviewed
Jul 19, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
petrochenkov
commented
Jul 19, 2019
Contributor
r=me with nits addressed and the debugging |
This comment has been minimized.
This comment has been minimized.
estebank
commented
Jul 19, 2019
ContributorAuthor
@bors r=petrochenkov |
bors
commented
Jul 19, 2019
Collaborator
📌 Commit 9dbe2e7 has been approved by |
This was referenced Jul 20, 2019
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 21, 2019
…enkov Handle more cases of typos misinterpreted as type ascription Fixrust-lang#60933, rust-lang#54516. CC rust-lang#47666, rust-lang#34255, rust-lang#48016.
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 23, 2019
…enkov Handle more cases of typos misinterpreted as type ascription Fixrust-lang#60933, rust-lang#54516. CC rust-lang#47666, rust-lang#34255, rust-lang#48016.
bors added a commit
that referenced
this pull request
Jul 23, 2019
Rollup of 14 pull requests Successful merges: - #60951 (more specific errors in src/librustc/mir/interpret/error.rs) - #62523 (Delay bug to resolve HRTB ICE) - #62656 (explain how to search in slice without owned data) - #62791 (Handle more cases of typos misinterpreted as type ascription) - #62804 (rustc_typeck: improve diagnostics for _ const/static declarations) - #62808 (Revert "Disable stack probing for gnux32.") - #62817 (Tweak span for variant not found error) - #62842 (Add tests for issue-58887) - #62851 (move unescape module to rustc_lexer) - #62859 (Place::as_place_ref is now Place::as_ref) - #62869 (add rustc_private as a proper language feature gate) - #62880 (normalize use of backticks in compiler messages for librustc_allocator) - #62885 (Change "OSX" to "macOS") - #62889 (Update stage0.txt) Failed merges: r? @ghost
frehberg
commented
Jul 28, 2019
Contributor
Sorry, I removed my comment, it was caused by an error in my code. |
bors added a commit
that referenced
this pull request
Aug 4, 2019
Point at type ascription before macro invocation on expansion parse error Fix#47666. Follow up to #62791. r? @petrochenkov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#60933, #54516.
CC #47666, #34255, #48016.