Uh oh!
There was an error while loading. Please reload this page.
[beta] Backport #62615 - #62793
Merged
Merged
Conversation
When `rustc` is invoked with the `--print` argument, we don't actually generate any code (unless it's the `native-static-libs` option). So we don't need to error our in this case since there's no risk of generating either LLVM assertions or corrupted binaries.
rust-highfive
commented
Jul 19, 2019
Contributor
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Jul 19, 2019
Contributor
|
zackmdavis
commented
Jul 19, 2019
Contributor
bors
commented
Jul 19, 2019
Collaborator
📌 Commit d380987 has been approved by |
wesleywiser
commented
Jul 19, 2019
MemberAuthor
I don't believe there's anything special, no. |
Centril
commented
Jul 21, 2019
Contributor
@bors p=-1 cc @pietroalbini for beta rollup? |
wesleywiser
commented
Jul 21, 2019
MemberAuthor
@Centril I see the tree is currently closed but it would be great to get the into beta soon-ish so Mozilla can verify there's no other issues blocking them from using PGO in 1.37. |
Centril
commented
Jul 21, 2019
Contributor
The tree is closed due to CI problems; See #62856 for the fix. Pietro will do a beta backport rollup once the problems are gone. |
wesleywiser
commented
Jul 21, 2019
MemberAuthor
Awesome, thanks so much! |
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Jul 22, 2019
bors added a commit
that referenced
this pull request
Jul 22, 2019
[beta] Rollup backports Cherry picked: * rustc_target: avoid negative register counts in the SysV x86_64 ABI. #62380 * Fix ICEs when `Self` is used in type aliases #62417 * Raise the default recursion limit to 128 #62450 * Handle errors during error recovery gracefully #62604 * Correctly break out of recovery loop #62607 * Cancel unemitted diagnostics during error recovery #62666 * ci: pin awscli dependencies #62856 * Ensure that checkout is with \n line endings #62564 Rolled up: * [beta] Backport #62615#62793 * [beta] Fix#62660#62792 r? @ghost
bors added a commit
that referenced
this pull request
Jul 22, 2019
[beta] Rollup backports Cherry picked: * rustc_target: avoid negative register counts in the SysV x86_64 ABI. #62380 * Fix ICEs when `Self` is used in type aliases #62417 * Raise the default recursion limit to 128 #62450 * Handle errors during error recovery gracefully #62604 * Correctly break out of recovery loop #62607 * Cancel unemitted diagnostics during error recovery #62666 * ci: pin awscli dependencies #62856 * Ensure that checkout is with \n line endings #62564 Rolled up: * [beta] Backport #62615#62793 * [beta] Fix#62660#62792 r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the backport of #62615