rustc: Compile the `fmt_macros` crate as an rlib by alexcrichton · Pull Request #62813 · rust-lang/rust

alexcrichton · 2019-07-19T20:07:40Z

I think this was left out by accident from the "convert everything to
rlibs" commit, there's no need for this to be a dylib just as everything
else doesn't need to be a dylib!

rust-highfive · 2019-07-19T20:07:51Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2019-07-19T20:13:54Z

@bors r+

bors · 2019-07-19T20:13:56Z

📌 Commit c1b4d62 has been approved by Mark-Simulacrum

…ulacrum rustc: Compile the `fmt_macros` crate as an rlib I think this was left out by accident from the "convert everything to rlibs" commit, there's no need for this to be a dylib just as everything else doesn't need to be a dylib!

Centril · 2019-07-28T01:02:21Z

I think this might be causing issues in #63052 (comment).

@bors rollup=never

bors · 2019-07-29T04:02:09Z

⌛ Testing commit c1b4d62 with merge 06e18a668cf3616f7ce56d14072641fa52534207...

bors · 2019-07-29T05:57:02Z

💔 Test failed - checks-azure

rust-highfive · 2019-07-29T05:57:03Z

The job i686-apple of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-07-29T05:54:51.8110250Z status: exit code: 2
2019-07-29T05:54:51.8110410Z command: "make"
2019-07-29T05:54:51.8110620Z stdout:
2019-07-29T05:54:51.8111480Z ------------------------------------------
2019-07-29T05:54:51.8111690Z /bin/echo || exit 0 # This test requires /bin/echo to exist
2019-07-29T05:54:51.8111750Z 2019-07-29T05:54:51.8113250Z DYLD_LIBRARY_PATH="/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend:/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/lib:" '/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/bin/rustc' --out-dir /Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend -L /Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend the_backend.rs --crate-name the_backend --crate-type dylib \
2019-07-29T05:54:51.8114740Z -o /Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend/the_backend.dylib
2019-07-29T05:54:51.8116710Z DYLD_LIBRARY_PATH="/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend:/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/lib:" '/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/bin/rustc' --out-dir /Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend -L /Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend some_crate.rs --crate-name some_crate --crate-type lib -o /Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend/some_crate \
2019-07-29T05:54:51.8118330Z -Z codegen-backend=/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend/the_backend.dylib -Z unstable-options
2019-07-29T05:54:51.8119130Z ------------------------------------------
2019-07-29T05:54:51.8119240Z stderr:
2019-07-29T05:54:51.8119900Z ------------------------------------------
2019-07-29T05:54:51.8120020Z warning: trait objects without an explicit `dyn` are deprecated
2019-07-29T05:54:51.8120020Z warning: trait objects without an explicit `dyn` are deprecated
2019-07-29T05:54:51.8120680Z --> the_backend.rs:43:38
2019-07-29T05:54:51.8120790Z |
2019-07-29T05:54:51.8121610Z 43 | fn metadata_loader(&self) -> Box<MetadataLoader + Sync> {
2019-07-29T05:54:51.8121770Z | ^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn MetadataLoader + Sync`
2019-07-29T05:54:51.8122070Z = note: `#[warn(bare_trait_objects)]` on by default
2019-07-29T05:54:51.8122140Z 2019-07-29T05:54:51.8122280Z warning: trait objects without an explicit `dyn` are deprecated
2019-07-29T05:54:51.8123010Z --> the_backend.rs:66:33
2019-07-29T05:54:51.8123010Z --> the_backend.rs:66:33
2019-07-29T05:54:51.8123110Z |
2019-07-29T05:54:51.8123200Z 66 | _rx: mpsc::Receiver<Box<Any + Send>>
2019-07-29T05:54:51.8123310Z | ^^^^^^^^^^ help: use `dyn`: `dyn Any + Send`
2019-07-29T05:54:51.8123540Z warning: trait objects without an explicit `dyn` are deprecated
2019-07-29T05:54:51.8124210Z --> the_backend.rs:67:14
2019-07-29T05:54:51.8124340Z |
2019-07-29T05:54:51.8124960Z 67 | ) -> Box<Any> {
2019-07-29T05:54:51.8124960Z 67 | ) -> Box<Any> {
2019-07-29T05:54:51.8125090Z | ^^^ help: use `dyn`: `dyn Any`
2019-07-29T05:54:51.8125150Z 2019-07-29T05:54:51.8125360Z warning: trait objects without an explicit `dyn` are deprecated
2019-07-29T05:54:51.8126090Z --> the_backend.rs:75:30
2019-07-29T05:54:51.8126310Z |
2019-07-29T05:54:51.8126400Z 75 | ongoing_codegen: Box<Any>,
2019-07-29T05:54:51.8126510Z | ^^^ help: use `dyn`: `dyn Any`
2019-07-29T05:54:51.8126660Z warning: trait objects without an explicit `dyn` are deprecated
2019-07-29T05:54:51.8127360Z --> the_backend.rs:100:41
2019-07-29T05:54:51.8127490Z |
2019-07-29T05:54:51.8127490Z |
2019-07-29T05:54:51.8128160Z 100 | pub fn __rustc_codegen_backend() -> Box<CodegenBackend> {
2019-07-29T05:54:51.8128310Z | ^^^^^^^^^^^^^^ help: use `dyn`: `dyn CodegenBackend`
2019-07-29T05:54:51.8128390Z 2019-07-29T05:54:51.8129040Z warning: ignoring --out-dir flag due to -o flag
2019-07-29T05:54:51.8129130Z 2019-07-29T05:54:51.8129780Z warning: ignoring --out-dir flag due to -o flag
2019-07-29T05:54:51.8129860Z 2019-07-29T05:54:51.8130740Z thread '<unnamed>' panicked at 'cannot access a scoped thread local variable without calling `set` first', /Users/vsts/.cargo/registry/src/github.com-1ecc6299db9ec823/scoped-tls-1.0.0/src/lib.rs:168:9
2019-07-29T05:54:51.8131010Z 2019-07-29T05:54:51.8131110Z error: internal compiler error: unexpected panic
2019-07-29T05:54:51.8131160Z 2019-07-29T05:54:51.8131160Z 2019-07-29T05:54:51.8131240Z note: the compiler unexpectedly panicked. this is a bug.
2019-07-29T05:54:51.8131310Z 2019-07-29T05:54:51.8132050Z note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
2019-07-29T05:54:51.8132170Z 2019-07-29T05:54:51.8132840Z note: rustc 1.38.0-dev running on i686-apple-darwin
2019-07-29T05:54:51.8132920Z 2019-07-29T05:54:51.8134160Z note: compiler flags: -Z codegen-backend=/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend/the_backend.dylib -Z unstable-options --crate-type lib
2019-07-29T05:54:51.8134550Z 2019-07-29T05:54:51.8134670Z make: *** [all] Error 101
2019-07-29T05:54:51.8135460Z ------------------------------------------
2019-07-29T05:54:51.8135530Z 2019-07-29T05:54:51.8135580Z 2019-07-29T05:54:51.8135640Z ---
2019-07-29T05:54:51.8138180Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:533:22
2019-07-29T05:54:51.8138340Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-29T05:54:51.8138400Z 2019-07-29T05:54:51.8138450Z 2019-07-29T05:54:51.8145160Z command did not execute successfully: "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/lib" "--run-lib-path" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib" "--rustc-path" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "--rustdoc-path" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/bin/rustdoc" "--src-base" "/Users/vsts/agent/2.154.3/work/1/s/src/test/run-make-fulldeps" "--build-base" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/run-make-fulldeps" "--stage-id" "stage2-i686-apple-darwin" "--mode" "run-make" "--target" "i686-apple-darwin" "--host" "i686-apple-darwin" "--llvm-filecheck" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-902.0.79.2\n Swift-4.1\n" "--lldb-python-dir" "/Applications/Xcode_9.3.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "9.0.0-rust-1.38.0-dev\n" "--cc" "/Users/vsts/agent/2.154.3/work/1/s/clang+llvm-7.0.0-x86_64-apple-darwin/bin/clang" "--cxx" "/Users/vsts/agent/2.154.3/work/1/s/clang+llvm-7.0.0-x86_64-apple-darwin/bin/clang++" "--cflags" "-ffunction-sections -fdata-sections -fPIC --target=i686-apple-darwin -stdlib=libc++" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter binaryformat bitreader bitstreamreader bitwriter codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel gtest gtest_main hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target testingsupport textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xray" "--llvm-cxxflags" "-I/Users/vsts/agent/2.154.3/work/1/s/src/llvm-project/llvm/include -I/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/llvm/build/include -std=c++11 -stdlib=libc++ -fno-exceptions -fno-rtti -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS" "--ar" "ar" "--llvm-bin-dir" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/llvm/build/bin" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-29T05:54:51.8147690Z 2019-07-29T05:54:51.8147740Z 2019-07-29T05:54:51.8147850Z failed to run: /Users/vsts/agent/2.154.3/work/1/s/build/bootstrap/debug/bootstrap test
2019-07-29T05:54:51.8148120Z Build completed unsuccessfully in 1:47:20
2019-07-29T05:54:51.8148120Z Build completed unsuccessfully in 1:47:20
2019-07-29T05:54:51.8383050Z ##[error]Bash exited with code '1'.
2019-07-29T05:54:51.8430820Z ##[section]Starting: Upload CPU usage statistics
2019-07-29T05:54:51.8465300Z ==============================================================================
2019-07-29T05:54:51.8465650Z Task : Bash
2019-07-29T05:54:51.8465880Z Description : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

I think this was left out by accident from the "convert everything to rlibs" commit, there's no need for this to be a dylib just as everything else doesn't need to be a dylib!

alexcrichton · 2019-07-29T15:15:35Z

@bors: r=Mark-Simulacrum

bors · 2019-07-29T15:15:37Z

📌 Commit 9f6e1ce has been approved by Mark-Simulacrum

bors · 2019-07-31T07:30:05Z

⌛ Testing commit 9f6e1ce with merge 9152fe4...

rustc: Compile the `fmt_macros` crate as an rlib I think this was left out by accident from the "convert everything to rlibs" commit, there's no need for this to be a dylib just as everything else doesn't need to be a dylib!

bors · 2019-07-31T11:17:38Z

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 9152fe4 to master...

rust-highfive assigned nikomatsakis Jul 19, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2019

Mark-Simulacrum assigned Mark-Simulacrum and unassigned nikomatsakis Jul 19, 2019

Centril mentioned this pull request Jul 21, 2019
Rollup of 11 pull requests #62840
Closed

Centril mentioned this pull request Jul 22, 2019
Rollup of 12 pull requests #62882
Closed

Centril mentioned this pull request Jul 23, 2019
Rollup of 13 pull requests #62920
Closed

Centril mentioned this pull request Jul 27, 2019
Rollup of 5 pull requests #63049
Closed

Centril mentioned this pull request Jul 27, 2019
Rollup of 6 pull requests #63052
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 29, 2019

rustc: Compile the fmt_macros crate as an rlib
9f6e1ce
I think this was left out by accident from the "convert everything to rlibs" commit, there's no need for this to be a dylib just as everything else doesn't need to be a dylib!

alexcrichton force-pushed the less-dylib branch from c1b4d62 to 9f6e1ceCompare July 29, 2019 15:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2019

bors mentioned this pull request Jul 31, 2019
Add keywords item into the sidebar #62971
Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2019

bors merged commit 9f6e1ce into rust-lang:masterJul 31, 2019

alexcrichton deleted the less-dylib branch July 31, 2019 17:58

Navigation Menu

Uh oh!

Uh oh!

rustc: Compile the `fmt_macros` crate as an rlib - #62813

rustc: Compile the `fmt_macros` crate as an rlib#62813
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:less-dylib

alexcrichton commented Jul 19, 2019

Uh oh!

rust-highfive commented Jul 19, 2019

Uh oh!

Mark-Simulacrum commented Jul 19, 2019

Uh oh!

bors commented Jul 19, 2019

Uh oh!

Centril commented Jul 28, 2019

Uh oh!

bors commented Jul 29, 2019

Uh oh!

bors commented Jul 29, 2019

Uh oh!

rust-highfive commented Jul 29, 2019

Uh oh!

alexcrichton commented Jul 29, 2019

Uh oh!

bors commented Jul 29, 2019

Uh oh!

bors commented Jul 31, 2019

Uh oh!

bors commented Jul 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

alexcrichton commented Jul 19, 2019

Uh oh!

rust-highfive commented Jul 19, 2019

Uh oh!

Mark-Simulacrum commented Jul 19, 2019

Uh oh!

bors commented Jul 19, 2019

Uh oh!

Centril commented Jul 28, 2019

Uh oh!

bors commented Jul 29, 2019

Uh oh!

bors commented Jul 29, 2019

Uh oh!

rust-highfive commented Jul 29, 2019

Uh oh!

alexcrichton commented Jul 29, 2019

Uh oh!

bors commented Jul 29, 2019

Uh oh!

bors commented Jul 31, 2019

Uh oh!

bors commented Jul 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants