Uh oh!
There was an error while loading. Please reload this page.
update Miri - #62823
Conversation
rust-highfive
commented
Jul 20, 2019
|
oli-obk
commented
Jul 20, 2019
@bors r+ p=1 |
bors
commented
Jul 20, 2019
📌 Commit 24c86eb2e887d614d55a92c21a79745ee6d9d068 has been approved by |
rust-highfive
commented
Jul 20, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
RalfJung
commented
Jul 20, 2019
@bors r- Investigating |
I think my own PR broke Miri... |
RalfJung
commented
Jul 20, 2019
I disabled the "overlaps" check in We can enable it again when we make progress on rust-lang/miri#785. |
This comment has been minimized.
This comment has been minimized.
RalfJung
commented
Jul 20, 2019
Oh dang... some compile-fail tests are failing because they run against a libstd with debug assertions and that changes the error message. |
rust-highfive
commented
Jul 20, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
That CI failure is just #62811. Waiting for review for the |
oli-obk
commented
Jul 21, 2019
👍 on the cfgs, but a comment would be nice |
RalfJung
commented
Jul 21, 2019
We also need to include rust-lang/miri#849. |
RalfJung
commented
Jul 21, 2019
Okay, let's see if PR-CI is happy... |
rust-highfive
commented
Jul 21, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
RalfJung
commented
Jul 21, 2019
bors
commented
Jul 21, 2019
📌 Commit 10f877b has been approved by |
bors
commented
Jul 21, 2019
⌛ Testing commit 10f877b with merge 29198dac6e175eb7ee70f185995a4fe3f34829b4... |
Centril
commented
Jul 21, 2019
bors
commented
Jul 21, 2019
⌛ Testing commit 10f877b with merge b6e0c7cc5fded2fdca5817cf32dc2e64309e082b... |
bors
commented
Jul 21, 2019
💔 Test failed - checks-azure |
rust-highfive
commented
Jul 21, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
RalfJung
commented
Jul 21, 2019
Not sure what that is... AWS complains or so? @bors retry |
bors
commented
Jul 23, 2019
bors
commented
Jul 23, 2019
💥 Test timed out |
RalfJung
commented
Jul 23, 2019
@bors retry |
bors
commented
Jul 23, 2019
bors
commented
Jul 23, 2019
☀️ Test successful - checks-azure |
rust-highfive
commented
Jul 23, 2019
Tested on commit rust-lang/rust@299ef86. Direct link to PR: <rust-lang/rust#62823> 🎉 miri on windows: build-fail → test-pass (cc @oli-obk@RalfJung@eddyb, @rust-lang/infra). 🎉 miri on linux: build-fail → test-pass (cc @oli-obk@RalfJung@eddyb, @rust-lang/infra).
Fixes#62802
r? @oli-obk@eddyb