Skip to content

Remove vector fadd/fmul reduction workarounds - #62828

Merged
bors merged 1 commit into
rust-lang:masterfrom
nikic:fadd-mul-reductions
Jul 26, 2019
Merged

Remove vector fadd/fmul reduction workarounds#62828
bors merged 1 commit into
rust-lang:masterfrom
nikic:fadd-mul-reductions

Conversation

@nikic

Copy link
Copy Markdown
Contributor

The bugs that this was working around have been fixed in LLVM 9.

r? @gnzlbg

@rust-highfive

This comment has been minimized.

The bugs that this was working around have been fixed in LLVM 9.
@nikic
nikicforce-pushed the fadd-mul-reductions branch from ed0e0a2 to 6fae7dbCompareJuly 20, 2019 16:50

@gnzlbggnzlbg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay, and thank you for working on this @nikic and on LLVM upstream!

@bors: r+

@gnzlbg

Copy link
Copy Markdown
Contributor

@eddyb could you r+ this ?

@eddyb

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jul 25, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 6fae7db has been approved by eddyb

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 25, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 25, 2019
Remove vector fadd/fmul reduction workarounds
The bugs that this was working around have been fixed in LLVM 9.
r? @gnzlbg
@CentrilCentril mentioned this pull request Jul 25, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
Remove vector fadd/fmul reduction workarounds
The bugs that this was working around have been fixed in LLVM 9.
r? @gnzlbg
@CentrilCentril mentioned this pull request Jul 26, 2019
bors added a commit that referenced this pull request Jul 26, 2019
Rollup of 14 pull requests
Successful merges:
- #62084 (allow clippy::unreadable_literal in unicode tables)
- #62421 (Introduce `as_deref` to Option)
- #62692 (rustc: precompute the largest Niche and store it in LayoutDetails.)
- #62801 (Remove support for -Zlower-128bit-ops)
- #62828 (Remove vector fadd/fmul reduction workarounds)
- #62862 (code cleanup)
- #62897 (Attempt to fix backtrace tests on i686-msvc)
- #62904 (Disable d32 on armv6 hf targets)
- #62907 (Initialize the MSP430 AsmParser)
- #62956 (Implement slow-path for FirstSets::first)
- #62963 (Allow lexer to recover from some homoglyphs)
- #62970 (ci: gate toolstate repo pushes on the TOOLSTATE_PUBLISH envvar)
- #62983 (Remove needless indirection through Rc)
- #62985 (librustc_errors: Support ui-testing flag in annotate-snippet emitter)
Failed merges:
r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
Remove vector fadd/fmul reduction workarounds
The bugs that this was working around have been fixed in LLVM 9.
r? @gnzlbg
@CentrilCentril mentioned this pull request Jul 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
Remove vector fadd/fmul reduction workarounds
The bugs that this was working around have been fixed in LLVM 9.
r? @gnzlbg
@CentrilCentril mentioned this pull request Jul 26, 2019
bors added a commit that referenced this pull request Jul 26, 2019
Rollup of 22 pull requests
Successful merges:
- #62084 (allow clippy::unreadable_literal in unicode tables)
- #62120 (Add missing type links in documentation)
- #62310 (Add missing doc links in boxed module)
- #62421 (Introduce `as_deref` to Option)
- #62583 (Implement Unpin for all raw pointers)
- #62692 (rustc: precompute the largest Niche and store it in LayoutDetails.)
- #62801 (Remove support for -Zlower-128bit-ops)
- #62828 (Remove vector fadd/fmul reduction workarounds)
- #62862 (code cleanup)
- #62904 (Disable d32 on armv6 hf targets)
- #62907 (Initialize the MSP430 AsmParser)
- #62956 (Implement slow-path for FirstSets::first)
- #62963 (Allow lexer to recover from some homoglyphs)
- #62964 (clarify and unify some type test names)
- #62970 (ci: gate toolstate repo pushes on the TOOLSTATE_PUBLISH envvar)
- #62980 (std: Add more accessors for `Metadata` on Windows)
- #62983 (Remove needless indirection through Rc)
- #62985 (librustc_errors: Support ui-testing flag in annotate-snippet emitter)
- #63002 (error_index_generator should output stdout/stderr when it panics.)
- #63004 (Add test for issue-54062)
- #63007 (ci: debug network failures while downloading awscli from PyPI)
- #63009 (Remove redundant `mut` from variable declaration.)
Failed merges:
r? @ghost
@bors
bors merged commit 6fae7db into rust-lang:masterJul 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nikic@rust-highfive@gnzlbg@eddyb@bors