Skip to content

bump crossbeam-epoch dependency - #62974

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:crossbeam
Jul 28, 2019
Merged

bump crossbeam-epoch dependency#62974
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:crossbeam

Conversation

@RalfJung

@RalfJungRalfJung commented Jul 25, 2019

Copy link
Copy Markdown
Member

The new crossbeam-epoch release depends on a memoffset with a whole bunch of soundness holes fixed.

The old memoffset is still indirectly depended on (at least) by rustc-rayon, though -- a crate that looks rather unmaintained (no change in more than a year).

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2019
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jul 25, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit c7a599e has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2019
@RalfJung

Copy link
Copy Markdown
MemberAuthor

@alexcrichton do you know about the rustc-rayon situation? It looks like an ancient version of rayon, and is responsible for pulling in ancient versions of other stuff, including crossbeam.

@alexcrichton

Copy link
Copy Markdown
Member

I do not myself, no, but @Zoxc would likely know more

@Zoxc

Zoxc commented Jul 25, 2019

Copy link
Copy Markdown
Contributor

rustc-rayon was last updated in April, and is based on rayon master from January. There isn't really much incentive to update it since rayon is pretty stable and it isn't used by default in the compiler.

@RalfJung

RalfJung commented Jul 25, 2019

Copy link
Copy Markdown
MemberAuthor

@Zoxc oh, I was looking at the repo https://github.com/rust-lang/rustc-rayon which has not been changed since forever (at least its default branch, which I would expect to be the basis for the releases as that's where crates.io links). Seems like crates.io and that repo got out-of-sync?

There isn't really much incentive to update it since rayon is pretty stable and it isn't used by default in the compiler.

Now there is the incentive to get the broken old memoffset out of our dependency tree. With cargo treenot working I cannot even tell if there is anything else besides rustc-rayon that pulls this in.

@Zoxc

Zoxc commented Jul 25, 2019

Copy link
Copy Markdown
Contributor

@Zoxc oh, I was looking at the repo https://github.com/rust-lang/rustc-rayon which has not been changed since forever (at least its default branch, which I would expect to be the basis for the releases as that's where crates.io links). Seems like crates.io and that repo got out-of-sync?

No, the default branch is the latest there. github doesn't display when it was last changed though.

@RalfJung

Copy link
Copy Markdown
MemberAuthor

It says "Latest commit 4b574ba on Apr 25, 2018 ", am I misinterpreting that?

@mati865

mati865 commented Jul 26, 2019

Copy link
Copy Markdown
Member

@RalfJung open Commits tab and check push date.

@RalfJung

Copy link
Copy Markdown
MemberAuthor

@mati865 thanks! I didn't even know that this is the push date GH shows there, but it makes sense now. :)

Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
bump crossbeam-epoch dependency
The new crossbeam-epoch release depends on a memoffset with a whole bunch of soundness holes fixed.
The old memoffset is still indirectly depended on (at least) by rustc-rayon, though -- a crate that looks rather unmaintained (no change in more than a year).
@CentrilCentril mentioned this pull request Jul 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
bump crossbeam-epoch dependency
The new crossbeam-epoch release depends on a memoffset with a whole bunch of soundness holes fixed.
The old memoffset is still indirectly depended on (at least) by rustc-rayon, though -- a crate that looks rather unmaintained (no change in more than a year).
@CentrilCentril mentioned this pull request Jul 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 28, 2019
bump crossbeam-epoch dependency
The new crossbeam-epoch release depends on a memoffset with a whole bunch of soundness holes fixed.
The old memoffset is still indirectly depended on (at least) by rustc-rayon, though -- a crate that looks rather unmaintained (no change in more than a year).
@CentrilCentril mentioned this pull request Jul 28, 2019
bors added a commit that referenced this pull request Jul 28, 2019
Rollup of 4 pull requests
Successful merges:
- #62550 (Implement RFC 2707 + Parser recovery for range patterns)
- #62759 (Actually add rustc-guide to toolstate, don't fail builds for the guide)
- #62809 (rustc: Update wasm32 support for LLVM 9)
- #62974 (bump crossbeam-epoch dependency)
Failed merges:
r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 28, 2019
bump crossbeam-epoch dependency
The new crossbeam-epoch release depends on a memoffset with a whole bunch of soundness holes fixed.
The old memoffset is still indirectly depended on (at least) by rustc-rayon, though -- a crate that looks rather unmaintained (no change in more than a year).
@CentrilCentril mentioned this pull request Jul 28, 2019
bors added a commit that referenced this pull request Jul 28, 2019
Rollup of 8 pull requests
Successful merges:
- #62550 (Implement RFC 2707 + Parser recovery for range patterns)
- #62759 (Actually add rustc-guide to toolstate, don't fail builds for the guide)
- #62806 (Fix few Clippy warnings)
- #62974 (bump crossbeam-epoch dependency)
- #63051 (Avoid ICE when referencing desugared local binding in borrow error)
- #63061 (In which we constantly improve the Vec(Deque) array PartialEq impls)
- #63067 (Add test for issue-50900)
- #63071 (Allow rustbot to add `F-*` + `requires-nightly`.)
Failed merges:
r? @ghost
@bors
bors merged commit c7a599e into rust-lang:masterJul 28, 2019
@RalfJung
RalfJung deleted the crossbeam branch July 29, 2019 08:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@RalfJung@rust-highfive@alexcrichton@bors@Zoxc@mati865