Uh oh!
There was an error while loading. Please reload this page.
Make "see issue" consistent - #63008
Conversation
rust-highfive
commented
Jul 26, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Jul 26, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
ghost
left a comment
There was a problem hiding this comment.
there are some more inconsistencies that should be fixed (at least some of them):
See issue #49146 <https://github.com/rust-lang/rust/issues/49146> \
for more information.", kind),
for more information, see issue \
#57563 <https://github.com/rust-lang/rust/issues/57563>");
see issue #43162 <https://github.com/rust-lang/rust/issues/43162#issuecomment-320764675>"
please see issue #44136 <https://github.com/rust-lang/rust/issues/44136>
for more context, see issue #60210 <https://github.com/rust-lang/rust/issues/60210>
see issue #46062 <https://github.com/rust-lang/rust/issues/46062>for more details
I think, the order should be consistent, as well as the inclusion of "for more information/details"
eupn
commented
Jul 28, 2019
I should've made this consistent as well. In this PR, I was only concerned about the consistency of Github links to the issues. |
shepmaster
commented
Jul 28, 2019
r? @varkor |
varkor
commented
Jul 28, 2019
I'll review this soon. However, I feel slightly uncomfortable, because @punitkoura had asked to take this issue. It would be a shame to waste this effort, though. If @punitkoura is happy with it, perhaps we could go with this pull request, but @punitkoura can be added as a co-author for doing the initial work? Then I can direct @punitkoura to another easy starter issue. |
bors
commented
Jul 29, 2019
☔ The latest upstream changes (presumably #63094) made this pull request unmergeable. Please resolve the merge conflicts. |
punitkoura
commented
Jul 29, 2019
Hi @varkor, these changes look good to me. I was also working on the same, but then saw this PR and therefore didn't raise another PR. It'd be really nice if I could be added as a co-author though :) |
rust-highfive
commented
Jul 29, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
varkor
commented
Jul 29, 2019
It'd be nice to normalise the following strings that appear:
I personally prefer "see [...] for more information", as it has the link early on. Apart from that, this looks good. If you could squash the |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
eupn
commented
Jul 30, 2019
@punitkoura don't you mind if I'll use your email |
bors
commented
Jul 30, 2019
☔ The latest upstream changes (presumably #63124) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-highfive
commented
Jul 30, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
punitkoura
commented
Jul 30, 2019
@eupn, yes, that email id works |
bors
commented
Jul 31, 2019
☔ The latest upstream changes (presumably #63148) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-highfive
commented
Jul 31, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
eupn
commented
Jul 31, 2019
varkor
commented
Jul 31, 2019
Thanks! @bors r+ |
bors
commented
Jul 31, 2019
📌 Commit 7336626 has been approved by |
Make "see issue" consistent Fixesrust-lang#62976. h/t to @punitkoura for initial patterns search. r? @varkor
eupn
commented
Aug 1, 2019
Centril
commented
Aug 1, 2019
@bors r+ |
bors
commented
Aug 1, 2019
📌 Commit 2ae06197c97b63466f7854421b8f9f61dd9fb2d2 has been approved by |
bors
commented
Aug 3, 2019
☔ The latest upstream changes (presumably #63180) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
commented
Aug 4, 2019
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
Co-authored-by: eupn <eupn@protonmail.com> Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>
rust-highfive
commented
Aug 8, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Co-authored-by: eupn <eupn@protonmail.com> Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>
Co-Authored-By: varkor <github@varkor.com>
rust-highfive
commented
Aug 9, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Mark-Simulacrum
commented
Aug 10, 2019
@bors p=1 since this is pretty conflict-prone |
varkor
commented
Aug 11, 2019
@eupn: there have been more merge conflicts, so you'll need to rebase and force push again. |
bors
commented
Aug 16, 2019
☔ The latest upstream changes (presumably #63627) made this pull request unmergeable. Please resolve the merge conflicts. |
wirelessringo
commented
Aug 23, 2019
Ping from triage. @eupn any updates on this? Thanks. |
eupn
commented
Aug 23, 2019
I’ll rebase it soon! |
JohnTitor
commented
Sep 1, 2019
Ping from triage: @eupn any updates on this? |
1 similar comment
JohnTitor
commented
Sep 8, 2019
Ping from triage: @eupn any updates on this? |
joelpalmer
commented
Sep 16, 2019
Ping from Triage: closing due to inactivity. Thanks for the PR @eupn! If you do rebase and have updates, please re-open. |
…, r=Dylan-DPC Make issue references consistent Fixesrust-lang#62976 cc rust-lang#63008 r? @varkor because you reviewed the original pr
Fixes#62976. h/t to @punitkoura for initial patterns search.
r? @varkor