Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #63182
Closed
Centril wants to merge 29 commits into
Closed
Conversation
The std::io::Write::write method currensly suggests consumers guaranteed that `0 <= n <= buf.len()`, for `Ok(n)`, however `n` is of type `usize` causing the compiler to emit a warning: ``` warning: comparison is useless due to type limits --> lib.rs:6:18 | 6 | Ok(n) => 0 <= n && n <= output.len(), | ^^^^^^ | = note: #[warn(unused_comparisons)] on by default ``` This PR removes the suggestion to check `0 <= n` since it is moot. r? @steveklabnik
There is no difference in the code/arguments, so go with the shorter name throughout the code.
MetaItem.span was always equivalent
Always the same as the passed MetaItem
simplify std::io::Write::write rustdoc The std::io::Write::write method currensly suggests consumers guaranteed that `0 <= n <= buf.len()`, for `Ok(n)`, however `n` is of type `usize` causing the compiler to emit a warning: ``` warning: comparison is useless due to type limits --> lib.rs:6:18 | 6 | Ok(n) => 0 <= n && n <= output.len(), | ^^^^^^ | = note: #[warn(unused_comparisons)] on by default ``` This PR removes the suggestion to check `0 <= n` since it is moot. r? @steveklabnik
…obody Add keywords item into the sidebar Fixesrust-lang#62939. cc @pravic screenshot of the result:  r? @QuietMisdreavus
…ewjasper Make `#![feature(bind_by_move_pattern_guards)]` sound without `#[feature(nll)]` Implements rust-lang#15287 (comment) making `#![feature(bind_by_move_pattern_guards)]]` sound without also having `#![feature(nll)]`. The logic here is that if we see a `match` guard, we will refuse to downgrade NLL errors to warnings. This is in preparation for hopefully stabilizing the former feature in rust-lang#63118. As fall out from the implementation we also: Fixesrust-lang#31287Fixesrust-lang#27282 r? @matthewjasper
Account for `maybe_whole_expr` in range patterns Fixesrust-lang#63115 (fallout from rust-lang#62550). r? @petrochenkov
…chenkov Cleanup syntax::attr Mostly removing needless arguments to constructors r? @petrochenkov
…cramertj Remove redundant method with const variable resolution I've also removed a `bug!()` in const value relation code and replaced it with a `FIXME`. Now `ConstValue::Slice` and `ConstValue::ByRef` will simply fail to unify rather than ICEing, which seems more user-friendly for testers.
cleanup StringReader fields reduce visibility and replace `Lrc<SourceFile>` with `start_pos`: the single bit we actually *need* from the file. r? @petrochenkov
Centril
commented
Aug 1, 2019
ContributorAuthor
@bors r+ p=7 rollup=never |
bors
commented
Aug 1, 2019
Collaborator
📌 Commit 6905d72 has been approved by |
Centril
commented
Aug 1, 2019
ContributorAuthor
@bors r+ p=7 rollup=never |
bors
commented
Aug 1, 2019
Collaborator
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Aug 1, 2019
Collaborator
📌 Commit 6905d72 has been approved by |
bors
commented
Aug 1, 2019
Collaborator
⌛ Testing commit 6905d72 with merge e6bb16fa33e552ff10f32c4ab23571264061c3ea... |
bors
commented
Aug 1, 2019
Collaborator
💔 Test failed - checks-azure |
rust-highfive
commented
Aug 1, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#![feature(bind_by_move_pattern_guards)]sound without#[feature(nll)]#63059 (Make#![feature(bind_by_move_pattern_guards)]sound without#[feature(nll)])maybe_whole_exprin range patterns #63122 (Account formaybe_whole_exprin range patterns)Failed merges:
r? @ghost