Skip to content

Allow trailing comma in macro 2.0 declarations. - #63198

Merged
bors merged 2 commits into
rust-lang:masterfrom
rbartlensky:fix-macro-trailing-comma
Aug 2, 2019
Merged

Allow trailing comma in macro 2.0 declarations.#63198
bors merged 2 commits into
rust-lang:masterfrom
rbartlensky:fix-macro-trailing-comma

Conversation

@rbartlensky

@rbartlenskyrbartlensky commented Aug 1, 2019

Copy link
Copy Markdown
Contributor

This should hopefully close#63102.

@rust-highfive

rust-highfive commented Aug 1, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2019
@petrochenkov

petrochenkov commented Aug 1, 2019

Copy link
Copy Markdown
Contributor

Could you add a // check-pass test into src/test/ui/macros making sure that this works?

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2019
@rbartlensky

rbartlensky commented Aug 1, 2019

Copy link
Copy Markdown
ContributorAuthor

@petrochenkov Pushed a commit which adds a test. Let me know if I need to add anything else to it!

@petrochenkov

petrochenkov commented Aug 2, 2019

Copy link
Copy Markdown
Contributor

Everything looks good, thanks!
@bors r+ rollup

@bors

bors commented Aug 2, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 2aa368a has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 2, 2019
@Centril
Rollup merge ofrust-lang#63198- rbartlensky:fix-macro-trailing-comm…
89dce46
…a, r=petrochenkov
Allow trailing comma in macro 2.0 declarations.
This should hopefully closerust-lang#63102.
@CentrilCentril mentioned this pull request Aug 2, 2019
Merged
bors added a commit that referenced this pull request Aug 2, 2019
@bors
Auto merge of#63214- Centril:rollup-hdb7dnx, r=Centril
1df512f
Rollup of 7 pull requests
Successful merges:
- #62663 (More questionmarks in doctests)
- #62969 (Changing the structure of `mir::interpret::InterpError`)
- #63153 (Remove redundant method with const variable resolution)
- #63189 (Doc improvements)
- #63198 (Allow trailing comma in macro 2.0 declarations.)
- #63202 (Fix ICE in #63135)
- #63203 (Make is_mutable use PlaceRef instead of it's fields)
Failed merges:
r? @ghost
@bors
bors merged commit 2aa368a into rust-lang:masterAug 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

decl macro 2.0 doesn't allow trailing comma

4 participants

@rbartlensky@rust-highfive@petrochenkov@bors