Uh oh!
There was an error while loading. Please reload this page.
Fix rustc-guide toolstate tracking. - #63199
Merged
Merged
Conversation
bors
commented
Aug 3, 2019
Collaborator
☔ The latest upstream changes (presumably #63228) made this pull request unmergeable. Please resolve the merge conflicts. |
ehussforce-pushed
the
fix-rustc-guide-toolstate
branch
from
August 3, 2019 04:28
63c1f17 to
2da89deComparekennytm
commented
Aug 3, 2019
Member
@bors r+ |
bors
commented
Aug 3, 2019
Collaborator
📌 Commit 2da89de has been approved by |
bors
commented
Aug 4, 2019
Collaborator
bors added a commit
that referenced
this pull request
Aug 4, 2019
Fix rustc-guide toolstate tracking. The rustc-guide is still not saving its toolstate. It needs to be done explicitly. Note: There are some confusing bits here, like without `--no-fail-fast`, it saves the wrong value in `toolstates.json`. Also, "rustbook" is always added as "test-fail". Presumably [this code](https://github.com/rust-lang/rust/blame/63c1f17d950bfefc8f356777f124f304f0575c76/src/bootstrap/tool.rs#L201-L205) assumes everything fails until it passes tests, which is a bit confusing for things that don't run tests. cc @mark-i-m
bors
commented
Aug 4, 2019
Collaborator
☀️ Test successful - checks-azure |
rust-highfive
commented
Aug 4, 2019
Contributor
📣 Toolstate changed by #63199! Tested on commit 2c13edc. 💔 rustc-guide on linux: test-pass → test-fail (cc @mark-i-m@spastorino, @rust-lang/infra). |
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 4, 2019
Tested on commit rust-lang/rust@2c13edc. Direct link to PR: <rust-lang/rust#63199> 💔 rustc-guide on linux: test-pass → test-fail (cc @mark-i-m@spastorino, @rust-lang/infra).
RalfJung
commented
Aug 6, 2019
Member
Is it expected that tests still fail, but only on Linux? |
ehuss
commented
Aug 6, 2019
ContributorAuthor
@RalfJung Yes, it currently only runs on one job. See #62950 (comment) for an explanation. |
mark-i-m
commented
Aug 6, 2019
Contributor
Thanks @ehuss! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rustc-guide is still not saving its toolstate. It needs to be done explicitly.
Note: There are some confusing bits here, like without
--no-fail-fast, it saves the wrong value intoolstates.json. Also, "rustbook" is always added as "test-fail". Presumably this code assumes everything fails until it passes tests, which is a bit confusing for things that don't run tests.cc @mark-i-m