Uh oh!
There was an error while loading. Please reload this page.
Rollup of 3 pull requests - #63200
Closed
Centril wants to merge 25 commits into
Closed
Conversation
There is no difference in the code/arguments, so go with the shorter name throughout the code.
MetaItem.span was always equivalent
Always the same as the passed MetaItem
…en dispatching further; call ptr_op machine hook only for pointer types
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
…r=oli-obk Miri: dispatch first on the type Based on the fact that Miri now always has intptrcast available, we can change binops and casts to first check the type of the source operand and then decide based on that what to do, instead of considering the value (pointer vs bits) first.
…chenkov Cleanup syntax::attr Mostly removing needless arguments to constructors r? @petrochenkov
…cramertj Remove redundant method with const variable resolution I've also removed a `bug!()` in const value relation code and replaced it with a `FIXME`. Now `ConstValue::Slice` and `ConstValue::ByRef` will simply fail to unify rather than ICEing, which seems more user-friendly for testers.
Centril
commented
Aug 1, 2019
ContributorAuthor
@bors r+ p=3 rollup=never |
bors
commented
Aug 1, 2019
Collaborator
📌 Commit 3faef22 has been approved by |
bors
commented
Aug 2, 2019
Collaborator
⌛ Testing commit 3faef22 with merge 702e3d08069f813159813fe3ac87974e1f4ed7c2... |
bors
commented
Aug 2, 2019
Collaborator
💥 Test timed out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
mir::interpret::InterpError#62969 (Changing the structure ofmir::interpret::InterpError)r? @ghost