WIP: Fix test style in unused parentheses lint test by monoflo · Pull Request #63257 · rust-lang/rust

monoflo · 2019-08-04T12:17:51Z

Hi! This is my first attempt at a pull request for the Rust project.

I'm fairly certain that I did this wrong, so I'm open to any and all feedback!

Per the issue, I was unable to find test/lint/used_parens_remove_json_suggestion.rs. Is this a file I should create?

Issue

rust-highfive · 2019-08-04T12:18:01Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jonas-schievink · 2019-08-04T13:10:43Z

Per the issue, I was unable to find test/lint/used_parens_remove_json_suggestion.rs. Is this a file I should create?

I think the issue was just confusing the name of the file. According to a quick ripgrep, the other test using the pretty-json directive is src/test/ui/lint/use_suggestion_json.rs.

rust-highfive · 2019-08-04T13:31:05Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-08-04T12:18:21.5130765Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-04T12:18:21.5308987Z ##[command]git config gc.auto 0
2019-08-04T12:18:21.5379898Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-04T12:18:21.5437791Z ##[command]git config --get-all http.proxy
2019-08-04T12:18:21.5566227Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63257/merge:refs/remotes/pull/63257/merge
---
2019-08-04T12:18:55.3577944Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-04T12:18:55.3578157Z 2019-08-04T12:18:55.3578408Z git checkout -b <new-branch-name>
2019-08-04T12:18:55.3578438Z 2019-08-04T12:18:55.3578503Z HEAD is now at 10d3f7ced Merge d13738b02758399e2728a1c56a784e376e58d68b into 5170a3f45af6a7a2a2e46a115daca8f31379b3a8
2019-08-04T12:18:55.3730701Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-04T12:18:55.3733409Z ==============================================================================
2019-08-04T12:18:55.3733469Z Task : Bash
2019-08-04T12:18:55.3733529Z Description : Run a Bash script on macOS, Linux, or Windows
---
2019-08-04T13:20:00.7249277Z .................................................................................................... 1400/8827
2019-08-04T13:20:06.5368431Z .................................................................................................... 1500/8827
2019-08-04T13:20:19.0378767Z ....................................................................i...............i............... 1600/8827
2019-08-04T13:20:26.2603324Z .................................................................................................... 1700/8827
2019-08-04T13:20:41.6373779Z ......................................................iiiii......................................... 1800/8827
2019-08-04T13:20:53.1913324Z .................................................................................................... 2000/8827
2019-08-04T13:20:55.7341246Z .................................................................................................... 2100/8827
2019-08-04T13:20:59.0364305Z .................................................................................................... 2200/8827
2019-08-04T13:21:06.8321897Z .................................................................................................... 2300/8827
---
2019-08-04T13:24:54.4677210Z .......................................................F............................................ 5200/8827
2019-08-04T13:25:02.7356745Z .....................................................................i.............................. 5300/8827
2019-08-04T13:25:10.0780197Z .................................................................................................... 5400/8827
2019-08-04T13:25:17.0457697Z .................................................................................................... 5500/8827
2019-08-04T13:25:28.3045229Z ...............................................................ii...i..ii...........i............... 5600/8827
2019-08-04T13:25:53.3638498Z .................................................................................................... 5800/8827
2019-08-04T13:25:58.4117952Z .................................................................................................... 5900/8827
2019-08-04T13:25:58.4117952Z .................................................................................................... 5900/8827
2019-08-04T13:26:04.5413549Z ................................................................i..ii............................... 6000/8827
2019-08-04T13:26:33.6320889Z .................................................................................................... 6200/8827
2019-08-04T13:26:35.7830523Z .......i............................................................................................ 6300/8827
2019-08-04T13:26:37.9430282Z ...............................................................................i.................... 6400/8827
2019-08-04T13:26:40.5971123Z .................................................................................................... 6500/8827
---
2019-08-04T13:30:42.0438262Z failures:
2019-08-04T13:30:42.0465379Z 2019-08-04T13:30:42.0466249Z ---- [ui] ui/lint/unused_parens_json_suggestion.rs stdout ----
2019-08-04T13:30:42.0466461Z 2019-08-04T13:30:42.0466879Z error: test compilation failed although it shouldn't!
2019-08-04T13:30:42.0467114Z status: exit code: 1
2019-08-04T13:30:42.0468246Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/unused_parens_json_suggestion.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused_parens_json_suggestion" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--error-format" "-Zunstable-options" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused_parens_json_suggestion/auxiliary" "-A" "unused"
2019-08-04T13:30:42.0469092Z ------------------------------------------
2019-08-04T13:30:42.0469301Z 2019-08-04T13:30:42.0469693Z ------------------------------------------
2019-08-04T13:30:42.0470012Z stderr:
2019-08-04T13:30:42.0470012Z stderr:
2019-08-04T13:30:42.0470479Z ------------------------------------------
2019-08-04T13:30:42.0470896Z error: argument for --error-format must be `human`, `json` or `short` (instead was `-Zunstable-options`)
2019-08-04T13:30:42.0471205Z 2019-08-04T13:30:42.0471535Z ------------------------------------------
2019-08-04T13:30:42.0471697Z 2019-08-04T13:30:42.0471815Z ---
2019-08-04T13:30:42.0521173Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-08-04T13:30:42.0521487Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-08-04T13:30:42.0548330Z 2019-08-04T13:30:42.0548858Z 2019-08-04T13:30:42.0554363Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-08-04T13:30:42.0555040Z 2019-08-04T13:30:42.0555079Z 2019-08-04T13:30:42.0566785Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-04T13:30:42.0567122Z Build completed unsuccessfully in 1:05:30
2019-08-04T13:30:42.0567122Z Build completed unsuccessfully in 1:05:30
2019-08-04T13:30:42.8436422Z ##[error]Bash exited with code '1'.
2019-08-04T13:30:42.8478864Z ##[section]Starting: Checkout
2019-08-04T13:30:42.8480717Z ==============================================================================
2019-08-04T13:30:42.8480768Z Task : Get sources
2019-08-04T13:30:42.8480814Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-08-04T16:31:21Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-08-04T15:22:42.4190334Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-04T15:22:42.4386280Z ##[command]git config gc.auto 0
2019-08-04T15:22:42.4807214Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-04T15:22:42.4861333Z ##[command]git config --get-all http.proxy
2019-08-04T15:22:42.4991847Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63257/merge:refs/remotes/pull/63257/merge
---
2019-08-04T15:23:14.0117523Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-04T15:23:14.0118225Z 2019-08-04T15:23:14.0118730Z git checkout -b <new-branch-name>
2019-08-04T15:23:14.0118992Z 2019-08-04T15:23:14.0119228Z HEAD is now at 480f1d298 Merge 3c9789bf06bb01707d6b1a5589e4ce43234468d9 into 460072ebeed5a2463109894592ac172b47cdfb74
2019-08-04T15:23:14.0259094Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-04T15:23:14.0261485Z ==============================================================================
2019-08-04T15:23:14.0261545Z Task : Bash
2019-08-04T15:23:14.0261586Z Description : Run a Bash script on macOS, Linux, or Windows
---
2019-08-04T16:20:47.9491946Z .................................................................................................... 1400/8827
2019-08-04T16:20:53.5800538Z .................................................................................................... 1500/8827
2019-08-04T16:21:05.2319702Z ....................................................................i...............i............... 1600/8827
2019-08-04T16:21:11.9679237Z .................................................................................................... 1700/8827
2019-08-04T16:21:26.5115104Z ......................................................iiiii......................................... 1800/8827
2019-08-04T16:21:37.2627059Z .................................................................................................... 2000/8827
2019-08-04T16:21:39.6258488Z .................................................................................................... 2100/8827
2019-08-04T16:21:42.8028219Z .................................................................................................... 2200/8827
2019-08-04T16:21:50.2276757Z .................................................................................................... 2300/8827
---
2019-08-04T16:25:25.9490272Z .......................................................F.F.......................................... 5200/8827
2019-08-04T16:25:34.0543919Z .....................................................................i.............................. 5300/8827
2019-08-04T16:25:41.1822423Z .................................................................................................... 5400/8827
2019-08-04T16:25:47.9174497Z .................................................................................................... 5500/8827
2019-08-04T16:25:58.8019927Z ...............................................................ii...i..ii...........i............... 5600/8827
2019-08-04T16:26:20.0604497Z .................................................................................................... 5800/8827
2019-08-04T16:26:24.9113914Z .................................................................................................... 5900/8827
2019-08-04T16:26:24.9113914Z .................................................................................................... 5900/8827
2019-08-04T16:26:30.7194694Z ................................................................i..ii............................... 6000/8827
2019-08-04T16:26:58.3654756Z .................................................................................................... 6200/8827
2019-08-04T16:27:00.4803297Z .......i............................................................................................ 6300/8827
2019-08-04T16:27:02.5002785Z ...............................................................................i.................... 6400/8827
2019-08-04T16:27:05.0578391Z .................................................................................................... 6500/8827
---
2019-08-04T16:30:58.2337469Z 2019-08-04T16:30:58.2338325Z ---- [ui] ui/lint/unused_parens_json_suggestion.rs stdout ----
2019-08-04T16:30:58.2338419Z diff of stderr:
2019-08-04T16:30:58.2338480Z 2019-08-04T16:30:58.2338735Z - {
2019-08-04T16:30:58.2338984Z - "message": "unnecessary parentheses around assigned value",
2019-08-04T16:30:58.2339202Z - "code": {
2019-08-04T16:30:58.2339416Z - "code": "unused_parens",
2019-08-04T16:30:58.2339617Z - "explanation": null
2019-08-04T16:30:58.2339800Z - },
2019-08-04T16:30:58.2340021Z - "level": "warning",
2019-08-04T16:30:58.2340229Z - "spans": [
2019-08-04T16:30:58.2340414Z - {
2019-08-04T16:30:58.2342377Z - "file_name": "$DIR/unused_parens_json_suggestion.rs",
2019-08-04T16:30:58.2342747Z - "byte_start": 611,
2019-08-04T16:30:58.2343531Z - "byte_end": 624,
2019-08-04T16:30:58.2343746Z - "line_start": 15,
2019-08-04T16:30:58.2343981Z - "line_end": 15,
2019-08-04T16:30:58.2344190Z - "column_start": 14,
2019-08-04T16:30:58.2345719Z - "column_end": 27,
2019-08-04T16:30:58.2345977Z - "is_primary": true,
2019-08-04T16:30:58.2346180Z - "text": [
2019-08-04T16:30:58.2346377Z - {
2019-08-04T16:30:58.2346651Z - "text": " let _a = (1 / (2 + 3));",
2019-08-04T16:30:58.2346882Z - "highlight_start": 14,
2019-08-04T16:30:58.2347103Z - "highlight_end": 27
2019-08-04T16:30:58.2347513Z - ],
2019-08-04T16:30:58.2347718Z - "label": null,
2019-08-04T16:30:58.2348353Z - "suggested_replacement": null,
2019-08-04T16:30:58.2348664Z - "suggestion_applicability": null,
2019-08-04T16:30:58.2348664Z - "suggestion_applicability": null,
2019-08-04T16:30:58.2348876Z - "expansion": null
2019-08-04T16:30:58.2349068Z - }
2019-08-04T16:30:58.2349274Z - ],
2019-08-04T16:30:58.2349476Z - "children": [
2019-08-04T16:30:58.2349895Z - "message": "lint level defined here",
2019-08-04T16:30:58.2350123Z - "code": null,
2019-08-04T16:30:58.2350332Z - "level": "note",
2019-08-04T16:30:58.2350533Z - "spans": [
2019-08-04T16:30:58.2350533Z - "spans": [
2019-08-04T16:30:58.2350870Z - {
2019-08-04T16:30:58.2351277Z - "file_name": "$DIR/unused_parens_json_suggestion.rs",
2019-08-04T16:30:58.2351540Z - "byte_start": 457,
2019-08-04T16:30:58.2351769Z - "byte_end": 470,
2019-08-04T16:30:58.2351978Z - "line_start": 10,
2019-08-04T16:30:58.2352182Z - "line_end": 10,
2019-08-04T16:30:58.2352388Z - "column_start": 9,
2019-08-04T16:30:58.2352613Z - "column_end": 22,
2019-08-04T16:30:58.2353470Z - "is_primary": true,
2019-08-04T16:30:58.2353727Z - "text": [
2019-08-04T16:30:58.2353951Z - {
2019-08-04T16:30:58.2354189Z - "text": "#![warn(unused_parens)]",
2019-08-04T16:30:58.2354414Z - "highlight_start": 9,
2019-08-04T16:30:58.2354651Z - "highlight_end": 22
2019-08-04T16:30:58.2355051Z - ],
2019-08-04T16:30:58.2355260Z - "label": null,
2019-08-04T16:30:58.2355505Z - "suggested_replacement": null,
2019-08-04T16:30:58.2355735Z - "suggestion_applicability": null,
2019-08-04T16:30:58.2355735Z - "suggestion_applicability": null,
2019-08-04T16:30:58.2355961Z - "expansion": null
2019-08-04T16:30:58.2356179Z - }
2019-08-04T16:30:58.2356494Z - ],
2019-08-04T16:30:58.2356691Z - "children": [],
2019-08-04T16:30:58.2356905Z - "rendered": null
2019-08-04T16:30:58.2357275Z - {
2019-08-04T16:30:58.2357275Z - {
2019-08-04T16:30:58.2357494Z - "message": "remove these parentheses",
2019-08-04T16:30:58.2357907Z - "code": null,
2019-08-04T16:30:58.2358106Z - "level": "help",
2019-08-04T16:30:58.2358299Z - "spans": [
2019-08-04T16:30:58.2358507Z - {
2019-08-04T16:30:58.2358744Z - "file_name": "$DIR/unused_parens_json_suggestion.rs",
2019-08-04T16:30:58.2358956Z - "byte_start": 611,
2019-08-04T16:30:58.2359178Z - "byte_end": 624,
2019-08-04T16:30:58.2359387Z - "line_start": 15,
2019-08-04T16:30:58.2359589Z - "line_end": 15,
2019-08-04T16:30:58.2359795Z - "column_start": 14,
2019-08-04T16:30:58.2360032Z - "column_end": 27,
2019-08-04T16:30:58.2360240Z - "is_primary": true,
2019-08-04T16:30:58.2360437Z - "text": [
2019-08-04T16:30:58.2360650Z - {
2019-08-04T16:30:58.2360879Z - "text": " let _a = (1 / (2 + 3));",
2019-08-04T16:30:58.2361098Z - "highlight_start": 14,
2019-08-04T16:30:58.2361329Z - "highlight_end": 27
2019-08-04T16:30:58.2361726Z - ],
2019-08-04T16:30:58.2361926Z - "label": null,
2019-08-04T16:30:58.2361926Z - "label": null,
2019-08-04T16:30:58.2362172Z - "suggested_replacement": "1 / (2 + 3)",
2019-08-04T16:30:58.2362408Z - "suggestion_applicability": "MachineApplicable",
2019-08-04T16:30:58.2363239Z - "expansion": null
2019-08-04T16:30:58.2363663Z - ],
2019-08-04T16:30:58.2363663Z - ],
2019-08-04T16:30:58.2363866Z - "children": [],
2019-08-04T16:30:58.2364088Z - "rendered": null
2019-08-04T16:30:58.2364467Z - ],
2019-08-04T16:30:58.2364467Z - ],
2019-08-04T16:30:58.2364726Z - "rendered": "warning: unnecessary parentheses around assigned value
2019-08-04T16:30:58.2365184Z - |
2019-08-04T16:30:58.2365184Z - |
2019-08-04T16:30:58.2365400Z - LL | let _a = (1 / (2 + 3));
2019-08-04T16:30:58.2365663Z - | ^^^^^^^^^^^^^ help: remove these parentheses
2019-08-04T16:30:58.2366077Z - note: lint level defined here
2019-08-04T16:30:58.2366571Z - --> $DIR/unused_parens_json_suggestion.rs:10:9
2019-08-04T16:30:58.2366764Z - |
2019-08-04T16:30:58.2366764Z - |
2019-08-04T16:30:58.2366975Z - LL | #![warn(unused_parens)]
2019-08-04T16:30:58.2367185Z - | ^^^^^^^^^^^^^
2019-08-04T16:30:58.2367491Z + error: argument for --error-format must be `human`, `json` or `short` (instead was `-Zunstable-options`)
2019-08-04T16:30:58.2367757Z - "
2019-08-04T16:30:58.2367944Z - }
2019-08-04T16:30:58.2367986Z 107 2019-08-04T16:30:58.2368015Z 2019-08-04T16:30:58.2368015Z 2019-08-04T16:30:58.2368147Z 2019-08-04T16:30:58.2368219Z The actual stderr differed from the expected stderr.
2019-08-04T16:30:58.2369683Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused_parens_json_suggestion/unused_parens_json_suggestion.stderr
2019-08-04T16:30:58.2370134Z To update references, rerun the tests and pass the `--bless` flag
2019-08-04T16:30:58.2370463Z To only update this specific test, also pass `--test-args lint/unused_parens_json_suggestion.rs`
2019-08-04T16:30:58.2370546Z error: 1 errors occurred comparing output.
2019-08-04T16:30:58.2370607Z status: exit code: 1
2019-08-04T16:30:58.2370607Z status: exit code: 1
2019-08-04T16:30:58.2371394Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/unused_parens_json_suggestion.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused_parens_json_suggestion" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--error-format" "-Zunstable-options" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused_parens_json_suggestion/auxiliary" "-A" "unused"
2019-08-04T16:30:58.2371741Z ------------------------------------------
2019-08-04T16:30:58.2371893Z 2019-08-04T16:30:58.2372174Z ------------------------------------------
2019-08-04T16:30:58.2372219Z stderr:
2019-08-04T16:30:58.2372219Z stderr:
2019-08-04T16:30:58.2372440Z ------------------------------------------
2019-08-04T16:30:58.2373015Z error: argument for --error-format must be `human`, `json` or `short` (instead was `-Zunstable-options`)
2019-08-04T16:30:58.2373093Z 2019-08-04T16:30:58.2373324Z ------------------------------------------
2019-08-04T16:30:58.2373372Z 2019-08-04T16:30:58.2373398Z 2019-08-04T16:30:58.2373398Z 2019-08-04T16:30:58.2373631Z ---- [ui] ui/lint/use_suggestion_json.rs stdout ----
2019-08-04T16:30:58.2373690Z diff of stderr:
2019-08-04T16:30:58.2373717Z 2019-08-04T16:30:58.2373922Z - {
2019-08-04T16:30:58.2374158Z - "message": "cannot find type `Iter` in this scope",
2019-08-04T16:30:58.2374359Z - "code": {
2019-08-04T16:30:58.2374587Z - "code": "E0412",
2019-08-04T16:30:58.2374792Z - "explanation": "
2019-08-04T16:30:58.2375012Z - The type name used is not in scope.
2019-08-04T16:30:58.2375342Z + error: argument for --error-format must be `human`, `json` or `short` (instead was `--json=diagnostic-rendered-ansi`)
2019-08-04T16:30:58.2375603Z - Erroneous code examples:
2019-08-04T16:30:58.2375804Z - 2019-08-04T16:30:58.2376011Z - ```compile_fail,E0412
2019-08-04T16:30:58.2376011Z - ```compile_fail,E0412
2019-08-04T16:30:58.2376260Z - impl Something {} // error: type name `Something` is not in scope
2019-08-04T16:30:58.2376449Z - 2019-08-04T16:30:58.2376661Z - // or:
2019-08-04T16:30:58.2377039Z - trait Foo {
2019-08-04T16:30:58.2377039Z - trait Foo {
2019-08-04T16:30:58.2377291Z - fn bar(N); // error: type name `N` is not in scope
2019-08-04T16:30:58.2377491Z - }
2019-08-04T16:30:58.2377800Z - 2019-08-04T16:30:58.2377983Z - // or:
2019-08-04T16:30:58.2378178Z - 2019-08-04T16:30:58.2378399Z - fn foo(x: T) {} // type name `T` is not in scope
2019-08-04T16:30:58.2378584Z - ```
2019-08-04T16:30:58.2378775Z - 2019-08-04T16:30:58.2379024Z - To fix this error, please verify you didn't misspell the type name, you did
2019-08-04T16:30:58.2379265Z - declare it or imported it into the scope. Examples:
2019-08-04T16:30:58.2379644Z - ```
2019-08-04T16:30:58.2379839Z - struct Something;
2019-08-04T16:30:58.2380017Z - 2019-08-04T16:30:58.2380017Z - 2019-08-04T16:30:58.2380235Z - impl Something {} // ok!
2019-08-04T16:30:58.2380412Z - 2019-08-04T16:30:58.2380594Z - // or:
2019-08-04T16:30:58.2380976Z - trait Foo {
2019-08-04T16:30:58.2381164Z - type N;
2019-08-04T16:30:58.2381342Z - 2019-08-04T16:30:58.2381342Z - 2019-08-04T16:30:58.2381566Z - fn bar(_: Self::N); // ok!
2019-08-04T16:30:58.2381749Z - }
2019-08-04T16:30:58.2381927Z - 2019-08-04T16:30:58.2382235Z - // or:
2019-08-04T16:30:58.2382453Z - 2019-08-04T16:30:58.2382653Z - fn foo<T>(x: T) {} // ok!
2019-08-04T16:30:58.2383297Z - ```
2019-08-04T16:30:58.2383821Z - Another case that causes this error is when a type is imported into a parent
2019-08-04T16:30:58.2383821Z - Another case that causes this error is when a type is imported into a parent
2019-08-04T16:30:58.2384085Z - module. To fix this, you can follow the suggestion and use File directly or
2019-08-04T16:30:58.2384380Z - `use super::File;` which will import the types from the parent namespace. An
2019-08-04T16:30:58.2384611Z - example that causes this error is below:
2019-08-04T16:30:58.2385021Z - ```compile_fail,E0412
2019-08-04T16:30:58.2385227Z - use std::fs::File;
2019-08-04T16:30:58.2385412Z - 2019-08-04T16:30:58.2385605Z - mod foo {
2019-08-04T16:30:58.2385605Z - mod foo {
2019-08-04T16:30:58.2385840Z - fn some_function(f: File) {}
2019-08-04T16:30:58.2386029Z - }
2019-08-04T16:30:58.2386336Z - ```
2019-08-04T16:30:58.2386712Z - ```
2019-08-04T16:30:58.2386915Z - use std::fs::File;
2019-08-04T16:30:58.2387094Z - 2019-08-04T16:30:58.2387297Z - mod foo {
2019-08-04T16:30:58.2387297Z - mod foo {
2019-08-04T16:30:58.2387487Z - // either
2019-08-04T16:30:58.2387683Z - use super::File;
2019-08-04T16:30:58.2387886Z - // or
2019-08-04T16:30:58.2388089Z - // use std::fs::File;
2019-08-04T16:30:58.2388288Z - fn foo(f: File) {}
2019-08-04T16:30:58.2388598Z - }
2019-08-04T16:30:58.2388854Z - # fn main() {} // don't insert it for us; that'll break imports
2019-08-04T16:30:58.2389041Z - ```
2019-08-04T16:30:58.2389220Z - "
2019-08-04T16:30:58.2389421Z - },
2019-08-04T16:30:58.2389615Z - "level": "error",
2019-08-04T16:30:58.2389804Z - "spans": [
2019-08-04T16:30:58.2390003Z - {
2019-08-04T16:30:58.2390230Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2390435Z - "byte_start": 471,
2019-08-04T16:30:58.2390635Z - "byte_end": 475,
2019-08-04T16:30:58.2390854Z - "line_start": 12,
2019-08-04T16:30:58.2391052Z - "line_end": 12,
2019-08-04T16:30:58.2391261Z - "column_start": 12,
2019-08-04T16:30:58.2391480Z - "column_end": 16,
2019-08-04T16:30:58.2391683Z - "is_primary": true,
2019-08-04T16:30:58.2391876Z - "text": [
2019-08-04T16:30:58.2392082Z - {
2019-08-04T16:30:58.2392300Z - "text": " let x: Iter;",
2019-08-04T16:30:58.2392512Z - "highlight_start": 12,
2019-08-04T16:30:58.2392730Z - "highlight_end": 16
2019-08-04T16:30:58.2394002Z - ],
2019-08-04T16:30:58.2394002Z - ],
2019-08-04T16:30:58.2394229Z - "label": "not found in this scope",
2019-08-04T16:30:58.2394468Z - "suggested_replacement": null,
2019-08-04T16:30:58.2394696Z - "suggestion_applicability": null,
2019-08-04T16:30:58.2394903Z - "expansion": null
2019-08-04T16:30:58.2395301Z - ],
2019-08-04T16:30:58.2395301Z - ],
2019-08-04T16:30:58.2395499Z - "children": [
2019-08-04T16:30:58.2395688Z - {
2019-08-04T16:30:58.2395994Z - "message": "possible candidates are found in other modules, you can import them into scope",
2019-08-04T16:30:58.2396209Z - "code": null,
2019-08-04T16:30:58.2396413Z - "level": "help",
2019-08-04T16:30:58.2396791Z - "spans": [
2019-08-04T16:30:58.2396979Z - {
2019-08-04T16:30:58.2397206Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2397430Z - "byte_start": 448,
2019-08-04T16:30:58.2397648Z - "byte_end": 448,
2019-08-04T16:30:58.2397852Z - "line_start": 11,
2019-08-04T16:30:58.2398053Z - "line_end": 11,
2019-08-04T16:30:58.2398277Z - "column_start": 1,
2019-08-04T16:30:58.2398479Z - "column_end": 1,
2019-08-04T16:30:58.2398684Z - "is_primary": true,
2019-08-04T16:30:58.2398894Z - "text": [
2019-08-04T16:30:58.2399085Z - {
2019-08-04T16:30:58.2399298Z - "text": "fn main() {",
2019-08-04T16:30:58.2399524Z - "highlight_start": 1,
2019-08-04T16:30:58.2399846Z - "highlight_end": 1
2019-08-04T16:30:58.2400377Z - ],
2019-08-04T16:30:58.2400645Z - "label": null,
2019-08-04T16:30:58.2400645Z - "label": null,
2019-08-04T16:30:58.2400888Z - "suggested_replacement": "use std::collections::binary_heap::Iter;
2019-08-04T16:30:58.2401259Z - ",
2019-08-04T16:30:58.2401477Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2401688Z - "expansion": null
2019-08-04T16:30:58.2401885Z - },
2019-08-04T16:30:58.2401885Z - },
2019-08-04T16:30:58.2402190Z - {
2019-08-04T16:30:58.2402416Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2403357Z - "byte_start": 448,
2019-08-04T16:30:58.2403609Z - "byte_end": 448,
2019-08-04T16:30:58.2403821Z - "line_start": 11,
2019-08-04T16:30:58.2404031Z - "line_end": 11,
2019-08-04T16:30:58.2404263Z - "column_start": 1,
2019-08-04T16:30:58.2404473Z - "column_end": 1,
2019-08-04T16:30:58.2404697Z - "is_primary": true,
2019-08-04T16:30:58.2404919Z - "text": [
2019-08-04T16:30:58.2405117Z - {
2019-08-04T16:30:58.2405337Z - "text": "fn main() {",
2019-08-04T16:30:58.2405557Z - "highlight_start": 1,
2019-08-04T16:30:58.2405792Z - "highlight_end": 1
2019-08-04T16:30:58.2406328Z - ],
2019-08-04T16:30:58.2406557Z - "label": null,
2019-08-04T16:30:58.2406557Z - "label": null,
2019-08-04T16:30:58.2406815Z - "suggested_replacement": "use std::collections::btree_map::Iter;
2019-08-04T16:30:58.2407326Z - ",
2019-08-04T16:30:58.2407556Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2407764Z - "expansion": null
2019-08-04T16:30:58.2407952Z - },
2019-08-04T16:30:58.2407952Z - },
2019-08-04T16:30:58.2408156Z - {
2019-08-04T16:30:58.2408383Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2413767Z - "byte_start": 448,
2019-08-04T16:30:58.2414252Z - "byte_end": 448,
2019-08-04T16:30:58.2414488Z - "line_start": 11,
2019-08-04T16:30:58.2414704Z - "line_end": 11,
2019-08-04T16:30:58.2414936Z - "column_start": 1,
2019-08-04T16:30:58.2415153Z - "column_end": 1,
2019-08-04T16:30:58.2415368Z - "is_primary": true,
2019-08-04T16:30:58.2415583Z - "text": [
2019-08-04T16:30:58.2415803Z - {
2019-08-04T16:30:58.2416024Z - "text": "fn main() {",
2019-08-04T16:30:58.2416360Z - "highlight_start": 1,
2019-08-04T16:30:58.2416584Z - "highlight_end": 1
2019-08-04T16:30:58.2416954Z - ],
2019-08-04T16:30:58.2417162Z - "label": null,
2019-08-04T16:30:58.2417162Z - "label": null,
2019-08-04T16:30:58.2417406Z - "suggested_replacement": "use std::collections::btree_set::Iter;
2019-08-04T16:30:58.2417883Z - ",
2019-08-04T16:30:58.2418144Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2418355Z - "expansion": null
2019-08-04T16:30:58.2418544Z - },
2019-08-04T16:30:58.2418544Z - },
2019-08-04T16:30:58.2418751Z - {
2019-08-04T16:30:58.2418981Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2419190Z - "byte_start": 448,
2019-08-04T16:30:58.2419413Z - "byte_end": 448,
2019-08-04T16:30:58.2419634Z - "line_start": 11,
2019-08-04T16:30:58.2419837Z - "line_end": 11,
2019-08-04T16:30:58.2420043Z - "column_start": 1,
2019-08-04T16:30:58.2420266Z - "column_end": 1,
2019-08-04T16:30:58.2420472Z - "is_primary": true,
2019-08-04T16:30:58.2420668Z - "text": [
2019-08-04T16:30:58.2420984Z - {
2019-08-04T16:30:58.2421189Z - "text": "fn main() {",
2019-08-04T16:30:58.2421396Z - "highlight_start": 1,
2019-08-04T16:30:58.2421614Z - "highlight_end": 1
2019-08-04T16:30:58.2422116Z - ],
2019-08-04T16:30:58.2422352Z - "label": null,
2019-08-04T16:30:58.2422352Z - "label": null,
2019-08-04T16:30:58.2422610Z - "suggested_replacement": "use std::collections::hash_map::Iter;
2019-08-04T16:30:58.2425325Z - ",
2019-08-04T16:30:58.2425595Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2425812Z - "expansion": null
2019-08-04T16:30:58.2426028Z - },
2019-08-04T16:30:58.2426028Z - },
2019-08-04T16:30:58.2426238Z - {
2019-08-04T16:30:58.2426882Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2427149Z - "byte_start": 448,
2019-08-04T16:30:58.2427364Z - "byte_end": 448,
2019-08-04T16:30:58.2427603Z - "line_start": 11,
2019-08-04T16:30:58.2427813Z - "line_end": 11,
2019-08-04T16:30:58.2428026Z - "column_start": 1,
2019-08-04T16:30:58.2428259Z - "column_end": 1,
2019-08-04T16:30:58.2428472Z - "is_primary": true,
2019-08-04T16:30:58.2428799Z - "text": [
2019-08-04T16:30:58.2429019Z - {
2019-08-04T16:30:58.2429345Z - "text": "fn main() {",
2019-08-04T16:30:58.2429553Z - "highlight_start": 1,
2019-08-04T16:30:58.2429756Z - "highlight_end": 1
2019-08-04T16:30:58.2430268Z - ],
2019-08-04T16:30:58.2430467Z - "label": null,
2019-08-04T16:30:58.2430467Z - "label": null,
2019-08-04T16:30:58.2430918Z - "suggested_replacement": "use std::collections::hash_set::Iter;
2019-08-04T16:30:58.2431285Z - ",
2019-08-04T16:30:58.2431528Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2431740Z - "expansion": null
2019-08-04T16:30:58.2431929Z - },
2019-08-04T16:30:58.2431929Z - },
2019-08-04T16:30:58.2432114Z - {
2019-08-04T16:30:58.2432364Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2432573Z - "byte_start": 448,
2019-08-04T16:30:58.2433350Z - "byte_end": 448,
2019-08-04T16:30:58.2433659Z - "line_start": 11,
2019-08-04T16:30:58.2433875Z - "line_end": 11,
2019-08-04T16:30:58.2434090Z - "column_start": 1,
2019-08-04T16:30:58.2434319Z - "column_end": 1,
2019-08-04T16:30:58.2434537Z - "is_primary": true,
2019-08-04T16:30:58.2434742Z - "text": [
2019-08-04T16:30:58.2434941Z - {
2019-08-04T16:30:58.2435194Z - "text": "fn main() {",
2019-08-04T16:30:58.2435416Z - "highlight_start": 1,
2019-08-04T16:30:58.2435636Z - "highlight_end": 1
2019-08-04T16:30:58.2436054Z - ],
2019-08-04T16:30:58.2436261Z - "label": null,
2019-08-04T16:30:58.2436261Z - "label": null,
2019-08-04T16:30:58.2436535Z - "suggested_replacement": "use std::collections::linked_list::Iter;
2019-08-04T16:30:58.2436915Z - ",
2019-08-04T16:30:58.2437150Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2437384Z - "expansion": null
2019-08-04T16:30:58.2437590Z - },
2019-08-04T16:30:58.2437590Z - },
2019-08-04T16:30:58.2437906Z - {
2019-08-04T16:30:58.2438154Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2438362Z - "byte_start": 448,
2019-08-04T16:30:58.2438568Z - "byte_end": 448,
2019-08-04T16:30:58.2438789Z - "line_start": 11,
2019-08-04T16:30:58.2438997Z - "line_end": 11,
2019-08-04T16:30:58.2439214Z - "column_start": 1,
2019-08-04T16:30:58.2439418Z - "column_end": 1,
2019-08-04T16:30:58.2439748Z - "is_primary": true,
2019-08-04T16:30:58.2439945Z - "text": [
2019-08-04T16:30:58.2440131Z - {
2019-08-04T16:30:58.2440355Z - "text": "fn main() {",
2019-08-04T16:30:58.2440563Z - "highlight_start": 1,
2019-08-04T16:30:58.2440766Z - "highlight_end": 1
2019-08-04T16:30:58.2441153Z - ],
2019-08-04T16:30:58.2441347Z - "label": null,
2019-08-04T16:30:58.2441347Z - "label": null,
2019-08-04T16:30:58.2441690Z - "suggested_replacement": "use std::collections::vec_deque::Iter;
2019-08-04T16:30:58.2442092Z - ",
2019-08-04T16:30:58.2442309Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2442528Z - "expansion": null
2019-08-04T16:30:58.2442711Z - },
2019-08-04T16:30:58.2442711Z - },
2019-08-04T16:30:58.2443390Z - {
2019-08-04T16:30:58.2443673Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2443897Z - "byte_start": 448,
2019-08-04T16:30:58.2444111Z - "byte_end": 448,
2019-08-04T16:30:58.2444323Z - "line_start": 11,
2019-08-04T16:30:58.2444554Z - "line_end": 11,
2019-08-04T16:30:58.2444768Z - "column_start": 1,
2019-08-04T16:30:58.2444981Z - "column_end": 1,
2019-08-04T16:30:58.2445215Z - "is_primary": true,
2019-08-04T16:30:58.2445420Z - "text": [
2019-08-04T16:30:58.2445619Z - {
2019-08-04T16:30:58.2445862Z - "text": "fn main() {",
2019-08-04T16:30:58.2446090Z - "highlight_start": 1,
2019-08-04T16:30:58.2446549Z - "highlight_end": 1
2019-08-04T16:30:58.2446950Z - ],
2019-08-04T16:30:58.2447151Z - "label": null,
2019-08-04T16:30:58.2447151Z - "label": null,
2019-08-04T16:30:58.2447386Z - "suggested_replacement": "use std::option::Iter;
2019-08-04T16:30:58.2447904Z - ",
2019-08-04T16:30:58.2448130Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2448353Z - "expansion": null
2019-08-04T16:30:58.2448547Z - },
2019-08-04T16:30:58.2448547Z - },
2019-08-04T16:30:58.2449303Z - {
2019-08-04T16:30:58.2449544Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2449788Z - "byte_start": 448,
2019-08-04T16:30:58.2450002Z - "byte_end": 448,
2019-08-04T16:30:58.2450214Z - "line_start": 11,
2019-08-04T16:30:58.2450443Z - "line_end": 11,
2019-08-04T16:30:58.2450668Z - "column_start": 1,
2019-08-04T16:30:58.2450883Z - "column_end": 1,
2019-08-04T16:30:58.2451109Z - "is_primary": true,
2019-08-04T16:30:58.2451315Z - "text": [
2019-08-04T16:30:58.2451514Z - {
2019-08-04T16:30:58.2451734Z - "text": "fn main() {",
2019-08-04T16:30:58.2451973Z - "highlight_start": 1,
2019-08-04T16:30:58.2452201Z - "highlight_end": 1
2019-08-04T16:30:58.2452902Z - ],
2019-08-04T16:30:58.2453125Z - "label": null,
2019-08-04T16:30:58.2453125Z - "label": null,
2019-08-04T16:30:58.2453367Z - "suggested_replacement": "use std::path::Iter;
2019-08-04T16:30:58.2453767Z - ",
2019-08-04T16:30:58.2454001Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2454215Z - "expansion": null
2019-08-04T16:30:58.2454430Z - },
2019-08-04T16:30:58.2454430Z - },
2019-08-04T16:30:58.2454623Z - {
2019-08-04T16:30:58.2454870Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2455107Z - "byte_start": 448,
2019-08-04T16:30:58.2455321Z - "byte_end": 448,
2019-08-04T16:30:58.2455535Z - "line_start": 11,
2019-08-04T16:30:58.2455762Z - "line_end": 11,
2019-08-04T16:30:58.2455978Z - "column_start": 1,
2019-08-04T16:30:58.2456191Z - "column_end": 1,
2019-08-04T16:30:58.2456415Z - "is_primary": true,
2019-08-04T16:30:58.2456639Z - "text": [
2019-08-04T16:30:58.2456836Z - {
2019-08-04T16:30:58.2457056Z - "text": "fn main() {",
2019-08-04T16:30:58.2457297Z - "highlight_start": 1,
2019-08-04T16:30:58.2457515Z - "highlight_end": 1
2019-08-04T16:30:58.2457925Z - ],
2019-08-04T16:30:58.2458135Z - "label": null,
2019-08-04T16:30:58.2458135Z - "label": null,
2019-08-04T16:30:58.2458378Z - "suggested_replacement": "use std::result::Iter;
2019-08-04T16:30:58.2458898Z - ",
2019-08-04T16:30:58.2459172Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2459388Z - "expansion": null
2019-08-04T16:30:58.2459606Z - },
2019-08-04T16:30:58.2459606Z - },
2019-08-04T16:30:58.2459801Z - {
2019-08-04T16:30:58.2460037Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2460270Z - "byte_start": 448,
2019-08-04T16:30:58.2460498Z - "byte_end": 448,
2019-08-04T16:30:58.2460711Z - "line_start": 11,
2019-08-04T16:30:58.2461046Z - "line_end": 11,
2019-08-04T16:30:58.2461270Z - "column_start": 1,
2019-08-04T16:30:58.2461475Z - "column_end": 1,
2019-08-04T16:30:58.2461681Z - "is_primary": true,
2019-08-04T16:30:58.2461896Z - "text": [
2019-08-04T16:30:58.2462086Z - {
2019-08-04T16:30:58.2462298Z - "text": "fn main() {",
2019-08-04T16:30:58.2462527Z - "highlight_start": 1,
2019-08-04T16:30:58.2463397Z - "highlight_end": 1
2019-08-04T16:30:58.2463811Z - ],
2019-08-04T16:30:58.2464040Z - "label": null,
2019-08-04T16:30:58.2464040Z - "label": null,
2019-08-04T16:30:58.2464280Z - "suggested_replacement": "use std::slice::Iter;
2019-08-04T16:30:58.2464676Z - ",
2019-08-04T16:30:58.2464911Z - "suggestion_applicability": "Unspecified",
2019-08-04T16:30:58.2465270Z - "expansion": null
2019-08-04T16:30:58.2465484Z - },
2019-08-04T16:30:58.2465484Z - },
2019-08-04T16:30:58.2465682Z - {
2019-08-04T16:30:58.2465919Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T16:30:58.2466136Z - "byte_start": 448,
2019-08-04T16:30:58.2466368Z - "byte_end": 448,
2019-08-04T16:30:58.2466581Z - "line_start": 11,
2019-08-04T16:30:58.2466791Z - "line_end": 11,
2019-08-04T16:30:58.2467026Z - "column_start": 1,
2019-08-04T16:30:58.2467361Z - "column_end": 1,
---
2019-08-04T16:30:58.2489904Z test result: FAILED. 8794 passed; 2 failed; 31 ignored; 0 measured; 0 filtered out
2019-08-04T16:30:58.2489937Z 2019-08-04T16:30:58.2490009Z 2019-08-04T16:30:58.2490051Z 2019-08-04T16:30:58.2491441Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-08-04T16:30:58.2491793Z 2019-08-04T16:30:58.2491924Z 2019-08-04T16:30:58.2491965Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-04T16:30:58.2492033Z Build completed unsuccessfully in 1:01:39
2019-08-04T16:30:58.2492033Z Build completed unsuccessfully in 1:01:39
2019-08-04T16:30:58.2492309Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-08-04T16:30:58.2492361Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-08-04T16:30:59.0054940Z ##[error]Bash exited with code '1'.
2019-08-04T16:30:59.0121684Z ##[section]Starting: Checkout
2019-08-04T16:30:59.0123933Z ==============================================================================
2019-08-04T16:30:59.0123995Z Task : Get sources
2019-08-04T16:30:59.0124059Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

monoflo · 2019-08-04T16:51:49Z

From the Azure CI logs:

error: argument for --error-format must be `human`, `json` or `short` (instead was `-Zunstable-options`)

I set the argument to json per 6ebe5036409aa7aa93b182c081d8c6cf0e9fafbb in both files. Is this correct?

rust-highfive · 2019-08-04T18:01:58Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-08-04T16:50:11.3034835Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-04T16:50:11.3223193Z ##[command]git config gc.auto 0
2019-08-04T16:50:11.3306334Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-04T16:50:11.3357352Z ##[command]git config --get-all http.proxy
2019-08-04T16:50:11.3501015Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63257/merge:refs/remotes/pull/63257/merge
---
2019-08-04T16:50:45.3257743Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-04T16:50:45.3257801Z 2019-08-04T16:50:45.3258044Z git checkout -b <new-branch-name>
2019-08-04T16:50:45.3258077Z 2019-08-04T16:50:45.3258132Z HEAD is now at 90ddb920f Merge 6ebe5036409aa7aa93b182c081d8c6cf0e9fafbb into 460072ebeed5a2463109894592ac172b47cdfb74
2019-08-04T16:50:45.3465399Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-04T16:50:45.3468872Z ==============================================================================
2019-08-04T16:50:45.3468942Z Task : Bash
2019-08-04T16:50:45.3468998Z Description : Run a Bash script on macOS, Linux, or Windows
---
2019-08-04T17:50:51.5688834Z .................................................................................................... 1400/8827
2019-08-04T17:50:57.8048573Z .................................................................................................... 1500/8827
2019-08-04T17:51:10.2478405Z ....................................................................i...............i............... 1600/8827
2019-08-04T17:51:17.4575500Z .................................................................................................... 1700/8827
2019-08-04T17:51:32.7796601Z ......................................................iiiii......................................... 1800/8827
2019-08-04T17:51:44.3715442Z .................................................................................................... 2000/8827
2019-08-04T17:51:46.8733317Z .................................................................................................... 2100/8827
2019-08-04T17:51:50.3093700Z .................................................................................................... 2200/8827
2019-08-04T17:51:58.2684715Z .................................................................................................... 2300/8827
---
2019-08-04T17:55:48.3155427Z .......................................................F.F.......................................... 5200/8827
2019-08-04T17:55:56.5169447Z .....................................................................i.............................. 5300/8827
2019-08-04T17:56:03.9300293Z .................................................................................................... 5400/8827
2019-08-04T17:56:10.9455015Z .................................................................................................... 5500/8827
2019-08-04T17:56:22.1351247Z ...............................................................ii...i..ii...........i............... 5600/8827
2019-08-04T17:56:45.3458415Z .................................................................................................... 5800/8827
2019-08-04T17:56:50.3879853Z .................................................................................................... 5900/8827
2019-08-04T17:56:50.3879853Z .................................................................................................... 5900/8827
2019-08-04T17:56:56.5282883Z ................................................................i..ii............................... 6000/8827
2019-08-04T17:57:25.5053843Z .................................................................................................... 6200/8827
2019-08-04T17:57:27.7160750Z .......i............................................................................................ 6300/8827
2019-08-04T17:57:29.8875095Z ...............................................................................i.................... 6400/8827
2019-08-04T17:57:32.6639254Z .................................................................................................... 6500/8827
---
2019-08-04T18:01:35.3781128Z 2019-08-04T18:01:35.3782179Z ---- [ui] ui/lint/unused_parens_json_suggestion.rs stdout ----
2019-08-04T18:01:35.3782334Z diff of stderr:
2019-08-04T18:01:35.3782368Z 2019-08-04T18:01:35.3782670Z - {
2019-08-04T18:01:35.3782942Z - "message": "unnecessary parentheses around assigned value",
2019-08-04T18:01:35.3783172Z - "code": {
2019-08-04T18:01:35.3783420Z - "code": "unused_parens",
2019-08-04T18:01:35.3783648Z - "explanation": null
2019-08-04T18:01:35.3783847Z - },
2019-08-04T18:01:35.3784390Z - "level": "warning",
2019-08-04T18:01:35.3784635Z - "spans": [
2019-08-04T18:01:35.3784834Z - {
2019-08-04T18:01:35.3785096Z - "file_name": "$DIR/unused_parens_json_suggestion.rs",
2019-08-04T18:01:35.3785353Z - "byte_start": 611,
2019-08-04T18:01:35.3785570Z - "byte_end": 624,
2019-08-04T18:01:35.3785789Z - "line_start": 15,
2019-08-04T18:01:35.3786025Z - "line_end": 15,
2019-08-04T18:01:35.3786251Z - "column_start": 14,
2019-08-04T18:01:35.3786467Z - "column_end": 27,
2019-08-04T18:01:35.3786686Z - "is_primary": true,
2019-08-04T18:01:35.3786917Z - "text": [
2019-08-04T18:01:35.3787121Z - {
2019-08-04T18:01:35.3787389Z - "text": " let _a = (1 / (2 + 3));",
2019-08-04T18:01:35.3787663Z - "highlight_start": 14,
2019-08-04T18:01:35.3787893Z - "highlight_end": 27
2019-08-04T18:01:35.3788683Z - ],
2019-08-04T18:01:35.3788915Z - "label": null,
2019-08-04T18:01:35.3789149Z - "suggested_replacement": null,
2019-08-04T18:01:35.3789384Z - "suggestion_applicability": null,
2019-08-04T18:01:35.3789384Z - "suggestion_applicability": null,
2019-08-04T18:01:35.3789623Z - "expansion": null
2019-08-04T18:01:35.3789823Z - }
2019-08-04T18:01:35.3790018Z - ],
2019-08-04T18:01:35.3790245Z - "children": [
2019-08-04T18:01:35.3790688Z - "message": "lint level defined here",
2019-08-04T18:01:35.3790921Z - "code": null,
2019-08-04T18:01:35.3791139Z - "level": "note",
2019-08-04T18:01:35.3791348Z - "spans": [
2019-08-04T18:01:35.3791348Z - "spans": [
2019-08-04T18:01:35.3791551Z - {
2019-08-04T18:01:35.3792065Z - "file_name": "$DIR/unused_parens_json_suggestion.rs",
2019-08-04T18:01:35.3792378Z - "byte_start": 457,
2019-08-04T18:01:35.3792785Z - "byte_end": 470,
2019-08-04T18:01:35.3793038Z - "line_start": 10,
2019-08-04T18:01:35.3793264Z - "line_end": 10,
2019-08-04T18:01:35.3793487Z - "column_start": 9,
2019-08-04T18:01:35.3793731Z - "column_end": 22,
2019-08-04T18:01:35.3793960Z - "is_primary": true,
2019-08-04T18:01:35.3794170Z - "text": [
2019-08-04T18:01:35.3794377Z - {
2019-08-04T18:01:35.3794647Z - "text": "#![warn(unused_parens)]",
2019-08-04T18:01:35.3794885Z - "highlight_start": 9,
2019-08-04T18:01:35.3795116Z - "highlight_end": 22
2019-08-04T18:01:35.3795550Z - ],
2019-08-04T18:01:35.3795766Z - "label": null,
2019-08-04T18:01:35.3796017Z - "suggested_replacement": null,
2019-08-04T18:01:35.3796274Z - "suggestion_applicability": null,
2019-08-04T18:01:35.3796274Z - "suggestion_applicability": null,
2019-08-04T18:01:35.3796499Z - "expansion": null
2019-08-04T18:01:35.3796711Z - }
2019-08-04T18:01:35.3796937Z - ],
2019-08-04T18:01:35.3797149Z - "children": [],
2019-08-04T18:01:35.3797361Z - "rendered": null
2019-08-04T18:01:35.3797780Z - {
2019-08-04T18:01:35.3797780Z - {
2019-08-04T18:01:35.3798020Z - "message": "remove these parentheses",
2019-08-04T18:01:35.3798234Z - "code": null,
2019-08-04T18:01:35.3798781Z - "level": "help",
2019-08-04T18:01:35.3799022Z - "spans": [
2019-08-04T18:01:35.3799222Z - {
2019-08-04T18:01:35.3799510Z - "file_name": "$DIR/unused_parens_json_suggestion.rs",
2019-08-04T18:01:35.3799741Z - "byte_start": 611,
2019-08-04T18:01:35.3799962Z - "byte_end": 624,
2019-08-04T18:01:35.3800203Z - "line_start": 15,
2019-08-04T18:01:35.3800428Z - "line_end": 15,
2019-08-04T18:01:35.3800650Z - "column_start": 14,
2019-08-04T18:01:35.3800885Z - "column_end": 27,
2019-08-04T18:01:35.3801137Z - "is_primary": true,
2019-08-04T18:01:35.3801359Z - "text": [
2019-08-04T18:01:35.3801564Z - {
2019-08-04T18:01:35.3801837Z - "text": " let _a = (1 / (2 + 3));",
2019-08-04T18:01:35.3802074Z - "highlight_start": 14,
2019-08-04T18:01:35.3802304Z - "highlight_end": 27
2019-08-04T18:01:35.3802738Z - ],
2019-08-04T18:01:35.3802952Z - "label": null,
2019-08-04T18:01:35.3802952Z - "label": null,
2019-08-04T18:01:35.3803200Z - "suggested_replacement": "1 / (2 + 3)",
2019-08-04T18:01:35.3803480Z - "suggestion_applicability": "MachineApplicable",
2019-08-04T18:01:35.3803703Z - "expansion": null
2019-08-04T18:01:35.3804131Z - ],
2019-08-04T18:01:35.3804131Z - ],
2019-08-04T18:01:35.3804345Z - "children": [],
2019-08-04T18:01:35.3804558Z - "rendered": null
2019-08-04T18:01:35.3804979Z - ],
2019-08-04T18:01:35.3804979Z - ],
2019-08-04T18:01:35.3805244Z - "rendered": "warning: unnecessary parentheses around assigned value
2019-08-04T18:01:35.3805524Z - --> $DIR/unused_parens_json_suggestion.rs:15:14
2019-08-04T18:01:35.3805619Z + {"message":"unnecessary parentheses around assigned value","code":{"code":"unused_parens","explanation":null},"level":"error","spans":[{"file_name":"$DIR/unused_parens_json_suggestion.rs","byte_start":553,"byte_end":566,"line_start":14,"line_end":14,"column_start":14,"column_end":27,"is_primary":true,"text":[{"text":" let _a = (1 / (2 + 3));
2019-08-04T18:01:35.3805902Z + --> $DIR/unused_parens_json_suggestion.rs:14:14
2019-08-04T18:01:35.3805979Z 95 |
2019-08-04T18:01:35.3806032Z 96 LL | let _a = (1 / (2 + 3));
2019-08-04T18:01:35.3806086Z 97 | ^^^^^^^^^^^^^ help: remove these parentheses
2019-08-04T18:01:35.3806188Z 98 |
2019-08-04T18:01:35.3806234Z 99 note: lint level defined here
2019-08-04T18:01:35.3806640Z - --> $DIR/unused_parens_json_suggestion.rs:10:9
2019-08-04T18:01:35.3806954Z + --> $DIR/unused_parens_json_suggestion.rs:9:9
2019-08-04T18:01:35.3806954Z + --> $DIR/unused_parens_json_suggestion.rs:9:9
2019-08-04T18:01:35.3807100Z 101 |
2019-08-04T18:01:35.3807359Z - LL | #![warn(unused_parens)]
2019-08-04T18:01:35.3807437Z + LL | #![deny(unused_parens)]
2019-08-04T18:01:35.3807531Z 104 2019-08-04T18:01:35.3807748Z - "
2019-08-04T18:01:35.3807939Z - }
2019-08-04T18:01:35.3807985Z + "}
---
2019-08-04T18:01:35.3808262Z 2019-08-04T18:01:35.3808291Z 2019-08-04T18:01:35.3808341Z The actual stderr differed from the expected stderr.
2019-08-04T18:01:35.3809034Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused_parens_json_suggestion/unused_parens_json_suggestion.stderr
2019-08-04T18:01:35.3809327Z To update references, rerun the tests and pass the `--bless` flag
2019-08-04T18:01:35.3809640Z To only update this specific test, also pass `--test-args lint/unused_parens_json_suggestion.rs`
2019-08-04T18:01:35.3809751Z error: 1 errors occurred comparing output.
2019-08-04T18:01:35.3809802Z status: exit code: 1
2019-08-04T18:01:35.3809802Z status: exit code: 1
2019-08-04T18:01:35.3810907Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/unused_parens_json_suggestion.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused_parens_json_suggestion" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--error-format" "json" "-Zunstable-options" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/unused_parens_json_suggestion/auxiliary" "-A" "unused"
2019-08-04T18:01:35.3811287Z ------------------------------------------
2019-08-04T18:01:35.3811326Z 2019-08-04T18:01:35.3811564Z ------------------------------------------
2019-08-04T18:01:35.3811612Z stderr:
2019-08-04T18:01:35.3811612Z stderr:
2019-08-04T18:01:35.3811864Z ------------------------------------------
2019-08-04T18:01:35.3811920Z error: unnecessary parentheses around assigned value
2019-08-04T18:01:35.3812188Z --> /checkout/src/test/ui/lint/unused_parens_json_suggestion.rs:14:14
2019-08-04T18:01:35.3812260Z |
2019-08-04T18:01:35.3812316Z LL | let _a = (1 / (2 + 3)); //~ ERROR: unused parentheses wrap expression
2019-08-04T18:01:35.3812373Z | ^^^^^^^^^^^^^ help: remove these parentheses
2019-08-04T18:01:35.3812485Z note: lint level defined here
2019-08-04T18:01:35.3812755Z --> /checkout/src/test/ui/lint/unused_parens_json_suggestion.rs:9:9
2019-08-04T18:01:35.3812824Z |
2019-08-04T18:01:35.3812824Z |
2019-08-04T18:01:35.3812879Z LL | #![deny(unused_parens)]
2019-08-04T18:01:35.3812966Z 2019-08-04T18:01:35.3813030Z error: aborting due to previous error
2019-08-04T18:01:35.3813063Z 2019-08-04T18:01:35.3813090Z 2019-08-04T18:01:35.3813090Z 2019-08-04T18:01:35.3813329Z ------------------------------------------
2019-08-04T18:01:35.3813363Z 2019-08-04T18:01:35.3813409Z 2019-08-04T18:01:35.3813654Z ---- [ui] ui/lint/use_suggestion_json.rs stdout ----
2019-08-04T18:01:35.3813706Z diff of stderr:
2019-08-04T18:01:35.3813736Z 2019-08-04T18:01:35.3813948Z - {
2019-08-04T18:01:35.3814195Z - "message": "cannot find type `Iter` in this scope",
2019-08-04T18:01:35.3814403Z - "code": {
2019-08-04T18:01:35.3814639Z - "code": "E0412",
2019-08-04T18:01:35.3814979Z - "explanation": "
2019-08-04T18:01:35.3815042Z + {"message":"cannot find type `Iter` in this scope","code":{"code":"E0412","explanation":"
2019-08-04T18:01:35.3815119Z 6 The type name used is not in scope.
2019-08-04T18:01:35.3815339Z 8 Erroneous code examples:
2019-08-04T18:01:35.3815383Z 2019-08-04T18:01:35.3815514Z 67 }
2019-08-04T18:01:35.3815514Z 67 }
2019-08-04T18:01:35.3815835Z 68 # fn main() {} // don't insert it for us; that'll break imports
2019-08-04T18:01:35.3815890Z 69 ```
2019-08-04T18:01:35.3816083Z - "
2019-08-04T18:01:35.3816302Z - },
2019-08-04T18:01:35.3816512Z - "level": "error",
2019-08-04T18:01:35.3816716Z - "spans": [
2019-08-04T18:01:35.3816937Z - {
2019-08-04T18:01:35.3817183Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3817405Z - "byte_start": 471,
2019-08-04T18:01:35.3817638Z - "byte_end": 475,
2019-08-04T18:01:35.3817860Z - "line_start": 12,
2019-08-04T18:01:35.3818074Z - "line_end": 12,
2019-08-04T18:01:35.3818292Z - "column_start": 12,
2019-08-04T18:01:35.3818866Z - "column_end": 16,
2019-08-04T18:01:35.3819097Z - "is_primary": true,
2019-08-04T18:01:35.3819306Z - "text": [
2019-08-04T18:01:35.3819537Z - {
2019-08-04T18:01:35.3819787Z - "text": " let x: Iter;",
2019-08-04T18:01:35.3820023Z - "highlight_start": 12,
2019-08-04T18:01:35.3820279Z - "highlight_end": 16
2019-08-04T18:01:35.3820687Z - ],
2019-08-04T18:01:35.3820687Z - ],
2019-08-04T18:01:35.3820925Z - "label": "not found in this scope",
2019-08-04T18:01:35.3821181Z - "suggested_replacement": null,
2019-08-04T18:01:35.3821418Z - "suggestion_applicability": null,
2019-08-04T18:01:35.3821637Z - "expansion": null
2019-08-04T18:01:35.3822053Z - ],
2019-08-04T18:01:35.3822053Z - ],
2019-08-04T18:01:35.3822260Z - "children": [
2019-08-04T18:01:35.3822457Z - {
2019-08-04T18:01:35.3822776Z - "message": "possible candidates are found in other modules, you can import them into scope",
2019-08-04T18:01:35.3823002Z - "code": null,
2019-08-04T18:01:35.3823243Z - "level": "help",
2019-08-04T18:01:35.3823457Z - "spans": [
2019-08-04T18:01:35.3823658Z - {
2019-08-04T18:01:35.3873467Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3875699Z - "byte_start": 448,
2019-08-04T18:01:35.3875980Z - "byte_end": 448,
2019-08-04T18:01:35.3876210Z - "line_start": 11,
2019-08-04T18:01:35.3876460Z - "line_end": 11,
2019-08-04T18:01:35.3876693Z - "column_start": 1,
2019-08-04T18:01:35.3876915Z - "column_end": 1,
2019-08-04T18:01:35.3877160Z - "is_primary": true,
2019-08-04T18:01:35.3877379Z - "text": [
2019-08-04T18:01:35.3877587Z - {
2019-08-04T18:01:35.3877826Z - "text": "fn main() {",
2019-08-04T18:01:35.3878551Z - "highlight_start": 1,
2019-08-04T18:01:35.3878843Z - "highlight_end": 1
2019-08-04T18:01:35.3879282Z - ],
2019-08-04T18:01:35.3879506Z - "label": null,
2019-08-04T18:01:35.3879506Z - "label": null,
2019-08-04T18:01:35.3879798Z - "suggested_replacement": "use std::collections::binary_heap::Iter;
2019-08-04T18:01:35.3879986Z + "},"level":"error","spans":[{"file_name":"$DIR/use_suggestion_json.rs","byte_start":464,"byte_end":468,"line_start":12,"line_end":12,"column_start":12,"column_end":16,"is_primary":true,"text":[{"text":" let x: Iter;","highlight_start":12,"highlight_end":16}],"label":"not found in this scope","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"possible candidates are found in other modules, you can import them into scope","code":null,"level":"help","spans":[{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::collections::binary_heap::Iter;
2019-08-04T18:01:35.3880341Z - ",
2019-08-04T18:01:35.3880588Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3881029Z - "expansion": null
2019-08-04T18:01:35.3881325Z - },
2019-08-04T18:01:35.3881325Z - },
2019-08-04T18:01:35.3881685Z - {
2019-08-04T18:01:35.3881937Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3882197Z - "byte_start": 448,
2019-08-04T18:01:35.3882425Z - "byte_end": 448,
2019-08-04T18:01:35.3882647Z - "line_start": 11,
2019-08-04T18:01:35.3882891Z - "line_end": 11,
2019-08-04T18:01:35.3883114Z - "column_start": 1,
2019-08-04T18:01:35.3883335Z - "column_end": 1,
2019-08-04T18:01:35.3883576Z - "is_primary": true,
2019-08-04T18:01:35.3883793Z - "text": [
2019-08-04T18:01:35.3883998Z - {
2019-08-04T18:01:35.3884227Z - "text": "fn main() {",
2019-08-04T18:01:35.3884482Z - "highlight_start": 1,
2019-08-04T18:01:35.3884711Z - "highlight_end": 1
2019-08-04T18:01:35.3885143Z - ],
2019-08-04T18:01:35.3885368Z - "label": null,
2019-08-04T18:01:35.3885368Z - "label": null,
2019-08-04T18:01:35.3885642Z - "suggested_replacement": "use std::collections::btree_map::Iter;
2019-08-04T18:01:35.3885776Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::collections::btree_map::Iter;
2019-08-04T18:01:35.3886077Z - ",
2019-08-04T18:01:35.3886326Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3886552Z - "expansion": null
2019-08-04T18:01:35.3886775Z - },
2019-08-04T18:01:35.3886775Z - },
2019-08-04T18:01:35.3886981Z - {
2019-08-04T18:01:35.3887227Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3887453Z - "byte_start": 448,
2019-08-04T18:01:35.3887710Z - "byte_end": 448,
2019-08-04T18:01:35.3887933Z - "line_start": 11,
2019-08-04T18:01:35.3888676Z - "line_end": 11,
2019-08-04T18:01:35.3888943Z - "column_start": 1,
2019-08-04T18:01:35.3889162Z - "column_end": 1,
2019-08-04T18:01:35.3889386Z - "is_primary": true,
2019-08-04T18:01:35.3889623Z - "text": [
2019-08-04T18:01:35.3889829Z - {
2019-08-04T18:01:35.3890061Z - "text": "fn main() {",
2019-08-04T18:01:35.3890312Z - "highlight_start": 1,
2019-08-04T18:01:35.3890545Z - "highlight_end": 1
2019-08-04T18:01:35.3890956Z - ],
2019-08-04T18:01:35.3891192Z - "label": null,
2019-08-04T18:01:35.3891192Z - "label": null,
2019-08-04T18:01:35.3891463Z - "suggested_replacement": "use std::collections::btree_set::Iter;
2019-08-04T18:01:35.3891597Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::collections::btree_set::Iter;
2019-08-04T18:01:35.3891892Z - ",
2019-08-04T18:01:35.3892161Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3892386Z - "expansion": null
2019-08-04T18:01:35.3892592Z - },
2019-08-04T18:01:35.3892592Z - },
2019-08-04T18:01:35.3892811Z - {
2019-08-04T18:01:35.3893061Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3893287Z - "byte_start": 448,
2019-08-04T18:01:35.3893530Z - "byte_end": 448,
2019-08-04T18:01:35.3893756Z - "line_start": 11,
2019-08-04T18:01:35.3893974Z - "line_end": 11,
2019-08-04T18:01:35.3894195Z - "column_start": 1,
2019-08-04T18:01:35.3894436Z - "column_end": 1,
2019-08-04T18:01:35.3894657Z - "is_primary": true,
2019-08-04T18:01:35.3895002Z - "text": [
2019-08-04T18:01:35.3895300Z - {
2019-08-04T18:01:35.3895656Z - "text": "fn main() {",
2019-08-04T18:01:35.3895890Z - "highlight_start": 1,
2019-08-04T18:01:35.3896137Z - "highlight_end": 1
2019-08-04T18:01:35.3896549Z - ],
2019-08-04T18:01:35.3896763Z - "label": null,
2019-08-04T18:01:35.3896763Z - "label": null,
2019-08-04T18:01:35.3897054Z - "suggested_replacement": "use std::collections::hash_map::Iter;
2019-08-04T18:01:35.3897155Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::collections::hash_map::Iter;
2019-08-04T18:01:35.3897455Z - ",
2019-08-04T18:01:35.3897711Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3897962Z - "expansion": null
2019-08-04T18:01:35.3898605Z - },
2019-08-04T18:01:35.3898605Z - },
2019-08-04T18:01:35.3898823Z - {
2019-08-04T18:01:35.3899096Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3899334Z - "byte_start": 448,
2019-08-04T18:01:35.3899563Z - "byte_end": 448,
2019-08-04T18:01:35.3899804Z - "line_start": 11,
2019-08-04T18:01:35.3900026Z - "line_end": 11,
2019-08-04T18:01:35.3900248Z - "column_start": 1,
2019-08-04T18:01:35.3900486Z - "column_end": 1,
2019-08-04T18:01:35.3900713Z - "is_primary": true,
2019-08-04T18:01:35.3900925Z - "text": [
2019-08-04T18:01:35.3901129Z - {
2019-08-04T18:01:35.3901382Z - "text": "fn main() {",
2019-08-04T18:01:35.3901617Z - "highlight_start": 1,
2019-08-04T18:01:35.3901845Z - "highlight_end": 1
2019-08-04T18:01:35.3902293Z - ],
2019-08-04T18:01:35.3902508Z - "label": null,
2019-08-04T18:01:35.3902508Z - "label": null,
2019-08-04T18:01:35.3902808Z - "suggested_replacement": "use std::collections::hash_set::Iter;
2019-08-04T18:01:35.3902912Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::collections::hash_set::Iter;
2019-08-04T18:01:35.3903204Z - ",
2019-08-04T18:01:35.3903450Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3903676Z - "expansion": null
2019-08-04T18:01:35.3904227Z - },
2019-08-04T18:01:35.3904227Z - },
2019-08-04T18:01:35.3904479Z - {
2019-08-04T18:01:35.3904729Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3905001Z - "byte_start": 448,
2019-08-04T18:01:35.3905232Z - "byte_end": 448,
2019-08-04T18:01:35.3905466Z - "line_start": 11,
2019-08-04T18:01:35.3905706Z - "line_end": 11,
2019-08-04T18:01:35.3905931Z - "column_start": 1,
2019-08-04T18:01:35.3906152Z - "column_end": 1,
2019-08-04T18:01:35.3906393Z - "is_primary": true,
2019-08-04T18:01:35.3906609Z - "text": [
2019-08-04T18:01:35.3906816Z - {
2019-08-04T18:01:35.3907048Z - "text": "fn main() {",
2019-08-04T18:01:35.3907304Z - "highlight_start": 1,
2019-08-04T18:01:35.3907534Z - "highlight_end": 1
2019-08-04T18:01:35.3907963Z - ],
2019-08-04T18:01:35.3910816Z - "label": null,
2019-08-04T18:01:35.3910816Z - "label": null,
2019-08-04T18:01:35.3911116Z - "suggested_replacement": "use std::collections::linked_list::Iter;
2019-08-04T18:01:35.3911412Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::collections::linked_list::Iter;
2019-08-04T18:01:35.3911848Z - ",
2019-08-04T18:01:35.3915246Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3915501Z - "expansion": null
2019-08-04T18:01:35.3915713Z - },
2019-08-04T18:01:35.3915713Z - },
2019-08-04T18:01:35.3915949Z - {
2019-08-04T18:01:35.3916285Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3916492Z - "byte_start": 448,
2019-08-04T18:01:35.3916716Z - "byte_end": 448,
2019-08-04T18:01:35.3916914Z - "line_start": 11,
2019-08-04T18:01:35.3917110Z - "line_end": 11,
2019-08-04T18:01:35.3917328Z - "column_start": 1,
2019-08-04T18:01:35.3917647Z - "column_end": 1,
2019-08-04T18:01:35.3917845Z - "is_primary": true,
2019-08-04T18:01:35.3918818Z - "text": [
2019-08-04T18:01:35.3919019Z - {
2019-08-04T18:01:35.3919224Z - "text": "fn main() {",
2019-08-04T18:01:35.3919432Z - "highlight_start": 1,
2019-08-04T18:01:35.3919657Z - "highlight_end": 1
2019-08-04T18:01:35.3920023Z - ],
2019-08-04T18:01:35.3920234Z - "label": null,
2019-08-04T18:01:35.3920234Z - "label": null,
2019-08-04T18:01:35.3920479Z - "suggested_replacement": "use std::collections::vec_deque::Iter;
2019-08-04T18:01:35.3920573Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::collections::vec_deque::Iter;
2019-08-04T18:01:35.3920857Z - ",
2019-08-04T18:01:35.3921096Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3921310Z - "expansion": null
2019-08-04T18:01:35.3921494Z - },
2019-08-04T18:01:35.3921494Z - },
2019-08-04T18:01:35.3921896Z - {
2019-08-04T18:01:35.3922110Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3922288Z - "byte_start": 448,
2019-08-04T18:01:35.3922462Z - "byte_end": 448,
2019-08-04T18:01:35.3922653Z - "line_start": 11,
2019-08-04T18:01:35.3922824Z - "line_end": 11,
2019-08-04T18:01:35.3922998Z - "column_start": 1,
2019-08-04T18:01:35.3923192Z - "column_end": 1,
2019-08-04T18:01:35.3923364Z - "is_primary": true,
2019-08-04T18:01:35.3923528Z - "text": [
2019-08-04T18:01:35.3923706Z - {
2019-08-04T18:01:35.3923890Z - "text": "fn main() {",
2019-08-04T18:01:35.3924069Z - "highlight_start": 1,
2019-08-04T18:01:35.3924254Z - "highlight_end": 1
2019-08-04T18:01:35.3924604Z - ],
2019-08-04T18:01:35.3924770Z - "label": null,
2019-08-04T18:01:35.3924770Z - "label": null,
2019-08-04T18:01:35.3924990Z - "suggested_replacement": "use std::option::Iter;
2019-08-04T18:01:35.3925066Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::option::Iter;
2019-08-04T18:01:35.3925296Z - ",
2019-08-04T18:01:35.3925489Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3925681Z - "expansion": null
2019-08-04T18:01:35.3925844Z - },
2019-08-04T18:01:35.3925844Z - },
2019-08-04T18:01:35.3925999Z - {
2019-08-04T18:01:35.3926319Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3926582Z - "byte_start": 448,
2019-08-04T18:01:35.3926890Z - "byte_end": 448,
2019-08-04T18:01:35.3927066Z - "line_start": 11,
2019-08-04T18:01:35.3927258Z - "line_end": 11,
2019-08-04T18:01:35.3927430Z - "column_start": 1,
2019-08-04T18:01:35.3927601Z - "column_end": 1,
2019-08-04T18:01:35.3927792Z - "is_primary": true,
2019-08-04T18:01:35.3927960Z - "text": [
2019-08-04T18:01:35.3928635Z - {
2019-08-04T18:01:35.3928858Z - "text": "fn main() {",
2019-08-04T18:01:35.3929093Z - "highlight_start": 1,
2019-08-04T18:01:35.3929295Z - "highlight_end": 1
2019-08-04T18:01:35.3929682Z - ],
2019-08-04T18:01:35.3929874Z - "label": null,
2019-08-04T18:01:35.3929874Z - "label": null,
2019-08-04T18:01:35.3930097Z - "suggested_replacement": "use std::path::Iter;
2019-08-04T18:01:35.3930213Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::path::Iter;
2019-08-04T18:01:35.3930465Z - ",
2019-08-04T18:01:35.3930704Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3930904Z - "expansion": null
2019-08-04T18:01:35.3931089Z - },
2019-08-04T18:01:35.3931089Z - },
2019-08-04T18:01:35.3931288Z - {
2019-08-04T18:01:35.3931625Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3931802Z - "byte_start": 448,
2019-08-04T18:01:35.3931998Z - "byte_end": 448,
2019-08-04T18:01:35.3932172Z - "line_start": 11,
2019-08-04T18:01:35.3932342Z - "line_end": 11,
2019-08-04T18:01:35.3932530Z - "column_start": 1,
2019-08-04T18:01:35.3932710Z - "column_end": 1,
2019-08-04T18:01:35.3932882Z - "is_primary": true,
2019-08-04T18:01:35.3933073Z - "text": [
2019-08-04T18:01:35.3933235Z - {
2019-08-04T18:01:35.3933413Z - "text": "fn main() {",
2019-08-04T18:01:35.3933593Z - "highlight_start": 1,
2019-08-04T18:01:35.3933791Z - "highlight_end": 1
2019-08-04T18:01:35.3934110Z - ],
2019-08-04T18:01:35.3934293Z - "label": null,
2019-08-04T18:01:35.3934293Z - "label": null,
2019-08-04T18:01:35.3934492Z - "suggested_replacement": "use std::result::Iter;
2019-08-04T18:01:35.3934567Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::result::Iter;
2019-08-04T18:01:35.3934801Z - ",
2019-08-04T18:01:35.3934992Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3935194Z - "expansion": null
2019-08-04T18:01:35.3935357Z - },
2019-08-04T18:01:35.3935357Z - },
2019-08-04T18:01:35.3935514Z - {
2019-08-04T18:01:35.3935726Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3935902Z - "byte_start": 448,
2019-08-04T18:01:35.3936076Z - "byte_end": 448,
2019-08-04T18:01:35.3936268Z - "line_start": 11,
2019-08-04T18:01:35.3936438Z - "line_end": 11,
2019-08-04T18:01:35.3936610Z - "column_start": 1,
2019-08-04T18:01:35.3936797Z - "column_end": 1,
2019-08-04T18:01:35.3936973Z - "is_primary": true,
2019-08-04T18:01:35.3937136Z - "text": [
2019-08-04T18:01:35.3937293Z - {
2019-08-04T18:01:35.3937493Z - "text": "fn main() {",
2019-08-04T18:01:35.3937672Z - "highlight_start": 1,
2019-08-04T18:01:35.3937960Z - "highlight_end": 1
2019-08-04T18:01:35.3939074Z - ],
2019-08-04T18:01:35.3939268Z - "label": null,
2019-08-04T18:01:35.3939268Z - "label": null,
2019-08-04T18:01:35.3939520Z - "suggested_replacement": "use std::slice::Iter;
2019-08-04T18:01:35.3939607Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::slice::Iter;
2019-08-04T18:01:35.3939868Z - ",
2019-08-04T18:01:35.3940085Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3940286Z - "expansion": null
2019-08-04T18:01:35.3940494Z - },
2019-08-04T18:01:35.3940494Z - },
2019-08-04T18:01:35.3940672Z - {
2019-08-04T18:01:35.3940891Z - "file_name": "$DIR/use_suggestion_json.rs",
2019-08-04T18:01:35.3941124Z - "byte_start": 448,
2019-08-04T18:01:35.3941332Z - "byte_end": 448,
2019-08-04T18:01:35.3941660Z - "line_start": 11,
2019-08-04T18:01:35.3941956Z - "line_end": 11,
2019-08-04T18:01:35.3942133Z - "column_start": 1,
2019-08-04T18:01:35.3942303Z - "column_end": 1,
2019-08-04T18:01:35.3942474Z - "is_primary": true,
2019-08-04T18:01:35.3942659Z - "text": [
2019-08-04T18:01:35.3942816Z - {
2019-08-04T18:01:35.3942994Z - "text": "fn main() {",
2019-08-04T18:01:35.3943194Z - "highlight_start": 1,
2019-08-04T18:01:35.3943369Z - "highlight_end": 1
2019-08-04T18:01:35.3943703Z - ],
2019-08-04T18:01:35.3945529Z - "label": null,
2019-08-04T18:01:35.3945529Z - "label": null,
2019-08-04T18:01:35.3946254Z - "suggested_replacement": "use std::sync::mpsc::Iter;
2019-08-04T18:01:35.3946385Z + ","suggestion_applicability":"Unspecified","expansion":null},{"file_name":"$DIR/use_suggestion_json.rs","byte_start":441,"byte_end":441,"line_start":11,"line_end":11,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"fn main() {","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":"use std::sync::mpsc::Iter;
2019-08-04T18:01:35.3946623Z - ",
2019-08-04T18:01:35.3946840Z - "suggestion_applicability": "Unspecified",
2019-08-04T18:01:35.3947016Z - "expansion": null
2019-08-04T18:01:35.3947178Z - }
2019-08-04T18:01:35.3947178Z - }
2019-08-04T18:01:35.3947350Z - ],
2019-08-04T18:01:35.3947518Z - "children": [],
2019-08-04T18:01:35.3947684Z - "rendered": null
2019-08-04T18:01:35.3948008Z - ],
2019-08-04T18:01:35.3948008Z - ],
2019-08-04T18:01:35.3948889Z - "rendered": "\u001b[0m\u001b[1m\u001b[38;5;9merror[E0412]\u001b[0m\u001b[0m\u001b[1m: cannot find type `Iter` in this scope\u001b[0m
2019-08-04T18:01:35.3949010Z + ","suggestion_applicability":"Unspecified","expansion":null}],"children":[],"rendered":null}],"rendered":"\u001b[0m\u001b[1m\u001b[38;5;9merror[E0412]\u001b[0m\u001b[0m\u001b[1m: cannot find type `Iter` in this scope\u001b[0m
2019-08-04T18:01:35.3949361Z 384 \u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m--> \u001b[0m\u001b[0m$DIR/use_suggestion_json.rs:12:12\u001b[0m
2019-08-04T18:01:35.3949422Z 385 \u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m|\u001b[0m
2019-08-04T18:01:35.3949502Z 386 \u001b[0m\u001b[1m\u001b[38;5;12mLL\u001b[0m\u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m| \u001b[0m\u001b[0m let x: Iter;\u001b[0m
2019-08-04T18:01:35.3949544Z 2019-08-04T18:01:35.3949590Z 397 \u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m|\u001b[0m
2019-08-04T18:01:35.3949659Z 398 \u001b[0mand 8 other candidates\u001b[0m
2019-08-04T18:01:35.3949936Z - "
2019-08-04T18:01:35.3950134Z - }
2019-08-04T18:01:35.3950307Z - {
2019-08-04T18:01:35.3950307Z - {
2019-08-04T18:01:35.3950522Z - "message": "aborting due to previous error",
2019-08-04T18:01:35.3950862Z - "code": null,
2019-08-04T18:01:35.3951139Z - "level": "error",
2019-08-04T18:01:35.3951456Z - "spans": [],
2019-08-04T18:01:35.3951745Z - "children": [],
2019-08-04T18:01:35.3952027Z - "rendered": "\u001b[0m\u001b[1m\u001b[38;5;9merror\u001b[0m\u001b[0m\u001b[1m: aborting due to previous error\u001b[0m
2019-08-04T18:01:35.3952072Z + "}
2019-08-04T18:01:35.3952128Z + {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"\u001b[0m\u001b[1m\u001b[38;5;9merror\u001b[0m\u001b[0m\u001b[1m: aborting due to previous error\u001b[0m
2019-08-04T18:01:35.3952345Z - "
2019-08-04T18:01:35.3952494Z - }
2019-08-04T18:01:35.3952658Z - {
2019-08-04T18:01:35.3952658Z - {
2019-08-04T18:01:35.3952879Z - "message": "For more information about this error, try `rustc --explain E0412`.",
2019-08-04T18:01:35.3953045Z - "code": null,
2019-08-04T18:01:35.3953204Z - "level": "",
2019-08-04T18:01:35.3953385Z - "spans": [],
2019-08-04T18:01:35.3953558Z - "children": [],
2019-08-04T18:01:35.3953810Z - "rendered": "\u001b[0m\u001b[1mFor more information about this error, try `rustc --explain E0412`.\u001b[0m
2019-08-04T18:01:35.3953997Z - "
2019-08-04T18:01:35.3954145Z - }
2019-08-04T18:01:35.3954180Z + "}
2019-08-04T18:01:35.3954544Z + {"message":"For more information about this error, try `rustc --explain E0412`.","code":null,"level":"","spans":[],"children":[],"rendered":"\u001b[0m\u001b[1mFor more information about this error, try `rustc --explain E0412`.\u001b[0m
2019-08-04T18:01:35.3954595Z + "}
2019-08-04T18:01:35.3954652Z 2019-08-04T18:01:35.3954691Z 2019-08-04T18:01:35.3954730Z The actual stderr differed from the expected stderr.
2019-08-04T18:01:35.3954996Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json/use_suggestion_json.stderr
2019-08-04T18:01:35.3954996Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json/use_suggestion_json.stderr
2019-08-04T18:01:35.3955223Z To update references, rerun the tests and pass the `--bless` flag
2019-08-04T18:01:35.3955452Z To only update this specific test, also pass `--test-args lint/use_suggestion_json.rs`
2019-08-04T18:01:35.3955526Z error: 1 errors occurred comparing output.
2019-08-04T18:01:35.3955582Z status: exit code: 1
2019-08-04T18:01:35.3955582Z status: exit code: 1
2019-08-04T18:01:35.3956226Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/use_suggestion_json.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--error-format" "json" "--json=diagnostic-rendered-ansi" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json/auxiliary" "-A" "unused"
2019-08-04T18:01:35.3956511Z ------------------------------------------
2019-08-04T18:01:35.3956540Z 2019-08-04T18:01:35.3956751Z ------------------------------------------
2019-08-04T18:01:35.3956790Z stderr:
2019-08-04T18:01:35.3956790Z stderr:
2019-08-04T18:01:35.3956978Z ------------------------------------------
2019-08-04T18:01:35.3957216Z error[E0412]: cannot find type `Iter` in this scope
2019-08-04T18:01:35.3957459Z --> /checkout/src/test/ui/lint/use_suggestion_json.rs:12:12
2019-08-04T18:01:35.3957646Z |
2019-08-04T18:01:35.3957882Z LL | let x: Iter;
2019-08-04T18:01:35.3958960Z help: possible candidates are found in other modules, you can import them into scope
2019-08-04T18:01:35.3959200Z |
2019-08-04T18:01:35.3959588Z LL | use std::collections::binary_heap::Iter;
2019-08-04T18:01:35.3959879Z |
---
2019-08-04T18:01:35.3963470Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-08-04T18:01:35.3963521Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-08-04T18:01:35.3963548Z 2019-08-04T18:01:35.3963588Z 2019-08-04T18:01:35.3964862Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-08-04T18:01:35.3965117Z 2019-08-04T18:01:35.3965143Z 2019-08-04T18:01:35.3965185Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-04T18:01:35.3965230Z Build completed unsuccessfully in 1:04:48
2019-08-04T18:01:35.3965230Z Build completed unsuccessfully in 1:04:48
2019-08-04T18:01:36.0974709Z ##[error]Bash exited with code '1'.
2019-08-04T18:01:36.1020469Z ##[section]Starting: Checkout
2019-08-04T18:01:36.1022482Z ==============================================================================
2019-08-04T18:01:36.1022528Z Task : Get sources
2019-08-04T18:01:36.1022571Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

monoflo · 2019-08-05T23:29:41Z

So I understand I have to edit the corresponding .stderr files in order for the test output to match up.

Could someone lend me a hand with this, or give me some pointers?

bors · 2019-08-07T04:30:11Z

☔ The latest upstream changes (presumably #63341) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2019-08-07T09:18:22Z

@monoflo usually the easiest way to get the .stderr files correct is to run ./x.py test --bless, which will update them for you to match the compiler's current output =)

JohnCSimon · 2019-08-17T06:35:11Z

Ping from triage
@monoflo moving this into the waiting on author pile as this has merge conflicts and there appears to be some work that has to be done.
Thank you for your contribution!

JohnCSimon · 2019-08-24T01:30:32Z

Pinging again from triage
@monoflo can you please resolve the conflicted file?
Thank you

nikomatsakis · 2019-08-30T20:07:03Z

(Note: you'll also want to run --bless)

rust-highfive · 2019-08-31T22:43:01Z

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-08-31T21:28:30.3085990Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-31T21:28:30.3259276Z ##[command]git config gc.auto 0
2019-08-31T21:28:30.3326275Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-31T21:28:30.3389092Z ##[command]git config --get-all http.proxy
2019-08-31T21:28:30.9282681Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63257/merge:refs/remotes/pull/63257/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis · 2019-09-04T20:28:27Z

@monoflo great, thanks! can you rebase to remove the merge commit?

hdhoang · 2019-09-20T01:47:35Z

ping from triage @monoflo, could you rebase so that only your commit appears in the "Commits" tab for this PR? Please feel free to reach out to us in #triage-wg on rust-lang Discord for more help.

Updates test file to use `#![deny(unused_parens)]` and `//~ERROR` annotations instead of pretty-json. See: #63237

See: #63237

Set empty argument for `--error-format` to "json" Issue #63236 See: https://dev.azure.com/rust-lang/rust/_build/results?buildId=5110&view=logs

rust-highfive · 2019-09-27T04:07:47Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-27T02:50:55.9933181Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-27T02:50:56.0147876Z ##[command]git config gc.auto 0
2019-09-27T02:50:56.0205653Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-27T02:50:56.0285543Z ##[command]git config --get-all http.proxy
2019-09-27T02:50:56.0428631Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63257/merge:refs/remotes/pull/63257/merge
---
2019-09-27T03:56:24.2849937Z .................................................................................................... 1500/9046
2019-09-27T03:56:30.5662858Z .................................................................................................... 1600/9046
2019-09-27T03:56:43.1884708Z .........................................................................i...............i.......... 1700/9046
2019-09-27T03:56:50.3067042Z .................................................................................................... 1800/9046
2019-09-27T03:56:59.0260726Z ................................................................iiiii............................... 1900/9046
2019-09-27T03:57:18.9896798Z .................................................................................................... 2100/9046
2019-09-27T03:57:21.6465937Z .................................................................................................... 2200/9046
2019-09-27T03:57:25.0112242Z .................................................................................................... 2300/9046
2019-09-27T03:57:33.7248795Z .................................................................................................... 2400/9046
---
2019-09-27T04:00:36.9386522Z ....................................................i...............i............................... 4700/9046
2019-09-27T04:00:46.4946581Z .................................................................................................... 4800/9046
2019-09-27T04:00:55.1206951Z .................................................................................................... 4900/9046
2019-09-27T04:01:02.8208008Z .................................................................................................... 5000/9046
2019-09-27T04:01:12.8275872Z ........................................ii.ii....................................................... 5100/9046
2019-09-27T04:01:23.0100302Z ..........................................................................................F......... 5300/9046
2019-09-27T04:01:33.7333257Z .................................................................................................... 5400/9046
2019-09-27T04:01:41.4025164Z .....i.............................................................................................. 5500/9046
2019-09-27T04:01:46.7762244Z .................................................................................................... 5600/9046
2019-09-27T04:01:46.7762244Z .................................................................................................... 5600/9046
2019-09-27T04:01:58.8427511Z .................................................................................................... 5700/9046
2019-09-27T04:02:12.2026799Z ii...i..ii...........i.............................................................................. 5800/9046
2019-09-27T04:02:34.7593385Z .................................................................................................... 6000/9046
2019-09-27T04:02:41.5310617Z .................................................................................................... 6100/9046
2019-09-27T04:02:41.5310617Z .................................................................................................... 6100/9046
2019-09-27T04:02:56.1828361Z ...i..ii............................................................................................ 6200/9046
2019-09-27T04:03:15.7297484Z ...............................................................i.................................... 6400/9046
2019-09-27T04:03:17.9909766Z .................................................................................................... 6500/9046
2019-09-27T04:03:20.6306743Z ...................................i................................................................ 6600/9046
2019-09-27T04:03:24.8779573Z .................................................................................................... 6700/9046
---
2019-09-27T04:07:39.6460687Z 2019-09-27T04:07:39.6463199Z ---- [ui] ui/lint/use_suggestion_json.rs stdout ----
2019-09-27T04:07:39.6463269Z diff of stderr:
2019-09-27T04:07:39.6463339Z 2019-09-27T04:07:39.6463410Z 108 {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"\u001b[0m\u001b[1m\u001b[38;5;9merror\u001b[0m\u001b[0m\u001b[1m: aborting due to previous error\u001b[0m
2019-09-27T04:07:39.6463528Z 110 "}
2019-09-27T04:07:39.6463528Z 110 "}
2019-09-27T04:07:39.6464477Z - {"message":"For more information about this error, try `rustc --explain E0412`.","code":null,"level":"","spans":[],"children":[],"rendered":"\u001b[0m\u001b[1mFor more information about this error, try `rustc --explain E0412`.\u001b[0m
2019-09-27T04:07:39.6464938Z + {"message":"For more information about this error, try `rustc --explain E0412`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"\u001b[0m\u001b[1mFor more information about this error, try `rustc --explain E0412`.\u001b[0m
2019-09-27T04:07:39.6465018Z 112 "}
2019-09-27T04:07:39.6465090Z 2019-09-27T04:07:39.6465117Z 2019-09-27T04:07:39.6465414Z The actual stderr differed from the expected stderr.
2019-09-27T04:07:39.6465785Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json/use_suggestion_json.stderr
2019-09-27T04:07:39.6465785Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json/use_suggestion_json.stderr
2019-09-27T04:07:39.6466030Z To update references, rerun the tests and pass the `--bless` flag
2019-09-27T04:07:39.6466343Z To only update this specific test, also pass `--test-args lint/use_suggestion_json.rs`
2019-09-27T04:07:39.6466432Z error: 1 errors occurred comparing output.
2019-09-27T04:07:39.6466481Z status: exit code: 1
2019-09-27T04:07:39.6466481Z status: exit code: 1
2019-09-27T04:07:39.6467550Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/use_suggestion_json.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--error-format" "json" "--json=diagnostic-rendered-ansi" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json/auxiliary" "-A" "unused"
2019-09-27T04:07:39.6467909Z ------------------------------------------
2019-09-27T04:07:39.6467942Z 2019-09-27T04:07:39.6468138Z ------------------------------------------
2019-09-27T04:07:39.6468197Z stderr:
2019-09-27T04:07:39.6468197Z stderr:
2019-09-27T04:07:39.6468388Z ------------------------------------------
2019-09-27T04:07:39.6468625Z error[E0412]: cannot find type `Iter` in this scope
2019-09-27T04:07:39.6468899Z --> /checkout/src/test/ui/lint/use_suggestion_json.rs:12:12
2019-09-27T04:07:39.6469100Z |
2019-09-27T04:07:39.6469330Z LL | let x: Iter;
2019-09-27T04:07:39.6469924Z help: possible candidates are found in other modules, you can import them into scope
2019-09-27T04:07:39.6470125Z |
2019-09-27T04:07:39.6470394Z LL | use std::collections::binary_heap::Iter;
2019-09-27T04:07:39.6470587Z |
---
2019-09-27T04:07:39.6502841Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-09-27T04:07:39.6502921Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-27T04:07:39.6520701Z 2019-09-27T04:07:39.6520775Z 2019-09-27T04:07:39.6523019Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-27T04:07:39.6523318Z 2019-09-27T04:07:39.6523348Z 2019-09-27T04:07:39.6530066Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-27T04:07:39.6530163Z Build completed unsuccessfully in 1:08:59
2019-09-27T04:07:39.6530163Z Build completed unsuccessfully in 1:08:59
2019-09-27T04:07:39.6583009Z == clock drift check ==
2019-09-27T04:07:39.6611189Z local time: Fri Sep 27 04:07:39 UTC 2019
2019-09-27T04:07:39.9430777Z network time: Fri, 27 Sep 2019 04:07:39 GMT
2019-09-27T04:07:39.9433881Z == end clock drift check ==
2019-09-27T04:07:41.0881550Z ##[error]Bash exited with code '1'.
2019-09-27T04:07:41.0935507Z ##[section]Starting: Checkout
2019-09-27T04:07:41.0937568Z ==============================================================================
2019-09-27T04:07:41.0937644Z Task : Get sources
2019-09-27T04:07:41.0937692Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis

Maybe we should keep up the "pretty-json" too?

cc @bravomikekilo, who opened the original issue (I don't have a strong opinion here)

nikomatsakis · 2019-10-03T13:10:28Z

@@ -1,5 +1,4 @@
-// compile-flags: --error-format pretty-json -Zunstable-options
-// build-pass (FIXME(62277): could be check-pass?)
+// compile-flags: --error-format json -Zunstable-options


it seems like pretty-json is more "diff friendly", even so, no?

nikomatsakis · 2019-10-03T13:12:20Z

Also: we are getting failures in the checks, are those maybe spurious? I couldn't get much from the logs.

Dylan-DPC-zz · 2019-10-10T12:04:33Z

@monoflo any updates on this?

hdhoang · 2019-10-17T06:48:37Z

second ping from triage @monoflo, thank you for your work on this. When you can continue, please re-open this PR first then push your updates.

@nikomatsakis

Fix test style in unused parentheses lint test I think this fixesrust-lang#63237 I'm not sure if I had to add text after the `//~ ERROR` comments. This is my first pull request, so I'm open to feedback. This issues already received one pull request [here](rust-lang#63257) but it was marked as closed for inactivity. r? @nikomatsakis

rust-highfive assigned nikomatsakis Aug 4, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2019

JohnTitor reviewed Aug 4, 2019
View reviewed changes

Comment threadsrc/test/ui/lint/unused_parens_json_suggestion.rs Outdated

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2019

monoflo added 5 commits September 26, 2019 22:44

fix: Update unused_parens_json_suggestion.rs test
f9210df
Updates test file to use `#![deny(unused_parens)]` and `//~ERROR` annotations instead of pretty-json. See: #63237

fix: Update unused_parens_json_suggestion.rs test
5d5b72a
Updates test file to use `#![deny(unused_parens)]` and `//~ERROR` annotations instead of pretty-json. See: #63237

fix: Drop pretty-json from use_suggestion_json.rs
b14a017
See: #63237

fix: Set error format argument to json
893b857
Set empty argument for `--error-format` to "json" Issue #63236 See: https://dev.azure.com/rust-lang/rust/_build/results?buildId=5110&view=logs

fix: Rectify stderr, fixed files using x.py
24b2057

nikomatsakis reviewed Oct 3, 2019
View reviewed changes

hdhoang closed this Oct 17, 2019

hdhoang added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2019

polyedre mentioned this pull request Oct 17, 2019
Fix test style in unused parentheses lint test #65507
Merged

Uh oh!

Uh oh!

Conversation

monoflo commented Aug 4, 2019

Issue

Uh oh!

rust-highfive commented Aug 4, 2019

Uh oh!

jonas-schievink commented Aug 4, 2019

Uh oh!

rust-highfive commented Aug 4, 2019

Uh oh!

Uh oh!

rust-highfive commented Aug 4, 2019

Uh oh!

monoflo commented Aug 4, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Aug 4, 2019

Uh oh!

monoflo commented Aug 5, 2019

Uh oh!

bors commented Aug 7, 2019

Uh oh!

nikomatsakis commented Aug 7, 2019

Uh oh!

JohnCSimon commented Aug 17, 2019

Uh oh!

JohnCSimon commented Aug 24, 2019

Uh oh!

nikomatsakis commented Aug 30, 2019

Uh oh!

rust-highfive commented Aug 31, 2019

Uh oh!

nikomatsakis commented Sep 4, 2019

Uh oh!

hdhoang commented Sep 20, 2019

Uh oh!

rust-highfive commented Sep 27, 2019

Uh oh!

nikomatsakis left a comment

Choose a reason for hiding this comment

Uh oh!

nikomatsakisOct 3, 2019

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Oct 3, 2019

Uh oh!

Dylan-DPC-zz commented Oct 10, 2019

Uh oh!

hdhoang commented Oct 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

monoflo commented Aug 4, 2019•
edited
Loading