Uh oh!
There was an error while loading. Please reload this page.
gitignore: add comment explaining policy - #63373
Merged
Merged
Conversation
rust-highfive
commented
Aug 8, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
RalfJung
commented
Aug 8, 2019
| src/etc/dl | ||
| tmp.*.rs | ||
| version.md | ||
| version.ml |
MemberAuthor
There was a problem hiding this comment.
This looks like it is from the OCaml bootstrap days. ;)
RalfJung
commented
Aug 8, 2019
Uh oh!
There was an error while loading. Please reload this page.
RalfJung
commented
Aug 8, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alexcrichton
commented
Aug 8, 2019
Member
@bors: r+ rollup |
bors
commented
Aug 8, 2019
Collaborator
📌 Commit 798767c has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 8, 2019
gitignore: add comment explaining policy Based on rust-lang#63307 (comment), I added a comment what I think should be gitignored and what not. This is just a proposal, obviously. Also see rust-lang#53768 for some more discussion. The summary is that if there are junk files that you create locally and are fine leaving around (such as `mir_dump`), git has the option for you to add them to `.git/info/exclude`. Others might prefer to keep their working dir clean of those same junk files, so we shouldn't just ignore them for everyone. I then also cleaned up a few more things, but there were many things that I had no idea where they came from so I didn't touch them.
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 8, 2019
gitignore: add comment explaining policy Based on rust-lang#63307 (comment), I added a comment what I think should be gitignored and what not. This is just a proposal, obviously. Also see rust-lang#53768 for some more discussion. The summary is that if there are junk files that you create locally and are fine leaving around (such as `mir_dump`), git has the option for you to add them to `.git/info/exclude`. Others might prefer to keep their working dir clean of those same junk files, so we shouldn't just ignore them for everyone. I then also cleaned up a few more things, but there were many things that I had no idea where they came from so I didn't touch them.
bors added a commit
that referenced
this pull request
Aug 8, 2019
Rollup of 6 pull requests Successful merges: - #63162 (Miri tests: use xargo to build separate libstd) - #63289 (Don't recommend `extern crate` syntax) - #63373 (gitignore: add comment explaining policy) - #63374 (move of packed fields might or might not occur when they actually are sufficiently aligned) - #63381 (reduce visibility) - #63387 (Test interaction between `async { ... }` and `?`, `return`, and `break`) Failed merges: r? @ghost
eddyb
reviewed
Aug 10, 2019
| .vscode | ||
| .favorites.json | ||
| /*-*-*-*/ | ||
| /*-*-*/ |
Contributor
There was a problem hiding this comment.
I was using this to have dirs git would ignore :(
However, it looks like I can maybe use the # prefix instead?
MemberAuthor
There was a problem hiding this comment.
Just edit your .git/info/exclude to ignore whatever you want.
Contributor
There was a problem hiding this comment.
I keep forgetting why I don't use that more often.
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 21, 2019
…um,Centril keep the root dir clean from debugging We landed this before with rust-lang#63307 but recently in rust-lang#65630 the IMO bad ignore crept back in. If you regularly do graphviz-based debugging and you are fine leaving junk in the rustc root dir, please configure your local `.git/info/exclude`. But most people working on rustc don't work with graphciz all that often (I for once never did), and not everyone likes to have stray generated files in their source dirs. Also Cc rust-lang#63373rust-lang#53768@ecstatic-morse@Mark-Simulacrum
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 21, 2019
…um,Centril keep the root dir clean from debugging We landed this before with rust-lang#63307 but recently in rust-lang#65630 the IMO bad ignore crept back in. If you regularly do graphviz-based debugging and you are fine leaving junk in the rustc root dir, please configure your local `.git/info/exclude`. But most people working on rustc don't work with graphciz all that often (I for once never did), and not everyone likes to have stray generated files in their source dirs. Also Cc rust-lang#63373rust-lang#53768@ecstatic-morse@Mark-Simulacrum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #63307 (comment), I added a comment what I think should be gitignored and what not. This is just a proposal, obviously. Also see #53768 for some more discussion.
The summary is that if there are junk files that you create locally and are fine leaving around (such as
mir_dump), git has the option for you to add them to.git/info/exclude. Others might prefer to keep their working dir clean of those same junk files, so we shouldn't just ignore them for everyone.I then also cleaned up a few more things, but there were many things that I had no idea where they came from so I didn't touch them.