Skip to content

Improve test output - #63403

Merged
bors merged 4 commits into
rust-lang:masterfrom
ohsayan:master
Aug 9, 2019
Merged

Improve test output#63403
bors merged 4 commits into
rust-lang:masterfrom
ohsayan:master

Conversation

@ohsayan

Copy link
Copy Markdown
Contributor

I'm continuing to improve the test output for liballoc and libcore

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2019
@hellow554

Copy link
Copy Markdown
Contributor
rg -g '*.rs' 'assert' | rg == | wc -l
889
rg -g '*.rs' 'assert' src/test | rg == | wc -l
160

😲 (TBH: that snippet has some flaws, but it shows my point ;) )
Can we maybe script that?

@Centril

Copy link
Copy Markdown
Contributor

Let's land this subset for now.

r? @Centril@bors r+ rollup

@bors

bors commented Aug 9, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit fb3a013 has been approved by Centril

@rust-highfiverust-highfive assigned Centril and unassigned TimNNAug 9, 2019
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 9, 2019
Improve test output
I'm continuing to improve the test output for liballoc and libcore
@CentrilCentril mentioned this pull request Aug 9, 2019
bors added a commit that referenced this pull request Aug 9, 2019
Rollup of 7 pull requests
Successful merges:
- #62672 (Deprecate `try!` macro)
- #62950 (Check rustbook links on all platforms when running locally)
- #63114 (Remove gensym in format_args)
- #63397 (Add tests for some ICEs)
- #63403 (Improve test output)
- #63404 (enable flt2dec tests in Miri)
- #63407 (reduce some test sizes in Miri)
Failed merges:
r? @ghost
@bors
bors merged commit fb3a013 into rust-lang:masterAug 9, 2019
@ohsayanohsayan mentioned this pull request Oct 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ohsayan@rust-highfive@hellow554@Centril@bors@TimNN