') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Better error message for certain classes of unresolved imports by emberian · Pull Request #6347 · rust-lang/rust · GitHub
Skip to content

Better error message for certain classes of unresolved imports - #6347

Merged
bors merged 4 commits into
rust-lang:incomingfrom
emberian:unknown_module_resolve_error
May 10, 2013
Merged

Better error message for certain classes of unresolved imports#6347
bors merged 4 commits into
rust-lang:incomingfrom
emberian:unknown_module_resolve_error

Conversation

@emberian

@emberianemberian commented May 9, 2013

Copy link
Copy Markdown
Contributor

This improves error reporting for the following class of imports:

use foo::bar;

Where foo, the topmost module, is unresolved. It now results in:

/tmp/foo.rs:1:4: 1:7 error: unresolved import. perhapsyou forgot an 'extern mod foo'?
/tmp/foo.rs:1 use foo::bar;
^~~
/tmp/foo.rs:1:4: 1:12 error: failed to resolve import: foo::bar
/tmp/foo.rs:1 use foo::bar;
^~~~~~~~
error: failed to resolve imports
error: aborting due to 3 previous errors

This is the first of a series of changes I plan on making to unresolved name error messages.

@emberian

emberian commented May 9, 2013

Copy link
Copy Markdown
ContributorAuthor

I assume you'll want me to squash these whitespace commits into the first?

@kud1ing

kud1ing commented May 9, 2013

Copy link
Copy Markdown

Would you mind changing perhaps you forgot an to maybe a missing?

@emberian

emberian commented May 9, 2013

Copy link
Copy Markdown
ContributorAuthor

Done

@kud1ing

kud1ing commented May 9, 2013

Copy link
Copy Markdown

Nice, thanks.

@emberian

emberian commented May 9, 2013

Copy link
Copy Markdown
ContributorAuthor

(haven't actually run that test yet, not at home with a decent computer)

@emberian

emberian commented May 9, 2013

Copy link
Copy Markdown
ContributorAuthor

tests pass, was that what you meant @catamorphism?

@emberian

emberian commented May 10, 2013

Copy link
Copy Markdown
ContributorAuthor

Whoops, added license.

@catamorphism

catamorphism commented May 10, 2013

Copy link
Copy Markdown
Contributor

@cmr - Thanks!

bors added a commit that referenced this pull request May 10, 2013
@bors
auto merge of#6347: cmr/rust/unknown_module_resolve_error, r=catamo…
f04eb37
…rphism
This improves error reporting for the following class of imports:
```rust
use foo::bar;
```
Where foo, the topmost module, is unresolved. It now results in:
```text
/tmp/foo.rs:1:4: 1:7 error: unresolved import. perhapsyou forgot an 'extern mod foo'?
/tmp/foo.rs:1 use foo::bar;
^~~
/tmp/foo.rs:1:4: 1:12 error: failed to resolve import: foo::bar
/tmp/foo.rs:1 use foo::bar;
^~~~~~~~
error: failed to resolve imports
error: aborting due to 3 previous errors
```
This is the first of a series of changes I plan on making to unresolved name error messages.
@borsbors closed this May 10, 2013
@bors
bors merged commit 9cbab89 into rust-lang:incomingMay 10, 2013
@emberianemberian mentioned this pull request May 10, 2013
Closed
@emberian
emberian deleted the unknown_module_resolve_error branch May 10, 2013 17:44
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 20, 2020
@bors
Auto merge ofrust-lang#6347- flip1995:changelog, r=Manishearth
70ffebf
Changelog Rust 1.48
[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md)
This changelog is **big**. Hacktoberfest was pretty good for us, even though we had too few reviewers.
changelog: none
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
@bors@Veykril
Mergerust-lang#6347
1a84cad
6347: Support insertion in SyntaxRewriter r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emberian@kud1ing@catamorphism@bors