Uh oh!
There was an error while loading. Please reload this page.
Point at the right enclosing scope when using await in non-async fn - #63509
Merged
Conversation
rust-highfive
commented
Aug 13, 2019
Contributor
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
emilyalbini
commented
Aug 13, 2019
Member
This is beta-nominated for 1.38 right? |
This comment has been minimized.
This comment has been minimized.
estebank
commented
Aug 13, 2019
ContributorAuthor
@pietroalbini correct, I'm aware of the current release and it'd be against procedure to include it in 1.37. |
emilyalbini
commented
Aug 13, 2019
Member
Great! I was a bit confused since 1.38 didn't branch out to beta yet 😅 |
Centril
reviewed
Aug 13, 2019
Uh oh!
There was an error while loading. Please reload this page.
Centril
commented
Aug 13, 2019
Contributor
r=me if you like with nit ^-- addressed |
estebank
commented
Aug 13, 2019
ContributorAuthor
bors
commented
Aug 13, 2019
Collaborator
📌 Commit 25d507f has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 14, 2019
Point at the right enclosing scope when using `await` in non-async fn Fixrust-lang#63398.
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 14, 2019
Point at the right enclosing scope when using `await` in non-async fn Fixrust-lang#63398.
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 14, 2019
Point at the right enclosing scope when using `await` in non-async fn Fixrust-lang#63398.
bors added a commit
that referenced
this pull request
Aug 14, 2019
Rollup of 10 pull requests Successful merges: - #62984 (Add lint for excess trailing semicolons) - #63075 (Miri: Check that a ptr is aligned and inbounds already when evaluating `*`) - #63490 (libsyntax: cleanup and refactor `pat.rs`) - #63495 ( Remove redundant `ty` fields from `mir::Constant` and `hair::pattern::PatternRange`.) - #63509 (Point at the right enclosing scope when using `await` in non-async fn) - #63528 (syntax: Remove `DummyResult::expr_only`) - #63534 (Bump to 1.39) - #63537 (expand: Unimplement `MutVisitor` on `MacroExpander`) - #63542 (Add NodeId for Arm, Field and FieldPat) - #63560 (move test that shouldn't be in test/run-pass/) Failed merges: r? @ghost
Centril
commented
Aug 14, 2019
Contributor
@estebank could you try to see if |
estebank
commented
Aug 14, 2019
ContributorAuthor
Can't see how it could have, but I'll do so soon. |
Centril
commented
Aug 14, 2019
Contributor
Yeah no; this PR is not at fault. |
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 14, 2019
Point at the right enclosing scope when using `await` in non-async fn Fixrust-lang#63398.
bors added a commit
that referenced
this pull request
Aug 15, 2019
Rollup of 11 pull requests Successful merges: - #62984 (Add lint for excess trailing semicolons) - #63075 (Miri: Check that a ptr is aligned and inbounds already when evaluating `*`) - #63490 (libsyntax: cleanup and refactor `pat.rs`) - #63507 (When needing type annotations in local bindings, account for impl Trait and closures) - #63509 (Point at the right enclosing scope when using `await` in non-async fn) - #63528 (syntax: Remove `DummyResult::expr_only`) - #63537 (expand: Unimplement `MutVisitor` on `MacroExpander`) - #63542 (Add NodeId for Arm, Field and FieldPat) - #63543 (Merge Variant and Variant_) - #63560 (move test that shouldn't be in test/run-pass/) - #63570 (Adjust tracking issues for `MaybeUninit<T>` gates) Failed merges: r? @ghost
Contributor
We decided not to accept this for beta since async-await didn't make the beta cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#63398.