Uh oh!
There was an error while loading. Please reload this page.
Feature gate 'yield $expr?' pre-expansion - #63545
Merged
Merged
Conversation
oli-obk
commented
Aug 15, 2019
Contributor
@bors r+ |
bors
commented
Aug 15, 2019
Collaborator
📌 Commit 4fe201c has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
Feature gate 'yield $expr?' pre-expansion Also improve the overall ergonomics of pre-expansion gating in general. r? @Zoxc
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
Feature gate 'yield $expr?' pre-expansion Also improve the overall ergonomics of pre-expansion gating in general. r? @Zoxc
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
Feature gate 'yield $expr?' pre-expansion Also improve the overall ergonomics of pre-expansion gating in general. r? @Zoxc
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
Feature gate 'yield $expr?' pre-expansion Also improve the overall ergonomics of pre-expansion gating in general. r? @Zoxc
bors added a commit
that referenced
this pull request
Aug 15, 2019
Rollup of 5 pull requests Successful merges: - #63173 (Use libunwind from llvm-project submodule for musl targets) - #63462 (Opaque builtin derive macros) - #63539 (Suggest Rust 2018 on `<expr>.await` with no such field) - #63545 (Feature gate 'yield $expr?' pre-expansion) - #63584 (libcore: more cleanups using `#![feature(associated_type_bounds)]`) Failed merges: r? @ghost
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
Feature gate 'yield $expr?' pre-expansion Also improve the overall ergonomics of pre-expansion gating in general. r? @Zoxc
This comment has been minimized.
This comment has been minimized.
Centrilforce-pushed
the
gate-yield-preexp
branch
from
August 16, 2019 17:27
4fe201c to
20661f1CompareCentril
commented
Aug 16, 2019
ContributorAuthor
@bors r=oli-obk |
bors
commented
Aug 16, 2019
Collaborator
📌 Commit 20661f1 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 16, 2019
Feature gate 'yield $expr?' pre-expansion Also improve the overall ergonomics of pre-expansion gating in general. r? @Zoxc
Centril added a commit
to Centril/rust
that referenced
this pull request
Aug 17, 2019
Feature gate 'yield $expr?' pre-expansion Also improve the overall ergonomics of pre-expansion gating in general. r? @Zoxc
bors added a commit
that referenced
this pull request
Aug 17, 2019
Rollup of 6 pull requests Successful merges: - #63149 (resolve: Populate external modules in more automatic and lazy way) - #63545 (Feature gate 'yield $expr?' pre-expansion) - #63548 (Update rustc-demangle to 0.1.16.) - #63558 (Remap paths for proc-macro crates.) - #63641 (add git keyword to submodule comments in config.example.toml) - #63642 (Rename overflowing_{add,sub,mul} intrinsics to wrapping_{add,sub,mul}.) Failed merges: r? @ghost
bors
commented
Aug 17, 2019
Collaborator
☔ The latest upstream changes (presumably #63648) made this pull request unmergeable. Please resolve the merge conflicts. |
carllerche
commented
Aug 21, 2019
Contributor
Would this not break stable code as macros on stable could transform yield syntax to syntax supported on stable rust? |
Centril
commented
Aug 21, 2019
ContributorAuthor
@carllerche Attribute and declarative macros on stable should not take advantage of the stability hole (i.e. bug -- see rust-lang/rfcs#2405) in the language that post-expansion gating was. If you want to conditionally rely on unstable syntax, use |
carllerche
commented
Aug 21, 2019
Contributor
Ok, sorry. I did not realize it was considered a stability hole. |
Centril
commented
Aug 21, 2019
ContributorAuthor
@carllerche Np, thanks for asking. :) |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improve the overall ergonomics of pre-expansion gating in general.
r? @Zoxc