Uh oh!
There was an error while loading. Please reload this page.
libsyntax: Remove extern mod foo { ... } from the language. - #6375
Closed
pcwalton wants to merge 1 commit into
Closed
libsyntax: Remove extern mod foo { ... } from the language.#6375pcwalton wants to merge 1 commit into
extern mod foo { ... } from the language.#6375pcwalton wants to merge 1 commit into
Conversation
catamorphism
commented
May 9, 2013
Contributor
Ok except for the documentation, as per my line comments -- I'll r+ after that's fixed. |
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 2, 2021
…=flip1995 Reassign default private changelog: fix field_reassign_with_default false positive * Fixrust-lang#6344 * Fix assumption that `field: Default::default()` is the same as `..Default::default()` * Cleanup some redundant logic
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 4, 2021
[beta] Backport of rust-lang#6375 - field_reassign_with_default fix With the pinned nightly we can test backports to our beta branch now 🎉 cc rust-lang#6515 changelog: beta 1.50: Backport of private fields fix in [`field_reassign_with_default`] lints
rust-borsBot
pushed a commit
that referenced
this pull request
Feb 27, 2026
Previously, `Ord` for `UseSegment` was not Transitive, causing `user-provided comparison function does not correctly implement a total order` panic.
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
6376: Avoid impls_fnonce to return true when the trait solving is ambiguous r=flodiebold a=GrayJack This PR should fixrust-lang#6375 This adds a variation of `method_resolution::implements_trait` called `method_resolution::implements_trait_unique`, that only returns true when the trait solving is unique, and also change `impls_fnonce` to use the later instead. I also added a test just to be sure. Co-authored-by: GrayJack <gr41.j4ck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @catamorphism