Skip to content

Rename test locals to work around LLDB bug - #64052

Merged
bors merged 1 commit into
rust-lang:masterfrom
ranweiler:debuginfo-boxed-struct-64050
Sep 8, 2019
Merged

Rename test locals to work around LLDB bug#64052
bors merged 1 commit into
rust-lang:masterfrom
ranweiler:debuginfo-boxed-struct-64050

Conversation

@ranweiler

Copy link
Copy Markdown
Contributor

LLDB's expression parser can't unambiguously resolve local variables in
some cases, as described in #47938. Work around this by using names that
don't shadow direct submodules of core.

Closes#64050.

LLDB's expression parser can't unambiguously resolve local variables in
some cases, as described in rust-lang#47938. Work around this by using names that
don't shadow direct submodules of `core`.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2019
Comment threadsrc/test/debuginfo/boxed-struct.rs
@ranweiler

Copy link
Copy Markdown
ContributorAuthor

Note: at least in some cases, you can avoid the lldb bug by using single quotes around the local var, as described here. I've found this to work locally when using rust-lldb on one of the minimal examples in the other issue.

However, this trick doesn't work in the test harness's usage, because we want to do print *'unique' (note the deref) instead of e.g. print 'foo'. This generally causes the following (test-failing) error from lldb:

print *'unique'
error: warning: multi-character character constant
warning: character constant too long for its type
error: indirection requires pointer operand ('int' invalid)

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ rollup

Seems reasonable to me in any case, thanks!

@bors

bors commented Sep 3, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 6ed50f4 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
…050, r=alexcrichton
Rename test locals to work around LLDB bug
LLDB's expression parser can't unambiguously resolve local variables in
some cases, as described in rust-lang#47938. Work around this by using names that
don't shadow direct submodules of `core`.
Closesrust-lang#64050.
@CentrilCentril mentioned this pull request Sep 5, 2019
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 6, 2019
…050, r=alexcrichton
Rename test locals to work around LLDB bug
LLDB's expression parser can't unambiguously resolve local variables in
some cases, as described in rust-lang#47938. Work around this by using names that
don't shadow direct submodules of `core`.
Closesrust-lang#64050.
@Centril

Copy link
Copy Markdown
Contributor

@bors rollup-

@bors

bors commented Sep 7, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6ed50f4 with merge 9681cb140952433f7b4f697616cf01d302c10e9c...

Centril added a commit to Centril/rust that referenced this pull request Sep 7, 2019
…050, r=alexcrichton
Rename test locals to work around LLDB bug
LLDB's expression parser can't unambiguously resolve local variables in
some cases, as described in rust-lang#47938. Work around this by using names that
don't shadow direct submodules of `core`.
Closesrust-lang#64050.
@CentrilCentril mentioned this pull request Sep 7, 2019
@Centril

Copy link
Copy Markdown
Contributor

@bors retry rolled up.

bors added a commit that referenced this pull request Sep 7, 2019
Rollup of 5 pull requests
Successful merges:
- #64052 (Rename test locals to work around LLDB bug)
- #64066 (Support "soft" feature-gating using a lint)
- #64177 (resolve: Do not afraid to set current module to enums and traits)
- #64229 (Reduce span to function name in unreachable calls)
- #64255 (Add methods for converting `bool` to `Option<T>`)
Failed merges:
r? @ghost
@bors
bors merged commit 6ed50f4 into rust-lang:masterSep 8, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

debuginfo/boxed-struct test fails with LLDB 8

5 participants

@ranweiler@rust-highfive@alexcrichton@bors@Centril