Uh oh!
There was an error while loading. Please reload this page.
Rename test locals to work around LLDB bug - #64052
Conversation
LLDB's expression parser can't unambiguously resolve local variables in some cases, as described in rust-lang#47938. Work around this by using names that don't shadow direct submodules of `core`.
rust-highfive
commented
Sep 1, 2019
(rust_highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
ranweiler
commented
Sep 1, 2019
Note: at least in some cases, you can avoid the lldb bug by using single quotes around the local var, as described here. I've found this to work locally when using However, this trick doesn't work in the test harness's usage, because we want to do |
alexcrichton
commented
Sep 3, 2019
@bors: r+ rollup Seems reasonable to me in any case, thanks! |
bors
commented
Sep 3, 2019
📌 Commit 6ed50f4 has been approved by |
…050, r=alexcrichton Rename test locals to work around LLDB bug LLDB's expression parser can't unambiguously resolve local variables in some cases, as described in rust-lang#47938. Work around this by using names that don't shadow direct submodules of `core`. Closesrust-lang#64050.
…050, r=alexcrichton Rename test locals to work around LLDB bug LLDB's expression parser can't unambiguously resolve local variables in some cases, as described in rust-lang#47938. Work around this by using names that don't shadow direct submodules of `core`. Closesrust-lang#64050.
Centril
commented
Sep 7, 2019
@bors rollup- |
bors
commented
Sep 7, 2019
⌛ Testing commit 6ed50f4 with merge 9681cb140952433f7b4f697616cf01d302c10e9c... |
…050, r=alexcrichton Rename test locals to work around LLDB bug LLDB's expression parser can't unambiguously resolve local variables in some cases, as described in rust-lang#47938. Work around this by using names that don't shadow direct submodules of `core`. Closesrust-lang#64050.
Centril
commented
Sep 7, 2019
@bors retry rolled up. |
Rollup of 5 pull requests Successful merges: - #64052 (Rename test locals to work around LLDB bug) - #64066 (Support "soft" feature-gating using a lint) - #64177 (resolve: Do not afraid to set current module to enums and traits) - #64229 (Reduce span to function name in unreachable calls) - #64255 (Add methods for converting `bool` to `Option<T>`) Failed merges: r? @ghost
LLDB's expression parser can't unambiguously resolve local variables in
some cases, as described in #47938. Work around this by using names that
don't shadow direct submodules of
core.Closes#64050.