Skip to content

Remove no-prefer-dynamic from valgrind tests - #64067

Merged
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:valgrind-dyn
Sep 6, 2019
Merged

Remove no-prefer-dynamic from valgrind tests#64067
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:valgrind-dyn

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Sep 1, 2019

Copy link
Copy Markdown
Member

This seems to be working locally.

Resolves#31968

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2019
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Sep 3, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 0c9aeba has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
…xcrichton
Remove no-prefer-dynamic from valgrind tests
This seems to be working locally.
Resolvesrust-lang#31968
@CentrilCentril mentioned this pull request Sep 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 6, 2019
…xcrichton
Remove no-prefer-dynamic from valgrind tests
This seems to be working locally.
Resolvesrust-lang#31968
@CentrilCentril mentioned this pull request Sep 6, 2019
bors added a commit that referenced this pull request Sep 6, 2019
Rollup of 9 pull requests
Successful merges:
- #64067 (Remove no-prefer-dynamic from valgrind tests)
- #64078 (compiletest: disable -Aunused for run-pass tests)
- #64096 (Fix regex replacement in theme detection)
- #64098 (Ensure edition lints and internal lints are enabled with deny-warnings=false)
- #64166 (Better way of conditioning the sanitizer builds)
- #64189 (annotate-snippet emitter: Deal with multispans from macros, too)
- #64202 (Fixed grammar/style in some error messages)
- #64206 (annotate-snippet emitter: Update an issue number)
- #64208 (it's more pythonic to use 'is not None' in python files)
Failed merges:
r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 6, 2019
…xcrichton
Remove no-prefer-dynamic from valgrind tests
This seems to be working locally.
Resolvesrust-lang#31968
@CentrilCentril mentioned this pull request Sep 6, 2019
bors added a commit that referenced this pull request Sep 6, 2019
Rollup of 8 pull requests
Successful merges:
- #63565 (Rust 2018: NLL migrate mode => hard error)
- #63969 (Add missing examples for Option type)
- #64067 (Remove no-prefer-dynamic from valgrind tests)
- #64166 (Better way of conditioning the sanitizer builds)
- #64189 (annotate-snippet emitter: Deal with multispans from macros, too)
- #64202 (Fixed grammar/style in some error messages)
- #64206 (annotate-snippet emitter: Update an issue number)
- #64208 (it's more pythonic to use 'is not None' in python files)
Failed merges:
r? @ghost
@bors
bors merged commit 0c9aeba into rust-lang:masterSep 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Valgrind tests fail when compiled dynamically

4 participants

@Mark-Simulacrum@alexcrichton@bors@rust-highfive