Do not complain about unconstrained params when Self is Ty Error by estebank · Pull Request #64108 · rust-lang/rust

estebank · 2019-09-03T01:04:14Z

rust-highfive · 2019-09-03T01:04:18Z

(rust_highfive has picked a reviewer for you, use r? to override)

Centril · 2019-09-03T01:15:18Z

r? @Centril r=me with changes requested.

eddyb · 2019-09-03T10:22:30Z

+pub fn parameters_for<'tcx>(
+ t: &impl TypeFoldable<'tcx>,
+ include_nonconstraining: bool,
+) -> Vec<Parameter> {


Spurious rustfmt?

My guess is manual drive-by fixing... but who cares. ;)

Centril · 2019-09-03T14:03:44Z

r=me with @eddyb's last two comments also addressed; but keep the rustfmt-ish change tho.

rust-highfive · 2019-09-03T18:00:53Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-03T16:26:25.5691742Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-03T16:26:26.1420697Z ##[command]git config gc.auto 0
2019-09-03T16:26:26.1423987Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-03T16:26:26.1426017Z ##[command]git config --get-all http.proxy
2019-09-03T16:26:26.1429643Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64108/merge:refs/remotes/pull/64108/merge
---
2019-09-03T17:33:46.7229307Z .................................................................................................... 1500/8988
2019-09-03T17:33:52.8331639Z .................................................................................................... 1600/8988
2019-09-03T17:34:06.6127606Z .................................................i...............i.................................. 1700/8988
2019-09-03T17:34:15.6078203Z .................................................................................................... 1800/8988
2019-09-03T17:34:31.2219999Z ........................................iiiii....................................................... 1900/8988
2019-09-03T17:34:43.1797920Z .................................................................................................... 2100/8988
2019-09-03T17:34:46.0255961Z .................................................................................................... 2200/8988
2019-09-03T17:34:50.4826006Z .................................................................................................... 2300/8988
2019-09-03T17:34:58.8250399Z .................................................................................................... 2400/8988
---
2019-09-03T17:38:12.3413536Z ............................i...............i....................................................... 4700/8988
2019-09-03T17:38:25.4820847Z .................................................................................................... 4800/8988
2019-09-03T17:38:32.1448301Z .................................................................................................... 4900/8988
2019-09-03T17:38:43.8911043Z .................................................................................................... 5000/8988
2019-09-03T17:38:50.1432381Z .........ii.ii...................................................................................... 5100/8988
2019-09-03T17:39:04.2092242Z .................................................................................................... 5300/8988
2019-09-03T17:39:13.4105011Z ........................................................................i........................... 5400/8988
2019-09-03T17:39:21.4278794Z .................................................................................................... 5500/8988
2019-09-03T17:39:28.7505076Z .................................................................................................... 5600/8988
2019-09-03T17:39:28.7505076Z .................................................................................................... 5600/8988
2019-09-03T17:39:40.3619333Z ..................................................................ii...i..ii...........i............ 5700/8988
2019-09-03T17:40:08.9442907Z .................................................................................................... 5900/8988
2019-09-03T17:40:19.7804347Z .................................................................................................... 6000/8988
2019-09-03T17:40:19.7804347Z .................................................................................................... 6000/8988
2019-09-03T17:40:28.3694126Z ....................................................................i..ii........................... 6100/8988
2019-09-03T17:41:00.3825866Z .................................................................................................... 6300/8988
2019-09-03T17:41:02.6558863Z .......................i............................................................................ 6400/8988
2019-09-03T17:41:05.0803080Z ...............................................................................................i.... 6500/8988
2019-09-03T17:41:08.0383704Z .................................................................................................... 6600/8988
---
2019-09-03T17:46:20.4842887Z finished in 20.826
2019-09-03T17:46:20.5070363Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-03T17:46:20.7136305Z 2019-09-03T17:46:20.7140133Z running 149 tests
2019-09-03T17:46:24.3184233Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/149
2019-09-03T17:46:26.4414644Z ..iiii..............i.........iii.i......ii......
2019-09-03T17:46:26.4416692Z 2019-09-03T17:46:26.4419374Z finished in 5.935
2019-09-03T17:46:26.4656343Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-03T17:46:26.6579048Z ---
2019-09-03T17:46:28.9519964Z finished in 2.486
2019-09-03T17:46:28.9730795Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-03T17:46:29.1434079Z 2019-09-03T17:46:29.1434536Z running 9 tests
2019-09-03T17:46:29.1436555Z iiiiiiiii
2019-09-03T17:46:29.1441872Z 2019-09-03T17:46:29.1442003Z finished in 0.171
2019-09-03T17:46:29.1671580Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-03T17:46:29.3696723Z ---
2019-09-03T17:46:49.1588626Z finished in 19.992
2019-09-03T17:46:49.1844480Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-03T17:46:49.3829485Z 2019-09-03T17:46:49.3831004Z running 123 tests
2019-09-03T17:47:15.4498182Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-03T17:47:20.6006973Z i.i.i......iii.i.....ii
2019-09-03T17:47:20.6008616Z 2019-09-03T17:47:20.6014173Z finished in 31.417
2019-09-03T17:47:20.6028548Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-03T17:47:20.6029302Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-03T17:59:34.3982756Z 2019-09-03T17:59:34.3983196Z running 459 tests
2019-09-03T17:59:53.6985043Z .................................................................................................... 100/459
2019-09-03T18:00:11.0930366Z .......................................................................................i............ 200/459
2019-09-03T18:00:25.2778803Z ..F.FF.............................................................................................. 300/459
2019-09-03T18:00:48.1333171Z ...........................................................
2019-09-03T18:00:48.1342224Z failures:
2019-09-03T18:00:48.1342288Z 2019-09-03T18:00:48.1344164Z ---- prelude/mod.rs - prelude (line 6) stdout ----
2019-09-03T18:00:48.1344164Z ---- prelude/mod.rs - prelude (line 6) stdout ----
2019-09-03T18:00:48.1345023Z error[E0523]: found two different crates with name `alloc` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
2019-09-03T18:00:48.1345337Z --> prelude/mod.rs:8:1
2019-09-03T18:00:48.1345769Z 5 | extern crate alloc;
2019-09-03T18:00:48.1345813Z | ^^^^^^^^^^^^^^^^^^^
2019-09-03T18:00:48.1345865Z 2019-09-03T18:00:48.1345911Z error: aborting due to previous error
2019-09-03T18:00:48.1345911Z error: aborting due to previous error
2019-09-03T18:00:48.1345941Z 2019-09-03T18:00:48.1346228Z Couldn't compile the test.
2019-09-03T18:00:48.1347003Z ---- raw_vec.rs - raw_vec::RawVec<T, A>::double (line 261) stdout ----
2019-09-03T18:00:48.1347746Z error[E0523]: found two different crates with name `alloc` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
2019-09-03T18:00:48.1348007Z --> raw_vec.rs:263:1
2019-09-03T18:00:48.1348203Z 4 | extern crate alloc;
2019-09-03T18:00:48.1348563Z | ^^^^^^^^^^^^^^^^^^^
2019-09-03T18:00:48.1348593Z 2019-09-03T18:00:48.1348661Z error: aborting due to previous error
2019-09-03T18:00:48.1348661Z error: aborting due to previous error
2019-09-03T18:00:48.1348690Z 2019-09-03T18:00:48.1348980Z Couldn't compile the test.
2019-09-03T18:00:48.1349709Z ---- raw_vec.rs - raw_vec::RawVec<T, A>::reserve (line 466) stdout ----
2019-09-03T18:00:48.1351393Z error[E0523]: found two different crates with name `alloc` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
2019-09-03T18:00:48.1352182Z --> raw_vec.rs:468:1
2019-09-03T18:00:48.1352339Z 4 | extern crate alloc;
2019-09-03T18:00:48.1352382Z | ^^^^^^^^^^^^^^^^^^^
2019-09-03T18:00:48.1352414Z 2019-09-03T18:00:48.1353071Z error: aborting due to previous error
---
2019-09-03T18:00:48.1356110Z 2019-09-03T18:00:48.1395974Z error: test failed, to rerun pass '--doc'
2019-09-03T18:00:48.1414048Z 2019-09-03T18:00:48.1415081Z 2019-09-03T18:00:48.1416744Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "alloc" "--" "--quiet"
2019-09-03T18:00:48.1419380Z 2019-09-03T18:00:48.1420400Z 2019-09-03T18:00:48.1425645Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-03T18:00:48.1426667Z Build completed unsuccessfully in 1:27:00
2019-09-03T18:00:48.1426667Z Build completed unsuccessfully in 1:27:00
2019-09-03T18:00:48.1484656Z == clock drift check ==
2019-09-03T18:00:48.1514647Z local time: Tue Sep 3 18:00:48 UTC 2019
2019-09-03T18:00:48.3102689Z network time: Tue, 03 Sep 2019 18:00:48 GMT
2019-09-03T18:00:48.3107816Z == end clock drift check ==
2019-09-03T18:00:48.8921054Z ##[error]Bash exited with code '1'.
2019-09-03T18:00:48.8976116Z ##[section]Starting: Checkout
2019-09-03T18:00:48.8978203Z ==============================================================================
2019-09-03T18:00:48.8978259Z Task : Get sources
2019-09-03T18:00:48.8978326Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

estebank · 2019-09-03T20:39:22Z

🤨


Doc-tests‌ alloc‌
error: no global memory allocator found but one is required; link to std or add `#[global_allocator]` to a static item that implements the GlobalAlloc trait.
error: aborting due to previous error
running 459 tests
.................................................................................................... 100/459
.......................................................................................i............ 200/459
..F.FF.............................................................................................. 300/459
.................................................................................................... 400/459
...........................................................
failures:
---- prelude/mod.rs - prelude (line 6) stdout ----
error[E0523]: found two different crates with name `alloc` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
--> prelude/mod.rs:8:1
|
5 | extern crate alloc;
| ^^^^^^^^^^^^^^^^^^^
error: aborting due to previous error
Couldn't compile the test.
---- raw_vec.rs - raw_vec::RawVec<T, A>::double (line 261) stdout ----
error[E0523]: found two different crates with name `alloc` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
--> raw_vec.rs:263:1
|
4 | extern crate alloc;
| ^^^^^^^^^^^^^^^^^^^
error: aborting due to previous error
Couldn't compile the test.
---- raw_vec.rs - raw_vec::RawVec<T, A>::reserve (line 466) stdout ----
error[E0523]: found two different crates with name `alloc` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
--> raw_vec.rs:468:1
|
4 | extern crate alloc;
| ^^^^^^^^^^^^^^^^^^^
error: aborting due to previous error
Couldn't compile the test.
failures:
prelude/mod.rs - prelude (line 6)
raw_vec.rs - raw_vec::RawVec<T, A>::double (line 261)
raw_vec.rs - raw_vec::RawVec<T, A>::reserve (line 466)
test result: FAILED. 455 passed; 3 failed; 1 ignored; 0 measured; 0 filtered out
error:‌ test failed, to rerun pass &#x27;--doc&#x27;‌
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "alloc" "--" "--quiet"
expected success, got: exit code: 101

Centril · 2019-09-04T02:13:54Z

That's odd... the error seems unrelated?

estebank · 2019-09-04T19:40:48Z

@bors retry

estebank · 2019-09-05T06:37:46Z

@Centril I'm still not sure what happened here or how my code could have caused this. Would you be ok with adding this PR to the queue on its own to see if it'll merge cleanly?

Centril · 2019-09-05T06:40:10Z

@estebank Sure, but it'll have to wait some more until the queue is a bit shorter then.

Centril · 2019-09-05T07:26:08Z

@bors rollup=never

estebank · 2019-09-05T15:48:53Z

@bors r=Centril

bors · 2019-09-05T15:48:54Z

📌 Commit c44ffaf has been approved by Centril

Do not complain about unconstrained params when Self is Ty Error Fixrust-lang#36836.

bors · 2019-09-09T00:58:45Z

⌛ Testing commit c44ffaf with merge 7eb65df...

Do not complain about unconstrained params when Self is Ty Error Fix#36836.

bors · 2019-09-09T04:44:13Z

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 7eb65df to master...

Do not complain about unconstrained params when Self is Ty Error
37f5cc2

rust-highfive assigned eddyb Sep 3, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2019

Centril reviewed Sep 3, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/constrained_generic_params.rs Outdated
Comment threadsrc/librustc_typeck/constrained_generic_params.rs Outdated
Comment threadsrc/test/ui/issues/issue-36836.rs

rust-highfive assigned Centril and unassigned eddyb Sep 3, 2019

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2019

review comments
3cb1ed4

This comment has been minimized.
Sign in to view

eddyb reviewed Sep 3, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/impl_wf_check.rs Outdated

eddyb reviewed Sep 3, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/impl_wf_check.rs

eddyb reviewed Sep 3, 2019
View reviewed changes

Comment threadsrc/librustc_typeck/impl_wf_check.rs Outdated

eddyb approved these changes Sep 3, 2019
View reviewed changes

This comment has been minimized.
Sign in to view

estebank added 2 commits September 3, 2019 09:17

fix comment and add delay_span_bug
8786671

review comment
c44ffaf

estebank force-pushed the issue-36836 branch from 86f7546 to c44ffafCompare September 3, 2019 16:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2019

Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
Rollup merge ofrust-lang#64108- estebank:issue-36836, r=Centril
63e51fc
Do not complain about unconstrained params when Self is Ty Error Fixrust-lang#36836.

Centril mentioned this pull request Sep 5, 2019
Rollup of 7 pull requests #64181
Closed

bors added a commit that referenced this pull request Sep 9, 2019
Auto merge of#64108- estebank:issue-36836, r=Centril
7eb65df
Do not complain about unconstrained params when Self is Ty Error Fix#36836.

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2019

bors merged commit c44ffaf into rust-lang:masterSep 9, 2019

estebank deleted the issue-36836 branch November 9, 2023 05:18

Uh oh!

Uh oh!

Conversation

estebank commented Sep 3, 2019

Uh oh!

rust-highfive commented Sep 3, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Centril commented Sep 3, 2019

Uh oh!

This comment has been minimized.

eddybSep 3, 2019

Choose a reason for hiding this comment

Uh oh!

CentrilSep 3, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Centril commented Sep 3, 2019

Uh oh!

Uh oh!

This comment has been minimized.

rust-highfive commented Sep 3, 2019

Uh oh!

estebank commented Sep 3, 2019

Uh oh!

Centril commented Sep 4, 2019

Uh oh!

estebank commented Sep 4, 2019

Uh oh!

estebank commented Sep 5, 2019

Uh oh!

Centril commented Sep 5, 2019

Uh oh!

Centril commented Sep 5, 2019

Uh oh!

estebank commented Sep 5, 2019

Uh oh!

bors commented Sep 5, 2019

Uh oh!

bors commented Sep 9, 2019

Uh oh!

bors commented Sep 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants